2023-10-27 15:25:55

by Arnd Bergmann

Subject: [PATCH] ALSA: hda: cs35l41: mark cs35l41_verify_id() static

From: Arnd Bergmann <[email protected]>

The newly introduced function is global but only called in this one
file and has no extern prototype, so it should probably be static:

sound/pci/hda/cs35l41_hda.c:733:5: error: no previous prototype for 'cs35l41_verify_id' [-Werror=missing-prototypes]
733 | int cs35l41_verify_id(struct cs35l41_hda *cs35l41, unsigned int *regid, unsigned int *reg_revid)

Fixes: 881b7bce0c25 ("ALSA: hda: cs35l41: Run boot process during resume callbacks")
Signed-off-by: Arnd Bergmann <[email protected]>
---
sound/pci/hda/cs35l41_hda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index 496ff6a9d300..98a5123e9f50 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -730,7 +730,7 @@ static int cs35l41_hda_channel_map(struct device *dev, unsigned int tx_num, unsi
rx_slot);
}

-int cs35l41_verify_id(struct cs35l41_hda *cs35l41, unsigned int *regid, unsigned int *reg_revid)
+static int cs35l41_verify_id(struct cs35l41_hda *cs35l41, unsigned int *regid, unsigned int *reg_revid)
{
unsigned int mtl_revid, chipid;
int ret;
--
2.39.2

2023-10-29 07:29:58

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda: cs35l41: mark cs35l41_verify_id() static

On Fri, 27 Oct 2023 17:25:09 +0200,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> The newly introduced function is global but only called in this one
> file and has no extern prototype, so it should probably be static:
>
> sound/pci/hda/cs35l41_hda.c:733:5: error: no previous prototype for 'cs35l41_verify_id' [-Werror=missing-prototypes]
> 733 | int cs35l41_verify_id(struct cs35l41_hda *cs35l41, unsigned int *regid, unsigned int *reg_revid)
>
> Fixes: 881b7bce0c25 ("ALSA: hda: cs35l41: Run boot process during resume callbacks")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thanks, applied now.


Takashi