Hi!
Since 2.6.34 the touchpad on my feb 2005 powerbook (mod. A1106) has
stopped working. I've identified the following guilty patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=04b4b88cca0ebe3813b4b6f014fb6a0db380b137
> ... Testing on one of such PowerBooks I have
> noticed that touchpad always generates positive values, but some of
> them are greater that 127, and thus, when cast to 'signed char' being
> interpreted as a negative.
My device is 05ac:020e "fountain", actually generates *signed* values,
thus the patch completely breaks it.
On Sat, 2010-08-07 at 14:00 +0000, Serge Belyshev wrote:
> Hi!
>
> Since 2.6.34 the touchpad on my feb 2005 powerbook (mod. A1106) has
> stopped working. I've identified the following guilty patch:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=04b4b88cca0ebe3813b4b6f014fb6a0db380b137
>
> > ... Testing on one of such PowerBooks I have
> > noticed that touchpad always generates positive values, but some of
> > them are greater that 127, and thus, when cast to 'signed char' being
> > interpreted as a negative.
>
> My device is 05ac:020e "fountain", actually generates *signed* values,
> thus the patch completely breaks it.
I think Ben might have the same issue. I guess we need per-touchpad
functions to read the data.
johannes
> > My device is 05ac:020e "fountain", actually generates *signed* values,
> > thus the patch completely breaks it.
>
> I think Ben might have the same issue. I guess we need per-touchpad
> functions to read the data.
Yup, I confirm, same deal. This patch completely breaks it on my
powerbook (same USB ID)
Should we revert the commit for now ?
Cheers,
Ben.
I have tested the patch on device I had
I will have an access to it to retest later thus week. We can wait for my test to try to identify how my PowerBook is different from yours. Or you can roll the patch back.
--
Sent from my iPhone
On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <[email protected]> wrote:
>
>>> My device is 05ac:020e "fountain", actually generates *signed* values,
>>> thus the patch completely breaks it.
>>
>> I think Ben might have the same issue. I guess we need per-touchpad
>> functions to read the data.
>
> Yup, I confirm, same deal. This patch completely breaks it on my
> powerbook (same USB ID)
>
> Should we revert the commit for now ?
>
> Cheers,
> Ben.
>
On Sun, 2010-08-08 at 18:24 -0700, Vadim Zaliva wrote:
> I have tested the patch on device I had
> I will have an access to it to retest later thus week. We can wait for my
> test to try to identify how my PowerBook is different from yours. Or you
> can roll the patch back.
I'd rather roll the patch back for now. I'll send the revert as part of
the next powerpc update. We'll sort things out then.
Cheers,
Ben.
>
> --
> Sent from my iPhone
>
> On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <[email protected]> wrote:
>
> >
> >>> My device is 05ac:020e "fountain", actually generates *signed* values,
> >>> thus the patch completely breaks it.
> >>
> >> I think Ben might have the same issue. I guess we need per-touchpad
> >> functions to read the data.
> >
> > Yup, I confirm, same deal. This patch completely breaks it on my
> > powerbook (same USB ID)
> >
> > Should we revert the commit for now ?
> >
> > Cheers,
> > Ben.
> >
On Sunday, August 08, 2010 08:43:09 pm Benjamin Herrenschmidt wrote:
> On Sun, 2010-08-08 at 18:24 -0700, Vadim Zaliva wrote:
> > I have tested the patch on device I had
> > I will have an access to it to retest later thus week. We can wait for my
> > test to try to identify how my PowerBook is different from yours. Or you
> > can roll the patch back.
>
> I'd rather roll the patch back for now. I'll send the revert as part of
> the next powerpc update. We'll sort things out then.
I'll be sending pull request to Linus this evening and should take care of
this as well. I guess we need to pull it out of stable as well since Vadim's
thouchpad was usable even with older code but some touchpads are completely
broken now.
We can re-instate the fix later when we make sure it works fr everyone.
Thanks.
--
Dmitry
On Mon, 2010-08-09 at 09:33 -0700, Dmitry Torokhov wrote:
>
> > I'd rather roll the patch back for now. I'll send the revert as part of
> > the next powerpc update. We'll sort things out then.
>
> I'll be sending pull request to Linus this evening and should take care of
> this as well. I guess we need to pull it out of stable as well since Vadim's
> thouchpad was usable even with older code but some touchpads are completely
> broken now.
Right.
> We can re-instate the fix later when we make sure it works fr everyone.
Yup. BTW. The pull request I sent to Linus yesterday has a revert for
that. Can you take care of stable ?
Thanks !
Cheers,
Ben.
On Tue, Jun 19, 2018 at 1:23 PM Benjamin Herrenschmidt
<[email protected]> wrote:
>
> On Sun, 2010-08-08 at 18:24 -0700, Vadim Zaliva wrote:
> > I have tested the patch on device I had
> > I will have an access to it to retest later thus week. We can wait for my
> > test to try to identify how my PowerBook is different from yours. Or you
> > can roll the patch back.
>
> I'd rather roll the patch back for now. I'll send the revert as part of
> the next powerpc update. We'll sort things out then.
>
Hmm, I just got this blast form the past and looking by the headers it
might be coming form Mauro?
Received: from mchehab by bombadil.infradead.org with local (Exim
4.90_1 #2 (Red Hat Linux)) id 1fVN9i-0002G4-I9; Tue, 19 Jun 2018
20:23:10 +0000
Received: from vger.kernel.org ([209.132.180.67]) by
bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id
1OiJGy-0000U8-Lw; Mon, 09 Aug 2010 03:43:36 +0000
Thanks.
--
Dmitry