2023-08-01 09:33:21

by Ran Sun

Subject: [PATCH] drm/amd: Clean up errors in processpptables.c

Fix the following errors reported by checkpatch:

ERROR: open brace '{' following function definitions go on the next line
ERROR: code indent should use tabs where possible
ERROR: space required before the open parenthesis '('

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
index 1866fe20f9e2..f05f011c78be 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
@@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
struct pp_power_state *ps,
uint8_t version,
- const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
+ const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
{
unsigned long rrr_index;
unsigned long tmp;
--
2.17.1

2023-08-01 10:16:25

by Jani Nikula

Subject: Re: [PATCH] drm/amd: Clean up errors in processpptables.c

On Tue, 01 Aug 2023, Ran Sun <[email protected]> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following function definitions go on the next line
> ERROR: code indent should use tabs where possible
> ERROR: space required before the open parenthesis '('

The commit message does not match the patch.

>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> index 1866fe20f9e2..f05f011c78be 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> @@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
> static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
> struct pp_power_state *ps,
> uint8_t version,
> - const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
> + const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)

How about fixing *all* the style problems in the above in one go?

How about sending these fixes in a threaded series instead of filling
everyone's inboxes with individual patches? It's 30+ patches just today
already.


BR,
Jani.

> {
> unsigned long rrr_index;
> unsigned long tmp;

--
Jani Nikula, Intel Open Source Graphics Center