2024-02-24 13:50:04

by Chengming Zhou

Subject: [PATCH] fat: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <[email protected]>
---
fs/fat/cache.c | 2 +-
fs/fat/inode.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fat/cache.c b/fs/fat/cache.c
index 738e427e2d21..2af424e200b3 100644
--- a/fs/fat/cache.c
+++ b/fs/fat/cache.c
@@ -47,7 +47,7 @@ int __init fat_cache_init(void)
{
fat_cache_cachep = kmem_cache_create("fat_cache",
sizeof(struct fat_cache),
- 0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
+ 0, SLAB_RECLAIM_ACCOUNT,
init_once);
if (fat_cache_cachep == NULL)
return -ENOMEM;
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 5c813696d1ff..d9e6fbb6f246 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -787,7 +787,7 @@ static int __init fat_init_inodecache(void)
fat_inode_cachep = kmem_cache_create("fat_inode_cache",
sizeof(struct msdos_inode_info),
0, (SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
init_once);
if (fat_inode_cachep == NULL)
return -ENOMEM;
--
2.40.1

2024-02-24 18:28:20

by OGAWA Hirofumi

Subject: Re: [PATCH] fat: remove SLAB_MEM_SPREAD flag usage

[email protected] writes:

> From: Chengming Zhou <[email protected]>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <[email protected]>

Looks good.

Acked-by: OGAWA Hirofumi <[email protected]>

Thanks.

> ---
> fs/fat/cache.c | 2 +-
> fs/fat/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 738e427e2d21..2af424e200b3 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -47,7 +47,7 @@ int __init fat_cache_init(void)
> {
> fat_cache_cachep = kmem_cache_create("fat_cache",
> sizeof(struct fat_cache),
> - 0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
> + 0, SLAB_RECLAIM_ACCOUNT,
> init_once);
> if (fat_cache_cachep == NULL)
> return -ENOMEM;
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5c813696d1ff..d9e6fbb6f246 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -787,7 +787,7 @@ static int __init fat_init_inodecache(void)
> fat_inode_cachep = kmem_cache_create("fat_inode_cache",
> sizeof(struct msdos_inode_info),
> 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> init_once);
> if (fat_inode_cachep == NULL)
> return -ENOMEM;

--
OGAWA Hirofumi <[email protected]>