2024-02-07 13:51:04

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD

On Tue, 06 Feb 2024 18:05:53 +0100,
Jean-Lo?c Charroud wrote:
>
> Fix device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".
> Add _DSD values for "ASUS UM3402" to cs35l41_config_table[].

So far, so good, but...

> Reorder alc269_fixup_tbl[] by device id and remove duplicate QUIRK
> entry for device {0x1043, 0x1f62, "ASUS UX7602ZM"}.

Don't mix up multiple things in a single patch.
The sort of the existing entries has little to do with your change.
Leave it to another patch instead (with Fixes tag for the
corresponding commit, too).


thanks,

Takashi