2016-04-22 16:20:46

by Vitaly Kuznetsov

[permalink] [raw]
Subject: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID

lsvmbus keeps its own copy of all VMBus UUIDs, add PCIe pass-through
device there to not report 'Unknown' for such devices.

Signed-off-by: Vitaly Kuznetsov <[email protected]>
---
tools/hv/lsvmbus | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus
index 162a378..e223284 100644
--- a/tools/hv/lsvmbus
+++ b/tools/hv/lsvmbus
@@ -35,6 +35,7 @@ vmbus_dev_dict = {
'{ba6163d9-04a1-4d29-b605-72e2ffb1dc7f}' : 'Synthetic SCSI Controller',
'{2f9bcc4a-0069-4af3-b76b-6fd0be528cda}' : 'Synthetic fiber channel adapter',
'{8c2eaf3d-32a7-4b09-ab99-bd1f1c86b501}' : 'Synthetic RDMA adapter',
+ '{44c4f61d-4444-4400-9d52-802e27ede19f}' : 'PCI Express pass-through',
'{276aacf4-ac15-426c-98dd-7521ad3f01fe}' : '[Reserved system device]',
'{f8e65716-3cb3-4a06-9a60-1889c5cccab5}' : '[Reserved system device]',
'{3375baf4-9e15-4b30-b765-67acb10d607b}' : '[Reserved system device]',
--
2.5.5


2016-04-23 01:21:48

by Dexuan Cui

[permalink] [raw]
Subject: RE: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID

> From: Vitaly Kuznetsov [mailto:[email protected]]
> Sent: Saturday, April 23, 2016 0:21
> To: [email protected]
> Cc: [email protected]; KY Srinivasan <[email protected]>; Haiyang
> Zhang <[email protected]>; Dexuan Cui <[email protected]>
> Subject: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID
>
> lsvmbus keeps its own copy of all VMBus UUIDs, add PCIe pass-through
> device there to not report 'Unknown' for such devices.
>
> Signed-off-by: Vitaly Kuznetsov <[email protected]>
> ---
> tools/hv/lsvmbus | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus
> index 162a378..e223284 100644
> --- a/tools/hv/lsvmbus
> +++ b/tools/hv/lsvmbus
> @@ -35,6 +35,7 @@ vmbus_dev_dict = {
> '{ba6163d9-04a1-4d29-b605-72e2ffb1dc7f}' : 'Synthetic SCSI Controller',
> '{2f9bcc4a-0069-4af3-b76b-6fd0be528cda}' : 'Synthetic fiber channel
> adapter',
> '{8c2eaf3d-32a7-4b09-ab99-bd1f1c86b501}' : 'Synthetic RDMA adapter',
> + '{44c4f61d-4444-4400-9d52-802e27ede19f}' : 'PCI Express pass-through',
Please use TAB rather than 8 space chars here. :-)

> '{276aacf4-ac15-426c-98dd-7521ad3f01fe}' : '[Reserved system device]',
> '{f8e65716-3cb3-4a06-9a60-1889c5cccab5}' : '[Reserved system
> device]',
> '{3375baf4-9e15-4b30-b765-67acb10d607b}' : '[Reserved system
> device]',
> --

Looks good to me except for the space/TAB issue.

2016-04-25 10:51:18

by Vitaly Kuznetsov

[permalink] [raw]
Subject: Re: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID

Dexuan Cui <[email protected]> writes:

>> From: Vitaly Kuznetsov [mailto:[email protected]]
>> Sent: Saturday, April 23, 2016 0:21
>> To: [email protected]
>> Cc: [email protected]; KY Srinivasan <[email protected]>; Haiyang
>> Zhang <[email protected]>; Dexuan Cui <[email protected]>
>> Subject: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID
>>
>> lsvmbus keeps its own copy of all VMBus UUIDs, add PCIe pass-through
>> device there to not report 'Unknown' for such devices.
>>
>> Signed-off-by: Vitaly Kuznetsov <[email protected]>
>> ---
>> tools/hv/lsvmbus | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus
>> index 162a378..e223284 100644
>> --- a/tools/hv/lsvmbus
>> +++ b/tools/hv/lsvmbus
>> @@ -35,6 +35,7 @@ vmbus_dev_dict = {
>> '{ba6163d9-04a1-4d29-b605-72e2ffb1dc7f}' : 'Synthetic SCSI Controller',
>> '{2f9bcc4a-0069-4af3-b76b-6fd0be528cda}' : 'Synthetic fiber channel
>> adapter',
>> '{8c2eaf3d-32a7-4b09-ab99-bd1f1c86b501}' : 'Synthetic RDMA adapter',
>> + '{44c4f61d-4444-4400-9d52-802e27ede19f}' : 'PCI Express pass-through',
> Please use TAB rather than 8 space chars here. :-)
>

Oops, I was pretty sure checkpatch.pl catches such issues but apparently
it doesn't work for python scripts. And my text editor failed me as well)

>> '{276aacf4-ac15-426c-98dd-7521ad3f01fe}' : '[Reserved system device]',
>> '{f8e65716-3cb3-4a06-9a60-1889c5cccab5}' : '[Reserved system
>> device]',
>> '{3375baf4-9e15-4b30-b765-67acb10d607b}' : '[Reserved system
>> device]',
>> --
>
> Looks good to me except for the space/TAB issue.

Sure, will send v2.

--
Vitaly