2023-04-23 13:34:19

by Claudio Migliorelli

Subject: [PATCH] Fix some coding style errors in memblock.c

This patch removes the initialization of some static variables to 0 and
`false` in the memblock source file, according to the coding style
guidelines.

Signed-off-by: Claudio Migliorelli <[email protected]>
---
mm/memblock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 25fd0626a9e7..6f0a2eda427c 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -156,10 +156,10 @@ static __refdata struct memblock_type *memblock_memory = &memblock.memory;
} while (0)

static int memblock_debug __initdata_memblock;
-static bool system_has_some_mirror __initdata_memblock = false;
+static bool system_has_some_mirror __initdata_memblock;
static int memblock_can_resize __initdata_memblock;
-static int memblock_memory_in_slab __initdata_memblock = 0;
-static int memblock_reserved_in_slab __initdata_memblock = 0;
+static int memblock_memory_in_slab __initdata_memblock;
+static int memblock_reserved_in_slab __initdata_memblock;

static enum memblock_flags __init_memblock choose_memblock_flags(void)
{
--
2.38.4

2023-05-14 11:49:12

by Mike Rapoport

Subject: Re: [PATCH] Fix some coding style errors in memblock.c

On Sun, Apr 23, 2023 at 03:29:35PM +0200, Claudio Migliorelli wrote:
> This patch removes the initialization of some static variables to 0 and
> `false` in the memblock source file, according to the coding style
> guidelines.
>
> Signed-off-by: Claudio Migliorelli <[email protected]>

Sorry for the delay.
Applied, thanks!

> mm/memblock.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 25fd0626a9e7..6f0a2eda427c 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -156,10 +156,10 @@ static __refdata struct memblock_type *memblock_memory = &memblock.memory;
> } while (0)
>
> static int memblock_debug __initdata_memblock;
> -static bool system_has_some_mirror __initdata_memblock = false;
> +static bool system_has_some_mirror __initdata_memblock;
> static int memblock_can_resize __initdata_memblock;
> -static int memblock_memory_in_slab __initdata_memblock = 0;
> -static int memblock_reserved_in_slab __initdata_memblock = 0;
> +static int memblock_memory_in_slab __initdata_memblock;
> +static int memblock_reserved_in_slab __initdata_memblock;
>
> static enum memblock_flags __init_memblock choose_memblock_flags(void)
> {
> --
> 2.38.4
>
>

--
Sincerely yours,
Mike.