LinuxLists.cc - [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of

[permalink] [raw]

Subject: [PATCH v2 3/8] Docs/gpu/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for gpu documentation index file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/gpu/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst
index eee5996acf2c..9a6c7831d7fe 100644
--- a/Documentation/gpu/index.rst
+++ b/Documentation/gpu/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: MIT
+
============================
GPU Driver Developer's Guide
============================
--
2.25.1

2023-01-22 21:37:09

[permalink] [raw]

Subject: [PATCH v2 2/8] Docs/driver-api/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for driver-api documentation index
file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/driver-api/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/driver-api/index.rst b/Documentation/driver-api/index.rst
index b208e0dac3a0..7a2584ab63c4 100644
--- a/Documentation/driver-api/index.rst
+++ b/Documentation/driver-api/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
==============================
Driver implementer's API guide
==============================
--
2.25.1

2023-01-22 21:37:10

[permalink] [raw]

Subject: [PATCH v2 1/8] Docs/crypto/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for crypto documentation index file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/crypto/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/crypto/index.rst b/Documentation/crypto/index.rst
index da5d5ad2bdf3..95b0870e09b8 100644
--- a/Documentation/crypto/index.rst
+++ b/Documentation/crypto/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
==========
Crypto API
==========
--
2.25.1

2023-01-22 21:37:13

[permalink] [raw]

Subject: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for hwmon documentation index file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/hwmon/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index c2b3c1a822dd..2186d732654f 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
===================
Hardware Monitoring
===================
--
2.25.1

2023-01-22 21:37:17

[permalink] [raw]

Subject: [PATCH v2 5/8] Docs/input/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for input documentation index file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/input/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/input/index.rst b/Documentation/input/index.rst
index 35581cd18e91..d60bf9cfe005 100644
--- a/Documentation/input/index.rst
+++ b/Documentation/input/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
===================
Input Documentation
===================
--
2.25.1

2023-01-22 21:37:19

[permalink] [raw]

Subject: [PATCH v2 6/8] Docs/mm/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for mm documentation index file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/mm/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/mm/index.rst b/Documentation/mm/index.rst
index 5a94a921ea40..c4e9fbacaf38 100644
--- a/Documentation/mm/index.rst
+++ b/Documentation/mm/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
===============================
Memory Management Documentation
===============================
--
2.25.1

2023-01-22 21:37:20

[permalink] [raw]

Subject: [PATCH v2 7/8] Docs/scheduler/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for scheduler documentation index
file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/scheduler/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/scheduler/index.rst b/Documentation/scheduler/index.rst
index 1aac972a652f..ae0229f5a9cf 100644
--- a/Documentation/scheduler/index.rst
+++ b/Documentation/scheduler/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
=========
Scheduler
=========
--
2.25.1

2023-01-22 21:37:22

[permalink] [raw]

Subject: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier

Add missing SPDX License Identifier for sound documentation index file.

Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/sound/index.rst | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/sound/index.rst b/Documentation/sound/index.rst
index 5abed5fc6485..7e67e12730d3 100644
--- a/Documentation/sound/index.rst
+++ b/Documentation/sound/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
=============================
Sound Subsystem Documentation
=============================
--
2.25.1

2023-01-23 08:10:54

by Takashi Iwai

[permalink] [raw]

Subject: Re: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier

On Sun, 22 Jan 2023 22:36:50 +0100,
SeongJae Park wrote:
>
> Add missing SPDX License Identifier for sound documentation index file.
>
> Signed-off-by: SeongJae Park <[email protected]>

Acked-by: Takashi Iwai <[email protected]>

thanks,

Takashi

> ---
> Documentation/sound/index.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/sound/index.rst b/Documentation/sound/index.rst
> index 5abed5fc6485..7e67e12730d3 100644
> --- a/Documentation/sound/index.rst
> +++ b/Documentation/sound/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> =============================
> Sound Subsystem Documentation
> =============================
> --
> 2.25.1
>

2023-01-23 15:02:41

[permalink] [raw]

Subject: Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of

SeongJae Park <[email protected]> writes:

> Some subsystem documents are missing SPDX license identifiers on index
> files. This patchset adds those.

Documentation/ is far behind on the SPDX front, and I'm all in favor of
fixing that. I do worry, though, about sticking license declarations
onto files that did not previously have them; do we know what the
original contributor's intent was?

> Changes from v1
> (https://lore.kernel.org/lkml/[email protected]/)
> - Separate from index file content changes
> - Separate patch for each subsystem doc (Alex Deucher)
> - Use MIT license for gpu (Alex Deucher)
>
> SeongJae Park (8):
> Docs/crypto/index: Add missing SPDX License Identifier
> Docs/driver-api/index: Add missing SPDX License Identifier
> Docs/gpu/index: Add missing SPDX License Identifier
> Docs/hwmon/index: Add missing SPDX License Identifier
> Docs/input/index: Add missing SPDX License Identifier
> Docs/mm/index: Add missing SPDX License Identifier
> Docs/scheduler/index: Add missing SPDX License Identifier
> Docs/sound/index: Add missing SPDX License Identifier
>
> Documentation/crypto/index.rst | 2 ++
> Documentation/driver-api/index.rst | 2 ++

I added this one, and GPLv2 is fine there.

> Documentation/gpu/index.rst | 2 ++
> Documentation/hwmon/index.rst | 2 ++
> Documentation/input/index.rst | 2 ++
> Documentation/mm/index.rst | 2 ++
> Documentation/scheduler/index.rst | 2 ++
> Documentation/sound/index.rst | 2 ++
> 8 files changed, 16 insertions(+)

Thanks,

jon

2023-01-23 16:03:30

by Pierre-Louis Bossart

[permalink] [raw]

Subject: Re: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier

On 1/23/23 02:10, Takashi Iwai wrote:
> On Sun, 22 Jan 2023 22:36:50 +0100,
> SeongJae Park wrote:
>>
>> Add missing SPDX License Identifier for sound documentation index file.
>>
>> Signed-off-by: SeongJae Park <[email protected]>
>
> Acked-by: Takashi Iwai <[email protected]>

Isn't GPL-2.0 deprecated? It should be GPL-2.0-only, no?

https://spdx.org/licenses/GPL-2.0.html

https://spdx.org/licenses/GPL-2.0-only.html

>
>
> thanks,
>
> Takashi
>
>> ---
>> Documentation/sound/index.rst | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/sound/index.rst b/Documentation/sound/index.rst
>> index 5abed5fc6485..7e67e12730d3 100644
>> --- a/Documentation/sound/index.rst
>> +++ b/Documentation/sound/index.rst
>> @@ -1,3 +1,5 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> =============================
>> Sound Subsystem Documentation
>> =============================
>> --
>> 2.25.1
>>

2023-01-24 13:53:46

by Guenter Roeck

[permalink] [raw]

Subject: Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier

On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
>
> Signed-off-by: SeongJae Park <[email protected]>

Is it documented somewhere that GPL 2.0 is the default in the absence
of an explicit SPDX or other license identifier ? I don't find it
in Documentation/process/license-rules.rst, though maybe I am missing
it.

Guenter

> ---
> Documentation/hwmon/index.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> ===================
> Hardware Monitoring
> ===================

2023-01-24 22:05:37

[permalink] [raw]

Subject: Re: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier

Pierre-Louis Bossart <[email protected]> writes:

> On 1/23/23 02:10, Takashi Iwai wrote:
>> On Sun, 22 Jan 2023 22:36:50 +0100,
>> SeongJae Park wrote:
>>>
>>> Add missing SPDX License Identifier for sound documentation index file.
>>>
>>> Signed-off-by: SeongJae Park <[email protected]>
>>
>> Acked-by: Takashi Iwai <[email protected]>
>
> Isn't GPL-2.0 deprecated? It should be GPL-2.0-only, no?
>
> https://spdx.org/licenses/GPL-2.0.html
>
> https://spdx.org/licenses/GPL-2.0-only.html

The kernel community hasn't really followed along with that change on
the part of the SPDX folks; as far as I know, GPL-2.0 is considered to
be just fine. There are currently more than twice as many GPL-2.0
declarations than GPL-2.0-only.

Thanks,

jon

2023-01-24 22:31:28

[permalink] [raw]

Subject: Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of

SeongJae Park <[email protected]> writes:

> Some subsystem documents are missing SPDX license identifiers on index
> files. This patchset adds those.
>
> Changes from v1
> (https://lore.kernel.org/lkml/[email protected]/)
> - Separate from index file content changes
> - Separate patch for each subsystem doc (Alex Deucher)
> - Use MIT license for gpu (Alex Deucher)
>
> SeongJae Park (8):
> Docs/crypto/index: Add missing SPDX License Identifier
> Docs/driver-api/index: Add missing SPDX License Identifier
> Docs/gpu/index: Add missing SPDX License Identifier
> Docs/hwmon/index: Add missing SPDX License Identifier
> Docs/input/index: Add missing SPDX License Identifier
> Docs/mm/index: Add missing SPDX License Identifier
> Docs/scheduler/index: Add missing SPDX License Identifier
> Docs/sound/index: Add missing SPDX License Identifier

So I've applied patches 2 (since I wrote the initial file) and 8 (with
Takashi's ack). The others are also fine, I think, but I hesitate to
apply license texts to files without knowing that they match the
author's intent. I hate to say it, but I think the best approach is to
send each of the remaining patches to the appropriate maintainers for
the subsystem involved.

Thanks,

jon

2023-01-24 23:03:52

[permalink] [raw]

Subject: Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of

On Tue, 24 Jan 2023 15:31:04 -0700 Jonathan Corbet <[email protected]> wrote:

> SeongJae Park <[email protected]> writes:
>
> > Some subsystem documents are missing SPDX license identifiers on index
> > files. This patchset adds those.
> >
> > Changes from v1
> > (https://lore.kernel.org/lkml/[email protected]/)
> > - Separate from index file content changes
> > - Separate patch for each subsystem doc (Alex Deucher)
> > - Use MIT license for gpu (Alex Deucher)
> >
> > SeongJae Park (8):
> > Docs/crypto/index: Add missing SPDX License Identifier
> > Docs/driver-api/index: Add missing SPDX License Identifier
> > Docs/gpu/index: Add missing SPDX License Identifier
> > Docs/hwmon/index: Add missing SPDX License Identifier
> > Docs/input/index: Add missing SPDX License Identifier
> > Docs/mm/index: Add missing SPDX License Identifier
> > Docs/scheduler/index: Add missing SPDX License Identifier
> > Docs/sound/index: Add missing SPDX License Identifier
>
> So I've applied patches 2 (since I wrote the initial file) and 8 (with
> Takashi's ack). The others are also fine, I think, but I hesitate to
> apply license texts to files without knowing that they match the
> author's intent. I hate to say it, but I think the best approach is to
> send each of the remaining patches to the appropriate maintainers for
> the subsystem involved.

That makes 100% sense, thank you, Jon!

Thanks,
SJ

>
> Thanks,
>
> jon

2023-01-31 03:44:09

by Guenter Roeck

[permalink] [raw]

Subject: Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier

On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
>

I do not feel comfortable accepting this change without confirmation
that changing the license from <none> to an explicit <GPL v2.0> is
legally acceptable.

Guenter

> Signed-off-by: SeongJae Park <[email protected]>
> ---
> Documentation/hwmon/index.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> ===================
> Hardware Monitoring
> ===================

2023-01-31 14:44:14

[permalink] [raw]

Subject: Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier

Guenter Roeck <[email protected]> writes:

> On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
>> Add missing SPDX License Identifier for hwmon documentation index file.
>>
>
> I do not feel comfortable accepting this change without confirmation
> that changing the license from <none> to an explicit <GPL v2.0> is
> legally acceptable.

As with many of these, this file was initially added by Mauro (added to
CC). Mauro, can you confirm that GPLv2 was your intention for these
index.rst files? That would clear the path for a lot of these patches.

Thanks,

jon

2023-01-31 14:48:29

[permalink] [raw]

Subject: Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier

Em Sun, 22 Jan 2023 21:36:46 +0000
SeongJae Park <[email protected]> escreveu:

> Add missing SPDX License Identifier for hwmon documentation index file.
>
> Signed-off-by: SeongJae Park <[email protected]>

Reviewed-by: Mauro Carvalho Chehab <[email protected]>
> ---
> Documentation/hwmon/index.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> ===================
> Hardware Monitoring
> ===================

Thanks,
Mauro

2023-01-31 14:51:22

[permalink] [raw]

Subject: Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier

Em Tue, 31 Jan 2023 07:44:02 -0700
Jonathan Corbet <[email protected]> escreveu:

> Guenter Roeck <[email protected]> writes:
>
> > On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> >> Add missing SPDX License Identifier for hwmon documentation index file.
> >>
> >
> > I do not feel comfortable accepting this change without confirmation
> > that changing the license from <none> to an explicit <GPL v2.0> is
> > legally acceptable.
>
> As with many of these, this file was initially added by Mauro (added to
> CC). Mauro, can you confirm that GPLv2 was your intention for these
> index.rst files? That would clear the path for a lot of these patches.

Yes, that's the intend. Feel free to add either:

Reviewed-by: Mauro Carvalho Chehab <[email protected]>

Or
Acked-by: Mauro Carvalho Chehab <[email protected]>

to Documentation/*/index.rst files I wrote that might have missing:

.. SPDX-License-Identifier: GPL-2.0

on the top of it.

Thanks,
Mauro

2023-01-31 14:58:32

[permalink] [raw]

Subject: Re: [PATCH v2 5/8] Docs/input/index: Add missing SPDX License Identifier

Em Sun, 22 Jan 2023 21:36:47 +0000
SeongJae Park <[email protected]> escreveu:

> Add missing SPDX License Identifier for input documentation index file.
>
> Signed-off-by: SeongJae Park <[email protected]>
Reviewed-by: Mauro Carvalho Chehab <[email protected]>

> ---
> Documentation/input/index.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/input/index.rst b/Documentation/input/index.rst
> index 35581cd18e91..d60bf9cfe005 100644
> --- a/Documentation/input/index.rst
> +++ b/Documentation/input/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> ===================
> Input Documentation
> ===================

Thanks,
Mauro

2023-01-31 14:59:05