2024-02-21 11:43:16

by Colin Ian King

Subject: [PATCH][next] ALSA: echoaudio: remove redundant assignment to variable clock

The variable clock is being assigned a value that is never read,
it is being re-assigned a new value in every case in the following
switch statement. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
sound/pci/echoaudio/echoaudio_3g.c:277:2: warning: Value stored
to 'clock' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
sound/pci/echoaudio/echoaudio_3g.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/pci/echoaudio/echoaudio_3g.c b/sound/pci/echoaudio/echoaudio_3g.c
index cc3c79387194..18b4d4b4d38d 100644
--- a/sound/pci/echoaudio/echoaudio_3g.c
+++ b/sound/pci/echoaudio/echoaudio_3g.c
@@ -274,7 +274,6 @@ static int set_sample_rate(struct echoaudio *chip, u32 rate)
chip->digital_mode == DIGITAL_MODE_ADAT))
return -EINVAL;

- clock = 0;
control_reg = le32_to_cpu(chip->comm_page->control_register);
control_reg &= E3G_CLOCK_CLEAR_MASK;

--
2.39.2

2024-02-22 09:06:05

by Takashi Iwai

Subject: Re: [PATCH][next] ALSA: echoaudio: remove redundant assignment to variable clock

On Wed, 21 Feb 2024 12:38:09 +0100,
Colin Ian King wrote:
>
> The variable clock is being assigned a value that is never read,
> it is being re-assigned a new value in every case in the following
> switch statement. The assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> sound/pci/echoaudio/echoaudio_3g.c:277:2: warning: Value stored
> to 'clock' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi