2020-07-16 03:57:56

by Shengjiu Wang

Subject: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

Add missed return for snd_soc_pcm_component_mmap, otherwise it always
return -EINVAL.

Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
Signed-off-by: Shengjiu Wang <[email protected]>
---
sound/soc/soc-component.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
index af9909c5492f..cde7b9c609bb 100644
--- a/sound/soc/soc-component.c
+++ b/sound/soc/soc-component.c
@@ -705,7 +705,7 @@ int snd_soc_pcm_component_mmap(struct snd_pcm_substream *substream,
/* FIXME. it returns 1st mmap now */
for_each_rtd_components(rtd, i, component)
if (component->driver->mmap)
- soc_component_ret(
+ return soc_component_ret(
component,
component->driver->mmap(component,
substream, vma));
--
2.27.0

2020-07-16 04:21:06

by Kuninori Morimoto

Subject: Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

Hi Shengjiu

> Add missed return for snd_soc_pcm_component_mmap, otherwise it always
> return -EINVAL.
>
> Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
> Signed-off-by: Shengjiu Wang <[email protected]>
> ---

Oops, indeed.
Thank you for the patch.

But it seems these functions are also missing "return"
snd_soc_pcm_component_new()
snd_soc_pcm_component_sync_stop()

Can you please care these, too ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto

2020-07-16 04:50:11

by Shengjiu Wang

Subject: Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

On Thu, Jul 16, 2020 at 12:19 PM Kuninori Morimoto
<[email protected]> wrote:
>
>
> Hi Shengjiu
>
> > Add missed return for snd_soc_pcm_component_mmap, otherwise it always
> > return -EINVAL.
> >
> > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
> > Signed-off-by: Shengjiu Wang <[email protected]>
> > ---
>
> Oops, indeed.
> Thank you for the patch.
>
> But it seems these functions are also missing "return"
> snd_soc_pcm_component_new()
> snd_soc_pcm_component_sync_stop()
>
> Can you please care these, too ?
Ok, will send v2

best regards
wang shengjiu