2016-10-06 06:25:44

by Robert Jarzmik

[permalink] [raw]
Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core

Robert Jarzmik <[email protected]> writes:

> From: Sergey Yanovich <[email protected]>
>
> pxa2xx-uart was a separate uart platform driver. It was declaring
> the same device names and numbers as 8250 driver. As a result,
> it was impossible to use 8250 driver on PXA SoCs.
>
> Upon closer examination pxa2xx-uart turned out to be a clone of
> 8250_core driver.
>
> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
> Specification Update (April 19, 2010) is dropped. 8250_core reads
> from FIFO immediately after checking DR bit in LSR.
>
> The patch leaves the original SERIAL_PXA driver around. The original
> driver is just marked DEPRECATED in Kconfig and C source. When
> the original driver is considered safe to remove, no changes
> to SERIAL_8250 will be necessary.
>
> Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
> SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
> and the original drivers are made mutually exclusive.
>
> Signed-off-by: Sergei Ianovich <[email protected]>
> CC: Heikki Krogerus <[email protected]>
> CC: James Cameron <[email protected]>
> CC: Greg Kroah-Hartman <[email protected]>
> CC: Robert Jarzmik <[email protected]>
> CC: Russell King <[email protected]>
> Reviewed-by: Heikki Krogerus <[email protected]>
> [rebased on v4.8]
> Tested-by: Robert Jarzmik <[email protected]>
> Signed-off-by: Robert Jarzmik <[email protected]>

Greg, can you take that into you tty tree please ?

Cheers.

--
Robert


2016-10-06 07:15:35

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core

On Thu, Oct 06, 2016 at 08:25:35AM +0200, Robert Jarzmik wrote:
> Robert Jarzmik <[email protected]> writes:
>
> > From: Sergey Yanovich <[email protected]>
> >
> > pxa2xx-uart was a separate uart platform driver. It was declaring
> > the same device names and numbers as 8250 driver. As a result,
> > it was impossible to use 8250 driver on PXA SoCs.
> >
> > Upon closer examination pxa2xx-uart turned out to be a clone of
> > 8250_core driver.
> >
> > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
> > Specification Update (April 19, 2010) is dropped. 8250_core reads
> > from FIFO immediately after checking DR bit in LSR.
> >
> > The patch leaves the original SERIAL_PXA driver around. The original
> > driver is just marked DEPRECATED in Kconfig and C source. When
> > the original driver is considered safe to remove, no changes
> > to SERIAL_8250 will be necessary.
> >
> > Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
> > SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
> > and the original drivers are made mutually exclusive.
> >
> > Signed-off-by: Sergei Ianovich <[email protected]>
> > CC: Heikki Krogerus <[email protected]>
> > CC: James Cameron <[email protected]>
> > CC: Greg Kroah-Hartman <[email protected]>
> > CC: Robert Jarzmik <[email protected]>
> > CC: Russell King <[email protected]>
> > Reviewed-by: Heikki Krogerus <[email protected]>
> > [rebased on v4.8]
> > Tested-by: Robert Jarzmik <[email protected]>
> > Signed-off-by: Robert Jarzmik <[email protected]>
>
> Greg, can you take that into you tty tree please ?

Please wait until after the 4.9-rc1 merge window is over before worrying
about new patches being applied to my trees...

thanks,

greg k-h

2016-10-26 19:49:51

by Robert Jarzmik

[permalink] [raw]
Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core

Greg Kroah-Hartman <[email protected]> writes:

> On Thu, Oct 06, 2016 at 08:25:35AM +0200, Robert Jarzmik wrote:
>> Robert Jarzmik <[email protected]> writes:
>>
>> > From: Sergey Yanovich <[email protected]>
>> >
>> > pxa2xx-uart was a separate uart platform driver. It was declaring
>> > the same device names and numbers as 8250 driver. As a result,
>> > it was impossible to use 8250 driver on PXA SoCs.
>> >
>> > Upon closer examination pxa2xx-uart turned out to be a clone of
>> > 8250_core driver.
>> >
>> > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
>> > Specification Update (April 19, 2010) is dropped. 8250_core reads
>> > from FIFO immediately after checking DR bit in LSR.
>> >
>> > The patch leaves the original SERIAL_PXA driver around. The original
>> > driver is just marked DEPRECATED in Kconfig and C source. When
>> > the original driver is considered safe to remove, no changes
>> > to SERIAL_8250 will be necessary.
>> >
>> > Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
>> > SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
>> > and the original drivers are made mutually exclusive.
>> >
>> > Signed-off-by: Sergei Ianovich <[email protected]>
>> > CC: Heikki Krogerus <[email protected]>
>> > CC: James Cameron <[email protected]>
>> > CC: Greg Kroah-Hartman <[email protected]>
>> > CC: Robert Jarzmik <[email protected]>
>> > CC: Russell King <[email protected]>
>> > Reviewed-by: Heikki Krogerus <[email protected]>
>> > [rebased on v4.8]
>> > Tested-by: Robert Jarzmik <[email protected]>
>> > Signed-off-by: Robert Jarzmik <[email protected]>
>>
>> Greg, can you take that into you tty tree please ?
>
> Please wait until after the 4.9-rc1 merge window is over before worrying
> about new patches being applied to my trees...

Hi Greg,

Is it a better time slot now ?

Cheers.

--
Robert