We don't keep a pointer to it around anywhere, so it's our job to free
it.
Cc: Stefan Wahren <[email protected]>
Link: https://github.com/anholt/linux/issues/101
Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Eric Anholt <[email protected]>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index ff09b8e2f9ee..937da8dd65b8 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
drm_mode_connector_update_edid_property(connector, edid);
ret = drm_add_edid_modes(connector, edid);
drm_edid_to_eld(connector, edid);
+ kfree(edid);
return ret;
}
--
2.13.3
On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
>
> Cc: Stefan Wahren <[email protected]>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <[email protected]>
Reviewed-by: Daniel Vetter <[email protected]>
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index ff09b8e2f9ee..937da8dd65b8 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
> drm_mode_connector_update_edid_property(connector, edid);
> ret = drm_add_edid_modes(connector, edid);
> drm_edid_to_eld(connector, edid);
> + kfree(edid);
>
> return ret;
> }
> --
> 2.13.3
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
> Eric Anholt <[email protected]> hat am 8. August 2017 um 22:56 geschrieben:
>
>
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
>
> Cc: Stefan Wahren <[email protected]>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <[email protected]>
Tested-by: Stefan Wahren <[email protected]>
Daniel Vetter <[email protected]> writes:
> On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
>> We don't keep a pointer to it around anywhere, so it's our job to free
>> it.
>>
>> Cc: Stefan Wahren <[email protected]>
>> Link: https://github.com/anholt/linux/issues/101
>> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
>> Signed-off-by: Eric Anholt <[email protected]>
> Reviewed-by: Daniel Vetter <[email protected]>
Pushed. Thanks!