2023-03-13 10:47:45

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH 0/2] Add Crypto Support for J784S4 SoC

This series adds the crypto node for sa2ul for j784s4 platform.

First patch adds the device-id for NAVSS without which the probe
for dma-controller fails due to 'ti,sci-dev-id' read failure.
Second patch adds the crypto node.

This series has functional dependency on j784s4 k3_soc_id[1] and
PSIL-thread support[2] but it does not affect the boot.

[1]:
<https://lore.kernel.org/all/[email protected]/>

[2]:
<https://lore.kernel.org/all/[email protected]/>

For testing the crypto support, crypto extra tests and self tests were
enabled and tcrypt tests were used to verify SHA-1/256/512, AES and DES3
algorithms.

Testing log:
<https://gist.github.com/Jayesh2000/4fe36337af6f9dc96a055359d5d6f4ca>

Jayesh Choudhary (2):
arm64: dts: ti: k3-j784s4-main: Add 'ti,sci-dev-id' for main_navss
arm64: dts: ti: k3-j784s4-main: Enable crypto accelerator

arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

--
2.25.1



2023-03-13 10:47:52

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: ti: k3-j784s4-main: Add 'ti,sci-dev-id' for main_navss

Add the TISCI device ID for main navss node.

Signed-off-by: Jayesh Choudhary <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
index 7edf324ac159..80a1b08c51a8 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
@@ -398,6 +398,7 @@ main_navss: bus@30000000 {
#address-cells = <2>;
#size-cells = <2>;
ranges = <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>;
+ ti,sci-dev-id = <280>;
dma-coherent;
dma-ranges;

--
2.25.1


2023-03-13 10:47:58

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: ti: k3-j784s4-main: Enable crypto accelerator

Add the node for SA2UL to support hardware crypto algorithms,
including SHA-1/256/512, AES, 3DES and AEAD suites.
Add rng node for hardware random number generator.

Signed-off-by: Jayesh Choudhary <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
index 80a1b08c51a8..8c1474a7bd0f 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
@@ -72,6 +72,25 @@ main_pmx0: pinctrl@11c000 {
pinctrl-single,function-mask = <0xffffffff>;
};

+ main_crypto: crypto@4e00000 {
+ compatible = "ti,j721e-sa2ul";
+ reg = <0x00 0x4e00000 0x00 0x1200>;
+ power-domains = <&k3_pds 369 TI_SCI_PD_EXCLUSIVE>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0x00 0x04e00000 0x00 0x04e00000 0x00 0x30000>;
+
+ dmas = <&main_udmap 0xca40>, <&main_udmap 0x4a40>,
+ <&main_udmap 0x4a41>;
+ dma-names = "tx", "rx1", "rx2";
+
+ rng: rng@4e10000 {
+ compatible = "inside-secure,safexcel-eip76";
+ reg = <0x00 0x4e10000 0x00 0x7d>;
+ interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ };
+
main_uart0: serial@2800000 {
compatible = "ti,j721e-uart", "ti,am654-uart";
reg = <0x00 0x02800000 0x00 0x200>;
--
2.25.1


2023-03-14 11:50:51

by Kamlesh Gurudasani

[permalink] [raw]
Subject: Re: [PATCH 0/2] Add Crypto Support for J784S4 SoC

Jayesh Choudhary <[email protected]> writes:

> This series adds the crypto node for sa2ul for j784s4 platform.
>
> First patch adds the device-id for NAVSS without which the probe
> for dma-controller fails due to 'ti,sci-dev-id' read failure.
> Second patch adds the crypto node.
>
> This series has functional dependency on j784s4 k3_soc_id[1] and
> PSIL-thread support[2] but it does not affect the boot.
>
> [1]:
> <https://lore.kernel.org/all/[email protected]/>
>
> [2]:
> <https://lore.kernel.org/all/[email protected]/>
>
> For testing the crypto support, crypto extra tests and self tests were
> enabled and tcrypt tests were used to verify SHA-1/256/512, AES and DES3
> algorithms.
>
> Testing log:
> <https://gist.github.com/Jayesh2000/4fe36337af6f9dc96a055359d5d6f4ca>
>
> Jayesh Choudhary (2):
> arm64: dts: ti: k3-j784s4-main: Add 'ti,sci-dev-id' for main_navss
> arm64: dts: ti: k3-j784s4-main: Enable crypto accelerator
>
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> --
> 2.25.1
Both patches look good to me.

Reviewed-by: Kamlesh Gurudasani <[email protected]>