2022-04-12 02:08:28

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH 1/3] timekeeping: Introduce fast accessor to clock tai

On Sat, Apr 09 2022 at 22:33, Thomas Gleixner wrote:
> On Sat, Apr 09 2022 at 09:37, Steven Rostedt wrote:
>> On Sat, 9 Apr 2022 10:12:58 +0200
>> Kurt Kanzenbach <[email protected]> wrote:
>>
>>> ---
>>> include/linux/timekeeping.h | 1 +
>>> kernel/time/timekeeping.c | 17 +++++++++++++++++
>>> 2 files changed, 18 insertions(+)
>>
>> If the time keeping folks are OK with this and ack it, I'm happy to
>> take this through my tree.
>
> Go ahead. I just sent a Reviewed-by and I don't see conflicting changes
> in that area. Famous last words :)

And yes, I have some conflicting changes in the pipeline and just saw
that this lacks a data_race() annotation like the boot variant from
which this is derived.

Let me pick this up into a rc2 based branch. I'll tag it and provide it
to you for consumption.

Thanks,

tglx


2022-04-12 20:26:43

by Kurt Kanzenbach

[permalink] [raw]
Subject: Re: [PATCH 1/3] timekeeping: Introduce fast accessor to clock tai

On Mon Apr 11 2022, Thomas Gleixner wrote:
> On Sat, Apr 09 2022 at 22:33, Thomas Gleixner wrote:
>> On Sat, Apr 09 2022 at 09:37, Steven Rostedt wrote:
>>> On Sat, 9 Apr 2022 10:12:58 +0200
>>> Kurt Kanzenbach <[email protected]> wrote:
>>>
>>>> ---
>>>> include/linux/timekeeping.h | 1 +
>>>> kernel/time/timekeeping.c | 17 +++++++++++++++++
>>>> 2 files changed, 18 insertions(+)
>>>
>>> If the time keeping folks are OK with this and ack it, I'm happy to
>>> take this through my tree.
>>
>> Go ahead. I just sent a Reviewed-by and I don't see conflicting changes
>> in that area. Famous last words :)
>
> And yes, I have some conflicting changes in the pipeline and just saw
> that this lacks a data_race() annotation like the boot variant from
> which this is derived.

Interesting, didn't see that annotation. Anyway, this patch also misses
the corresponding documentation entry. See below.

Thanks,
Kurt

diff --git a/Documentation/core-api/timekeeping.rst b/Documentation/core-api/timekeeping.rst
index 729e24864fe7..22ec68f24421 100644
--- a/Documentation/core-api/timekeeping.rst
+++ b/Documentation/core-api/timekeeping.rst
@@ -132,6 +132,7 @@ Some additional variants exist for more specialized cases:
.. c:function:: u64 ktime_get_mono_fast_ns( void )
u64 ktime_get_raw_fast_ns( void )
u64 ktime_get_boot_fast_ns( void )
+ u64 ktime_get_tai_fast_ns( void )
u64 ktime_get_real_fast_ns( void )


Attachments:
signature.asc (877.00 B)