2023-12-19 07:11:56

by Yang Jialong 杨佳龙

Subject: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()

Signed-off-by: JiaLong.Yang <[email protected]>
---
Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
index 59c6efb3fc41..cafa01bccff2 100644
--- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
+++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
@@ -100,7 +100,7 @@ printk()的用法通常是这样的::

为了调试，还有两个有条件编译的宏：
pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
-``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
+``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。


函数接口
--
2.25.1

2023-12-19 14:43:54

by Jonathan Corbet

Subject: Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()

"JiaLong.Yang" <[email protected]> writes:

> Signed-off-by: JiaLong.Yang <[email protected]>
> ---
> Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> index 59c6efb3fc41..cafa01bccff2 100644
> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>
> 为了调试，还有两个有条件编译的宏：
> pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>

This patch needs an actual changelog. Being illiterate in Chinese, I
can't make any connection between the subject line and what has actually
been done here.

Thanks,

jon

2023-12-19 18:48:09

by Zenghui Yu

Subject: Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()

On 2023/12/19 22:43, Jonathan Corbet wrote:
> "JiaLong.Yang" <[email protected]> writes:
>
>> Signed-off-by: JiaLong.Yang <[email protected]>
>> ---
>> Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>
>> 为了调试，还有两个有条件编译的宏：
>> pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>>
>
> This patch needs an actual changelog. Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

Agreed. The change itself looks correct though, feel free to add my

Reviewed-by: Zenghui Yu <[email protected]>

in your next revision (with Jon's suggestion addressed).

Thanks,
Zenghui

2023-12-20 02:01:14

by Yanteng Si

Subject: Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()

Hi JiaLong,

在 2023/12/19 22:43, Jonathan Corbet 写道:
> "JiaLong.Yang" <[email protected]> writes:
>
>> Signed-off-by: JiaLong.Yang <[email protected]>
>> ---
>> Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>
>> 为了调试，还有两个有条件编译的宏：
>> pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>>
> This patch needs an actual changelog. Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

As jon said, could you please write a commit message?

For details see: .../Documentation/translations/zh_CN/process/5.Posting.rst


Thanks,

Yanteng

>
> Thanks,
>
> jon