2022-10-20 19:08:42

by Colin Ian King

[permalink] [raw]
Subject: [PATCH] Input: tps6507x-ts: remove variable loops

The variable loops is being incremented but is never referenced,
it is redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/input/touchscreen/tps6507x-ts.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index 357a3108f2e5..f48871767763 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc,
static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
{
s32 ret;
- s32 loops = 0;
u8 val;

ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG,
@@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val);
if (ret)
return ret;
- loops++;
}

return ret;
--
2.37.3


2022-10-21 13:07:51

by Mattijs Korpershoek

[permalink] [raw]
Subject: Re: [PATCH] Input: tps6507x-ts: remove variable loops

On Thu, Oct 20, 2022 at 19:16, Colin Ian King <[email protected]> wrote:

> The variable loops is being incremented but is never referenced,
> it is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Mattijs Korpershoek <[email protected]>

> ---
> drivers/input/touchscreen/tps6507x-ts.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 357a3108f2e5..f48871767763 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc,
> static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
> {
> s32 ret;
> - s32 loops = 0;
> u8 val;
>
> ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG,
> @@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
> ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val);
> if (ret)
> return ret;
> - loops++;
> }
>
> return ret;
> --
> 2.37.3

2022-10-24 15:36:43

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] Input: tps6507x-ts: remove variable loops

On Thu, Oct 20, 2022 at 07:16:42PM +0100, Colin Ian King wrote:
> The variable loops is being incremented but is never referenced,
> it is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thank you.

--
Dmitry