2022-12-26 14:37:31

by Pali Rohár

Subject: [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions

These functions returns boolean value not wide character.

Signed-off-by: Pali Rohár <[email protected]>
---
fs/fat/namei_vfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index 21620054e1c4..0735e4f0aeed 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {

/* Characters that are undesirable in an MS-DOS file name */

-static inline wchar_t vfat_bad_char(wchar_t w)
+static inline bool vfat_bad_char(wchar_t w)
{
return (w < 0x0020)
|| (w == '*') || (w == '?') || (w == '<') || (w == '>')
@@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
|| (w == '\\');
}

-static inline wchar_t vfat_replace_char(wchar_t w)
+static inline bool vfat_replace_char(wchar_t w)
{
return (w == '[') || (w == ']') || (w == ';') || (w == ',')
|| (w == '+') || (w == '=');
--
2.20.1

2023-01-10 09:49:42

by OGAWA Hirofumi

Subject: Re: [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions

Pali Roh?r <[email protected]> writes:

> These functions returns boolean value not wide character.
>
> Signed-off-by: Pali Roh?r <[email protected]>

Thanks.

Acked-by: OGAWA Hirofumi <[email protected]>

> ---
> fs/fat/namei_vfat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 21620054e1c4..0735e4f0aeed 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
>
> /* Characters that are undesirable in an MS-DOS file name */
>
> -static inline wchar_t vfat_bad_char(wchar_t w)
> +static inline bool vfat_bad_char(wchar_t w)
> {
> return (w < 0x0020)
> || (w == '*') || (w == '?') || (w == '<') || (w == '>')
> @@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
> || (w == '\\');
> }
>
> -static inline wchar_t vfat_replace_char(wchar_t w)
> +static inline bool vfat_replace_char(wchar_t w)
> {
> return (w == '[') || (w == ']') || (w == ';') || (w == ',')
> || (w == '+') || (w == '=');

--
OGAWA Hirofumi <[email protected]>