2020-01-07 10:02:00

by Xu Wang

Subject: [PATCH] mic: Remove unneeded NULL check

debugfs_remove_recursive will do NULL check, so remove
the redundant null check.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/misc/mic/card/mic_debugfs.c | 3 ---
drivers/misc/mic/cosm/cosm_debugfs.c | 3 ---
drivers/misc/mic/host/mic_debugfs.c | 3 ---
3 files changed, 9 deletions(-)

diff --git a/drivers/misc/mic/card/mic_debugfs.c b/drivers/misc/mic/card/mic_debugfs.c
index 3ee3d24..b586088 100644
--- a/drivers/misc/mic/card/mic_debugfs.c
+++ b/drivers/misc/mic/card/mic_debugfs.c
@@ -65,9 +65,6 @@ void __init mic_create_card_debug_dir(struct mic_driver *mdrv)
*/
void mic_delete_card_debug_dir(struct mic_driver *mdrv)
{
- if (!mdrv->dbg_dir)
- return;
-
debugfs_remove_recursive(mdrv->dbg_dir);
}

diff --git a/drivers/misc/mic/cosm/cosm_debugfs.c b/drivers/misc/mic/cosm/cosm_debugfs.c
index 2fc9f4b..68a731f 100644
--- a/drivers/misc/mic/cosm/cosm_debugfs.c
+++ b/drivers/misc/mic/cosm/cosm_debugfs.c
@@ -102,9 +102,6 @@ void cosm_create_debug_dir(struct cosm_device *cdev)

void cosm_delete_debug_dir(struct cosm_device *cdev)
{
- if (!cdev->dbg_dir)
- return;
-
debugfs_remove_recursive(cdev->dbg_dir);
}

diff --git a/drivers/misc/mic/host/mic_debugfs.c b/drivers/misc/mic/host/mic_debugfs.c
index 8a8e416..ab0db7a 100644
--- a/drivers/misc/mic/host/mic_debugfs.c
+++ b/drivers/misc/mic/host/mic_debugfs.c
@@ -129,9 +129,6 @@ void mic_create_debug_dir(struct mic_device *mdev)
*/
void mic_delete_debug_dir(struct mic_device *mdev)
{
- if (!mdev->dbg_dir)
- return;
-
debugfs_remove_recursive(mdev->dbg_dir);
}

--
2.7.4

2020-01-08 02:59:16

by Dixit, Ashutosh

Subject: Re: [PATCH] mic: Remove unneeded NULL check

Reviewed-by: Ashutosh Dixit <[email protected]>

On Tue, 07 Jan 2020 02:00:35 -0800, Xu Wang wrote:
>
> debugfs_remove_recursive will do NULL check, so remove
> the redundant null check.
>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> drivers/misc/mic/card/mic_debugfs.c | 3 ---
> drivers/misc/mic/cosm/cosm_debugfs.c | 3 ---
> drivers/misc/mic/host/mic_debugfs.c | 3 ---
> 3 files changed, 9 deletions(-)
>
> diff --git a/drivers/misc/mic/card/mic_debugfs.c b/drivers/misc/mic/card/mic_debugfs.c
> index 3ee3d24..b586088 100644
> --- a/drivers/misc/mic/card/mic_debugfs.c
> +++ b/drivers/misc/mic/card/mic_debugfs.c
> @@ -65,9 +65,6 @@ void __init mic_create_card_debug_dir(struct mic_driver *mdrv)
> */
> void mic_delete_card_debug_dir(struct mic_driver *mdrv)
> {
> - if (!mdrv->dbg_dir)
> - return;
> -
> debugfs_remove_recursive(mdrv->dbg_dir);
> }
>
> diff --git a/drivers/misc/mic/cosm/cosm_debugfs.c b/drivers/misc/mic/cosm/cosm_debugfs.c
> index 2fc9f4b..68a731f 100644
> --- a/drivers/misc/mic/cosm/cosm_debugfs.c
> +++ b/drivers/misc/mic/cosm/cosm_debugfs.c
> @@ -102,9 +102,6 @@ void cosm_create_debug_dir(struct cosm_device *cdev)
>
> void cosm_delete_debug_dir(struct cosm_device *cdev)
> {
> - if (!cdev->dbg_dir)
> - return;
> -
> debugfs_remove_recursive(cdev->dbg_dir);
> }
>
> diff --git a/drivers/misc/mic/host/mic_debugfs.c b/drivers/misc/mic/host/mic_debugfs.c
> index 8a8e416..ab0db7a 100644
> --- a/drivers/misc/mic/host/mic_debugfs.c
> +++ b/drivers/misc/mic/host/mic_debugfs.c
> @@ -129,9 +129,6 @@ void mic_create_debug_dir(struct mic_device *mdev)
> */
> void mic_delete_debug_dir(struct mic_device *mdev)
> {
> - if (!mdev->dbg_dir)
> - return;
> -
> debugfs_remove_recursive(mdev->dbg_dir);
> }
>
> --
> 2.7.4
>