2023-11-17 10:36:25

by Herbert Xu

Subject: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore instruction

On Wed, Nov 08, 2023 at 03:34:54PM +0800, LeoLiu-oc wrote:
> From: LeoLiuoc <[email protected]>
>
> Add support for Zhaoxin hardware random number generator.
> This driver base on rep_xstore instruction and uses the same
> X86_FEATURE_XSTORE as via-rng driver. Therefore, modify the x86_cpu_id
> array in the via-rng driver, so that the corresponding driver can be
> correctly loader on respective platforms.
>
> ---
>
> v1 -> v2:
> 1. Fix assembler code errors
> 2. Remove redundant CPU model check codes
>
> Signed-off-by: LeoLiuoc <[email protected]>
> ---
> drivers/char/hw_random/Kconfig | 13 ++++
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/via-rng.c | 23 +++----
> drivers/char/hw_random/zhaoxin-rng.c | 95 ++++++++++++++++++++++++++++
> 4 files changed, 119 insertions(+), 13 deletions(-)
> create mode 100644 drivers/char/hw_random/zhaoxin-rng.c

Please cc [email protected] as the same comments to the other
zhaoxin driver seems to be applicable here.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2023-11-17 11:19:34

by LeoLiu-oc

Subject: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore instruction

在 2023/11/17 18:35, Herbert Xu 写道:
> On Wed, Nov 08, 2023 at 03:34:54PM +0800, LeoLiu-oc wrote:
>> From: LeoLiuoc <[email protected]>
>>
>> Add support for Zhaoxin hardware random number generator.
>> This driver base on rep_xstore instruction and uses the same
>> X86_FEATURE_XSTORE as via-rng driver. Therefore, modify the x86_cpu_id
>> array in the via-rng driver, so that the corresponding driver can be
>> correctly loader on respective platforms.
>>
>> ---
>>
>> v1 -> v2:
>> 1. Fix assembler code errors
>> 2. Remove redundant CPU model check codes
>>
>> Signed-off-by: LeoLiuoc <[email protected]>
>> ---
>> drivers/char/hw_random/Kconfig | 13 ++++
>> drivers/char/hw_random/Makefile | 1 +
>> drivers/char/hw_random/via-rng.c | 23 +++----
>> drivers/char/hw_random/zhaoxin-rng.c | 95 ++++++++++++++++++++++++++++
>> 4 files changed, 119 insertions(+), 13 deletions(-)
>> create mode 100644 drivers/char/hw_random/zhaoxin-rng.c
>
> Please cc [email protected] as the same comments to the other
> zhaoxin driver seems to be applicable here.
>
> Thanks,

Okay, Will re-send v2 add cc [email protected].


Best Regards
Leoliu-oc