2018-12-10 16:23:02

by Andrea Righi

Subject: [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions

Blacklist symbols in Xen probe-prohibited areas, so that user can see
these prohibited symbols in debugfs.

See also: a50480cb6d61.

Signed-off-by: Andrea Righi <[email protected]>
---
arch/x86/xen/xen-asm_64.S | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/x86/xen/xen-asm_64.S b/arch/x86/xen/xen-asm_64.S
index bb1c2da0381d..1e9ef0ba30a5 100644
--- a/arch/x86/xen/xen-asm_64.S
+++ b/arch/x86/xen/xen-asm_64.S
@@ -12,6 +12,7 @@
#include <asm/segment.h>
#include <asm/asm-offsets.h>
#include <asm/thread_info.h>
+#include <asm/asm.h>

#include <xen/interface/xen.h>

@@ -24,6 +25,7 @@ ENTRY(xen_\name)
pop %r11
jmp \name
END(xen_\name)
+_ASM_NOKPROBE(xen_\name)
.endm

xen_pv_trap divide_error
--
2.17.1

2018-12-11 09:44:22

by Masami Hiramatsu

Subject: Re: [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions

On Mon, 10 Dec 2018 16:12:57 +0100
Andrea Righi <[email protected]> wrote:

> Blacklist symbols in Xen probe-prohibited areas, so that user can see
> these prohibited symbols in debugfs.
>
> See also: a50480cb6d61.

Looks good to me, thanks!

Acked-by: Masami Hiramatsu <[email protected]>

>
> Signed-off-by: Andrea Righi <[email protected]>
> ---
> arch/x86/xen/xen-asm_64.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/xen/xen-asm_64.S b/arch/x86/xen/xen-asm_64.S
> index bb1c2da0381d..1e9ef0ba30a5 100644
> --- a/arch/x86/xen/xen-asm_64.S
> +++ b/arch/x86/xen/xen-asm_64.S
> @@ -12,6 +12,7 @@
> #include <asm/segment.h>
> #include <asm/asm-offsets.h>
> #include <asm/thread_info.h>
> +#include <asm/asm.h>
>
> #include <xen/interface/xen.h>
>
> @@ -24,6 +25,7 @@ ENTRY(xen_\name)
> pop %r11
> jmp \name
> END(xen_\name)
> +_ASM_NOKPROBE(xen_\name)
> .endm
>
> xen_pv_trap divide_error
> --
> 2.17.1
>


--
Masami Hiramatsu <[email protected]>

2018-12-17 21:42:31

by Boris Ostrovsky

Subject: Re: [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions

On 12/10/18 10:12 AM, Andrea Righi wrote:
> Blacklist symbols in Xen probe-prohibited areas, so that user can see
> these prohibited symbols in debugfs.
>
> See also: a50480cb6d61.
>
> Signed-off-by: Andrea Righi <[email protected]>

Applied to for-linus-4.21

-boris