2024-05-08 00:01:29

by Dr. David Alan Gilbert

Subject: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'

From: "Dr. David Alan Gilbert" <[email protected]>

struct 'sim_reg_op' doesn't look like it was ever used.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
arch/x86/pci/ce4100.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
index 87313701f069e..f5dbd25651e0f 100644
--- a/arch/x86/pci/ce4100.c
+++ b/arch/x86/pci/ce4100.c
@@ -35,12 +35,6 @@ struct sim_dev_reg {
struct sim_reg sim_reg;
};

-struct sim_reg_op {
- void (*init)(struct sim_dev_reg *reg);
- void (*read)(struct sim_dev_reg *reg, u32 value);
- void (*write)(struct sim_dev_reg *reg, u32 value);
-};
-
#define MB (1024 * 1024)
#define KB (1024)
#define SIZE_TO_MASK(size) (~(size - 1))
--
2.45.0

2024-05-08 07:27:30

by tip-bot2 for Alexey Makhalov

Subject: [tip: x86/cleanups] x86/pci/ce4100: Remove unused 'struct sim_reg_op'

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID: ad3bd7659b68add28920982e02233b5dc4b483c3
Gitweb: https://git.kernel.org/tip/ad3bd7659b68add28920982e02233b5dc4b483c3
Author: Dr. David Alan Gilbert <[email protected]>
AuthorDate: Wed, 08 May 2024 00:23:48 +01:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Wed, 08 May 2024 09:17:17 +02:00

x86/pci/ce4100: Remove unused 'struct sim_reg_op'

'struct sim_reg_op' wasn't ever used since it was introduced
14 years ago via:

91d8037f563e ("ce4100: Add PCI register emulation for CE4100")

Remove it.

[ mingo: Improved the changelog. ]

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
arch/x86/pci/ce4100.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
index 8731370..f5dbd25 100644
--- a/arch/x86/pci/ce4100.c
+++ b/arch/x86/pci/ce4100.c
@@ -35,12 +35,6 @@ struct sim_dev_reg {
struct sim_reg sim_reg;
};

-struct sim_reg_op {
- void (*init)(struct sim_dev_reg *reg);
- void (*read)(struct sim_dev_reg *reg, u32 value);
- void (*write)(struct sim_dev_reg *reg, u32 value);
-};
-
#define MB (1024 * 1024)
#define KB (1024)
#define SIZE_TO_MASK(size) (~(size - 1))

2024-05-08 07:55:25

by Ilpo Järvinen

Subject: Re: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'

On Wed, 8 May 2024, [email protected] wrote:

> From: "Dr. David Alan Gilbert" <[email protected]>
>
> struct 'sim_reg_op' doesn't look like it was ever used.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> arch/x86/pci/ce4100.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
> struct sim_reg sim_reg;
> };
>
> -struct sim_reg_op {
> - void (*init)(struct sim_dev_reg *reg);
> - void (*read)(struct sim_dev_reg *reg, u32 value);
> - void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -

Thanks.

Reviewed-by: Ilpo J?rvinen <[email protected]>

--
i.