2016-10-08 20:54:19

by Scott Branden

Subject: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm

- Add depends on COMMON_CLK for PWM_BCM_IPROC
- Enable COMPILE_TEST for broader compile coverage.
- Default y for IPROC PWM driver for IPROC SoCs.
This allows you to turn it on simply by selecting CONFIG_PWM.

Signed-off-by: Scott Branden <[email protected]>
---
drivers/pwm/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 80a566a..3eb1b6b 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -76,7 +76,9 @@ config PWM_ATMEL_TCB

config PWM_BCM_IPROC
tristate "iProc PWM support"
- depends on ARCH_BCM_IPROC
+ depends on ARCH_BCM_IPROC || COMPILE_TEST
+ depends on COMMON_CLK
+ default ARCH_BCM_IPROC
help
Generic PWM framework driver for Broadcom iProc PWM block. This
block is used in Broadcom iProc SoC's.
--
2.5.0

2016-10-08 21:03:02

by Ray Jui

Subject: Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm

On 10/8/2016 1:54 PM, Scott Branden wrote:
> - Add depends on COMMON_CLK for PWM_BCM_IPROC
> - Enable COMPILE_TEST for broader compile coverage.
> - Default y for IPROC PWM driver for IPROC SoCs.
> This allows you to turn it on simply by selecting CONFIG_PWM.
>
> Signed-off-by: Scott Branden <[email protected]>
> ---
> drivers/pwm/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 80a566a..3eb1b6b 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
>
> config PWM_BCM_IPROC
> tristate "iProc PWM support"
> - depends on ARCH_BCM_IPROC
> + depends on ARCH_BCM_IPROC || COMPILE_TEST
> + depends on COMMON_CLK
> + default ARCH_BCM_IPROC
> help
> Generic PWM framework driver for Broadcom iProc PWM block. This
> block is used in Broadcom iProc SoC's.
>

Looks good to me!

Reviewed-by: Ray Jui <[email protected]>

2016-12-20 19:32:34

by Scott Branden

Subject: Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm

Hi Thierry,

Could you pick up this patch?

On 16-10-08 02:02 PM, Ray Jui wrote:
>
>
> On 10/8/2016 1:54 PM, Scott Branden wrote:
>> - Add depends on COMMON_CLK for PWM_BCM_IPROC
>> - Enable COMPILE_TEST for broader compile coverage.
>> - Default y for IPROC PWM driver for IPROC SoCs.
>> This allows you to turn it on simply by selecting CONFIG_PWM.
>>
>> Signed-off-by: Scott Branden <[email protected]>
>> ---
>> drivers/pwm/Kconfig | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> index 80a566a..3eb1b6b 100644
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
>>
>> config PWM_BCM_IPROC
>> tristate "iProc PWM support"
>> - depends on ARCH_BCM_IPROC
>> + depends on ARCH_BCM_IPROC || COMPILE_TEST
>> + depends on COMMON_CLK
>> + default ARCH_BCM_IPROC
>> help
>> Generic PWM framework driver for Broadcom iProc PWM block. This
>> block is used in Broadcom iProc SoC's.
>>
>
> Looks good to me!
>
> Reviewed-by: Ray Jui <[email protected]>