Could someone here help settle this argument?
I have written a driver (for the CD Rom on the Sega Dreamcast). I have
marked various initialisation functions - including probe() and the
functions that it, and only it, calls, as __init.
Other developers tell me I should mark them as __devinit.
However I think this is wrong as:
* The CD on the Dreamcast is not and will never be a hotpluggable device
* The Dreamcast is a limited memory device and if marking various
functions as __init helps save memory that is A Good Thing
It has been put to me that while the use case (not hotpluggable) is
correct, it is still better practice to use __devinit
I have built the code with both __init and __devinit and both work, so
there is no issue of practicality as such here.
Adrian
On Sun, Dec 23, 2007 at 04:56:14PM +0000, Adrian McMenamin wrote:
> Could someone here help settle this argument?
>
> I have written a driver (for the CD Rom on the Sega Dreamcast). I have
> marked various initialisation functions - including probe() and the
> functions that it, and only it, calls, as __init.
>
> Other developers tell me I should mark them as __devinit.
>
> However I think this is wrong as:
>
> * The CD on the Dreamcast is not and will never be a hotpluggable device
>
> * The Dreamcast is a limited memory device and if marking various
> functions as __init helps save memory that is A Good Thing
>
> It has been put to me that while the use case (not hotpluggable) is
> correct, it is still better practice to use __devinit
If you use the register* functions of the driver model then
you are no longer in 100% control when your functions are
called.
So of the principle of least suprise it is best to use __devinit
for the probe function as most other drivers do. And if
the driver model happens to call your probe function after
init time then we will not oops.
So wit other words - use same pattern a other drivers and accept
that we could have saved a few hundred bytes extra but we do not do so.
Sam
On Mon, 24 Dec 2007 14:01:43 +0100
Sam Ravnborg <[email protected]> wrote:
> So of the principle of least suprise it is best to use __devinit
> for the probe function as most other drivers do. And if
> the driver model happens to call your probe function after
> init time then we will not oops.
If you're dealing with platform_devices, you can use
platform_driver_probe() and remove the probe() function from the
platform_driver struct to ensure this never happens.
This is only ok for non-hotpluggable devices, of course.
Haavard