2018-04-03 11:44:54

by Yunlong Song

Subject: [PATCH] f2fs: remove unmatched zero_user_segment when convert inline dentry

Since the layout of regular dentry block is different from inline dentry
block, zero_user_segment starting from MAX_INLINE_DATA(dir) is not
correct for regular dentry block, besides, bitmap is already copied and
used, so there is no necessary to zero page at all, so just remove the
zero_user_segment is OK.

Signed-off-by: Yunlong Song <[email protected]>
---
fs/f2fs/inline.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 3b77d64..573ec2f 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -367,7 +367,6 @@ static int f2fs_move_inline_dirents(struct inode *dir, struct page *ipage,
goto out;

f2fs_wait_on_page_writeback(page, DATA, true);
- zero_user_segment(page, MAX_INLINE_DATA(dir), PAGE_SIZE);

dentry_blk = page_address(page);

--
1.8.5.2

2018-04-04 01:18:18

by Chao Yu

Subject: Re: [PATCH] f2fs: remove unmatched zero_user_segment when convert inline dentry

On 2018/4/3 19:42, Yunlong Song wrote:
> Since the layout of regular dentry block is different from inline dentry
> block, zero_user_segment starting from MAX_INLINE_DATA(dir) is not
> correct for regular dentry block, besides, bitmap is already copied and
> used, so there is no necessary to zero page at all, so just remove the
> zero_user_segment is OK.
>
> Signed-off-by: Yunlong Song <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,