2024-05-29 10:21:04

by Tengfei Fan

Subject: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add IMEM and PIL info region

Add a simple-mfd representing IMEM on SA8775p and define the PIL
relocation info region, so that post mortem tools will be able
to locate the loaded remoteprocs.

Signed-off-by: Tengfei Fan <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 5632fa896b93..eb33b1587802 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -3025,6 +3025,21 @@ tlmm: pinctrl@f000000 {
wakeup-parent = <&pdc>;
};

+ sram: sram@146d8000 {
+ compatible = "qcom,sa8775p-imem", "syscon", "simple-mfd";
+ reg = <0x0 0x146d8000 0x0 0x1000>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ ranges = <0x0 0x0 0x146d8000 0x1000>;
+
+ pil-reloc@94c {
+ compatible = "qcom,pil-reloc-info";
+ reg = <0x94c 0xc8>;
+ };
+ };
+
apps_smmu: iommu@15000000 {
compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500", "arm,mmu-500";
reg = <0x0 0x15000000 0x0 0x100000>;
--
2.25.1

2024-05-29 12:37:35

by Mukesh Ojha

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add IMEM and PIL info region

On 5/29/2024 3:49 PM, Tengfei Fan wrote:
> Add a simple-mfd representing IMEM on SA8775p and define the PIL
> relocation info region, so that post mortem tools will be able
> to locate the loaded remoteprocs.
>
> Signed-off-by: Tengfei Fan <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 5632fa896b93..eb33b1587802 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -3025,6 +3025,21 @@ tlmm: pinctrl@f000000 {
> wakeup-parent = <&pdc>;
> };
>
> + sram: sram@146d8000 {
> + compatible = "qcom,sa8775p-imem", "syscon", "simple-mfd";
> + reg = <0x0 0x146d8000 0x0 0x1000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + ranges = <0x0 0x0 0x146d8000 0x1000>;

This could be moved up along with reg region.

-Mukesh

> +
> + pil-reloc@94c {
> + compatible = "qcom,pil-reloc-info";
> + reg = <0x94c 0xc8>;
> + };
> + };
> +
> apps_smmu: iommu@15000000 {
> compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500", "arm,mmu-500";
> reg = <0x0 0x15000000 0x0 0x100000>;

2024-05-30 00:27:31

by Tengfei Fan

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add IMEM and PIL info region

On 5/29/2024 8:36 PM, Mukesh Ojha wrote:
>
>
> On 5/29/2024 3:49 PM, Tengfei Fan wrote:
>> Add a simple-mfd representing IMEM on SA8775p and define the PIL
>> relocation info region, so that post mortem tools will be able
>> to locate the loaded remoteprocs.
>>
>> Signed-off-by: Tengfei Fan <[email protected]>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 5632fa896b93..eb33b1587802 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -3025,6 +3025,21 @@ tlmm: pinctrl@f000000 {
>>               wakeup-parent = <&pdc>;
>>           };
>> +        sram: sram@146d8000 {
>> +            compatible = "qcom,sa8775p-imem", "syscon", "simple-mfd";
>> +            reg = <0x0 0x146d8000 0x0 0x1000>;
>> +
>> +            #address-cells = <1>;
>> +            #size-cells = <1>;
>> +
>> +            ranges = <0x0 0x0 0x146d8000 0x1000>;
>
> This could be moved up along with reg region.
>
> -Mukesh

Sure, I will move up along with reg region in the next version patch series.

>
>> +
>> +            pil-reloc@94c {
>> +                compatible = "qcom,pil-reloc-info";
>> +                reg = <0x94c 0xc8>;
>> +            };
>> +        };
>> +
>>           apps_smmu: iommu@15000000 {
>>               compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500",
>> "arm,mmu-500";
>>               reg = <0x0 0x15000000 0x0 0x100000>;

--
Thx and BRs,
Tengfei Fan