2022-09-22 15:44:49

by Tomer Maimon

Subject: [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting

In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value
and iprst4 register wasn´t set.

This fix sets the correct IP reset values in iprst2 and iprst4 registers
in NPCM8XX USB reset sequence.

Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support")

Signed-off-by: Tomer Maimon <[email protected]>
---
drivers/reset/reset-npcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c
index 24c55efa98e5..f2333506b0a6 100644
--- a/drivers/reset/reset-npcm.c
+++ b/drivers/reset/reset-npcm.c
@@ -291,7 +291,7 @@ static void npcm_usb_reset_npcm8xx(struct npcm_rc_data *rc)
iprst2 |= ipsrst2_bits;
iprst3 |= (ipsrst3_bits | NPCM_IPSRST3_USBPHY1 |
NPCM_IPSRST3_USBPHY2);
- iprst2 |= ipsrst4_bits;
+ iprst4 |= ipsrst4_bits;

writel(iprst1, rc->base + NPCM_IPSRST1);
writel(iprst2, rc->base + NPCM_IPSRST2);
--
2.33.0

2022-09-22 16:03:06

by Philipp Zabel

Subject: Re: [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting

On Do, 2022-09-22 at 18:38 +0300, Tomer Maimon wrote:
> In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value
> and iprst4 register wasn´t set.
>
> This fix sets the correct IP reset values in iprst2 and iprst4 registers
> in NPCM8XX USB reset sequence.
>
> Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support")
>
> Signed-off-by: Tomer Maimon <[email protected]>

Thank you, applied to reset/fixes.

regards
Philipp