2023-09-04 10:09:07

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [PATCH] rcu/torture: Improve badness extraction from console logs

On Sat, Sep 02, 2023 at 08:10:13PM -0400, Joel Fernandes wrote:
> On Sat, Sep 2, 2023 at 3:24 PM Paul E. McKenney <[email protected]> wrote:
> >
> [...]
> > > > Either way, what I don't want is many megabytes of splats from console.log
> > > > duplicated into console.log.diags, especially in those (admittedly sad)
> > > > cases where the console.log file is the largest file in the results
> > > > directory. Are you really going to be reading carefully after (say)
> > > > the fifth splat? ;-)
> > >
> > > I could limit it to just the first 5, with the existing unlimited
> > > summary at the top.
> >
> > How about limiting the existing summary to (say) 10 lines? I do not
> > recall every caring about more than that. The only reason that I did
> > not ever limit it myself is that the summary is unlikely to be more than
> > a few percent of the full console.log.
> >
> > > Let me know if that works or does not work for you. :-)
> >
> > I do believe that we might be converging. ;-)
>
> Ok, so 10 lines of summary (similar to existing), and 10 detailed
> splats below that :-). If that's not Ok, let me know. Otherwise I
> will send the new patch soon. Thanks!

That works!

Thanx, Paul