2019-05-15 16:19:19

by Naveen Kumar Parna

Subject: [PATCH v3 1/1] bsr: do not use assignment in if condition

From: Naveen Kumar Parna <[email protected]>

checkpatch.pl does not like assignment in if condition

Signed-off-by: Naveen Kumar Parna <[email protected]>
---
Changes in v3:
The first patch has an extra space in if statement, so fixed it in v2 but
forgot add what changed from the previous version. In v3 added the
complete change history.

drivers/char/bsr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index a6cef548e01e..70de334554a8 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -322,7 +322,8 @@ static int __init bsr_init(void)
goto out_err_2;
}

- if ((ret = bsr_create_devs(np)) < 0) {
+ ret = bsr_create_devs(np);
+ if (ret < 0) {
np = NULL;
goto out_err_3;
}
--
2.17.1

2019-05-16 08:00:23

by Mukesh Ojha

Subject: Re: [PATCH v3 1/1] bsr: do not use assignment in if condition

On 5/15/2019 9:47 PM, [email protected] wrote:
> From: Naveen Kumar Parna <[email protected]>
>
> checkpatch.pl does not like assignment in if condition
>
> Signed-off-by: Naveen Kumar Parna <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> Changes in v3:
> The first patch has an extra space in if statement, so fixed it in v2 but
> forgot add what changed from the previous version. In v3 added the
> complete change history.
>
> drivers/char/bsr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> index a6cef548e01e..70de334554a8 100644
> --- a/drivers/char/bsr.c
> +++ b/drivers/char/bsr.c
> @@ -322,7 +322,8 @@ static int __init bsr_init(void)
> goto out_err_2;
> }
>
> - if ((ret = bsr_create_devs(np)) < 0) {
> + ret = bsr_create_devs(np);
> + if (ret < 0) {
> np = NULL;
> goto out_err_3;
> }