2019-04-15 11:46:46

by Colin King

Subject: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"

From: Colin Ian King <[email protected]>

The appears to be a spelling mistake in one of the entries in the
_SecurityCapabilities array. Fix this.

Signed-off-by: Colin Ian King <[email protected]>
---
net/netfilter/nf_conntrack_h323_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
index d880f3523c1d..95a0b3d6b24d 100644
--- a/net/netfilter/nf_conntrack_h323_types.c
+++ b/net/netfilter/nf_conntrack_h323_types.c
@@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
_NonStandardParameter},
{FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
_SecurityServiceMode},
- {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
+ {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
_SecurityServiceMode},
{FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
_SecurityServiceMode},
--
2.20.1

2019-04-16 06:52:32

by Mukesh Ojha

Subject: Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"

On 4/15/2019 5:14 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The appears to be a spelling mistake in one of the entries in the
> _SecurityCapabilities array. Fix this.
>
> Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> net/netfilter/nf_conntrack_h323_types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
> index d880f3523c1d..95a0b3d6b24d 100644
> --- a/net/netfilter/nf_conntrack_h323_types.c
> +++ b/net/netfilter/nf_conntrack_h323_types.c
> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
> _NonStandardParameter},
> {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> _SecurityServiceMode},
> - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> _SecurityServiceMode},
> {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> _SecurityServiceMode},

2019-04-16 09:13:23

by Florian Westphal

Subject: Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"

On 4/15/2019 5:14 PM, Colin King wrote:
> > diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
> > index d880f3523c1d..95a0b3d6b24d 100644
> > --- a/net/netfilter/nf_conntrack_h323_types.c
> > +++ b/net/netfilter/nf_conntrack_h323_types.c
> > @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
> > _NonStandardParameter},
> > {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > _SecurityServiceMode},
> > - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > _SecurityServiceMode},
> > {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > _SecurityServiceMode},

https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says:
...
SecurityCapabilities ::= SEQUENCE {
nonStandard NonStandardParameter OPTIONAL,
encryption SecurityServiceMode,
authenticaton SecurityServiceMode,
integrity SecurityServiceMode,
...
}

so this spelling seems intentional.

2019-04-16 09:19:44

by Colin King

Subject: Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"

On 16/04/2019 10:12, Florian Westphal wrote:
> On 4/15/2019 5:14 PM, Colin King wrote:
>>> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
>>> index d880f3523c1d..95a0b3d6b24d 100644
>>> --- a/net/netfilter/nf_conntrack_h323_types.c
>>> +++ b/net/netfilter/nf_conntrack_h323_types.c
>>> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
>>> _NonStandardParameter},
>>> {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>>> - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>>> {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>
> https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says:
> ...
> SecurityCapabilities ::= SEQUENCE {
> nonStandard NonStandardParameter OPTIONAL,
> encryption SecurityServiceMode,
> authenticaton SecurityServiceMode,
> integrity SecurityServiceMode,
> ...
> }
>
> so this spelling seems intentional.
>
Ah, thanks for spotting that, my bad.