Add base DTS file for pm8008.
Signed-off-by: Satya Priya <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
---
Changes in V14:
- None.
Changes in V13:
- None.
Changes in V12:
- None.
Changes in V11:
- Remove intermediate regulators node and add the ldos under
pm8008@8 node.
- change the address cells as 2 for pm8008 parent mfd node.
- add compatible to register the ldos.
- add reg with i2c client offset and address.
arc
arch/arm64/boot/dts/qcom/pm8008.dtsi | 54 ++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
new file mode 100644
index 0000000..6f37e4d
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
@@ -0,0 +1,54 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+
+&pm8008_bus {
+ pm8008: pmic@8 {
+ compatible = "qcom,pm8008";
+ reg = <0x8>;
+ #address-cells = <2>;
+ #size-cells = <0>;
+ #interrupt-cells = <2>;
+
+ pm8008_l1: ldo1@1,4000 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4000>;
+ regulator-name = "pm8008_ldo1";
+ };
+
+ pm8008_l2: ldo2@1,4100 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4100>;
+ regulator-name = "pm8008_ldo2";
+ };
+
+ pm8008_l3: ldo3@1,4200 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4200>;
+ regulator-name = "pm8008_ldo3";
+ };
+
+ pm8008_l4: ldo4@1,4300 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4300>;
+ regulator-name = "pm8008_ldo4";
+ };
+
+ pm8008_l5: ldo5@1,4400 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4400>;
+ regulator-name = "pm8008_ldo5";
+ };
+
+ pm8008_l6: ldo6@1,4500 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4500>;
+ regulator-name = "pm8008_ldo6";
+ };
+
+ pm8008_l7: ldo7@1,4600 {
+ compatible = "qcom,pm8008-regulator";
+ reg = <0x1 0x4600>;
+ regulator-name = "pm8008_ldo7";
+ };
+ };
+};
--
2.7.4
Hi Satya,
On Tue Jun 7, 2022 at 1:50 PM CEST, Satya Priya wrote:
> Add base DTS file for pm8008.
>
> Signed-off-by: Satya Priya <[email protected]>
> Reviewed-by: Stephen Boyd <[email protected]>
> ---
> Changes in V14:
> - None.
>
> Changes in V13:
> - None.
>
> Changes in V12:
> - None.
>
> Changes in V11:
> - Remove intermediate regulators node and add the ldos under
> pm8008@8 node.
> - change the address cells as 2 for pm8008 parent mfd node.
> - add compatible to register the ldos.
> - add reg with i2c client offset and address.
>
> arc
> arch/arm64/boot/dts/qcom/pm8008.dtsi | 54 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
> new file mode 100644
> index 0000000..6f37e4d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
> @@ -0,0 +1,54 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
I noticed this file was licensed as BSD-3-Clause in V13 and
this change was not mentioned in the "Changes" part.
Any specific reason? Especially newer dts files should be BSD-licensed,
and having this GPL dtsi included in otherwise BSD dts files is not
good.
Regards
Luca
Hi Luca,
On 6/7/2022 6:46 PM, Luca Weiss wrote:
> Hi Satya,
>
> On Tue Jun 7, 2022 at 1:50 PM CEST, Satya Priya wrote:
>> Add base DTS file for pm8008.
>>
>> Signed-off-by: Satya Priya <[email protected]>
>> Reviewed-by: Stephen Boyd <[email protected]>
>> ---
>> Changes in V14:
>> - None.
>>
>> Changes in V13:
>> - None.
>>
>> Changes in V12:
>> - None.
>>
>> Changes in V11:
>> - Remove intermediate regulators node and add the ldos under
>> pm8008@8 node.
>> - change the address cells as 2 for pm8008 parent mfd node.
>> - add compatible to register the ldos.
>> - add reg with i2c client offset and address.
>>
>> arc
>> arch/arm64/boot/dts/qcom/pm8008.dtsi | 54 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> new file mode 100644
>> index 0000000..6f37e4d
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> @@ -0,0 +1,54 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +// Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> I noticed this file was licensed as BSD-3-Clause in V13 and
> this change was not mentioned in the "Changes" part.
> Any specific reason? Especially newer dts files should be BSD-licensed,
> and having this GPL dtsi included in otherwise BSD dts files is not
> good.
I changed it as per the suggestions of Qualcomm internal review team but
i see that many of the drivers use BSD license, will change this back to
BSD-3-Clause.
> Regards
> Luca