This patchset remove some redundancy in function
arch_get_unmapped_area_topdown().
[PATCH 1/2] mm/mmap.c: Remove redundant variable 'addr' in
arch_get_unmapped_area_topdown()
[PATCH 2/2] mm/mmap.c: Remove redundant const qualifier of the no-pointer
parameters
Yang Fan (2):
mm/mmap.c: Remove redundant variable 'addr' in
arch_get_unmapped_area_topdown()
mm/mmap.c: Remove redundant const qualifier of the no-pointer
parameters
mm/mmap.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--
2.17.1
The variable 'addr' is redundant in arch_get_unmapped_area_topdown(),
just use parameter 'addr0' directly. Then remove the const qualifier
of the parameter, and change its name to 'addr'.
Signed-off-by: Yang Fan <[email protected]>
---
mm/mmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index f901065c4c64..f2d163ac827a 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2126,13 +2126,12 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr,
*/
#ifndef HAVE_ARCH_UNMAPPED_AREA_TOPDOWN
unsigned long
-arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0,
+arch_get_unmapped_area_topdown(struct file *filp, unsigned long addr,
const unsigned long len, const unsigned long pgoff,
const unsigned long flags)
{
struct vm_area_struct *vma, *prev;
struct mm_struct *mm = current->mm;
- unsigned long addr = addr0;
struct vm_unmapped_area_info info;
const unsigned long mmap_end = arch_get_mmap_end(addr);
--
2.17.1
In according with other functions, remove the const qualifier of the
no-pointer parameters in function arch_get_unmapped_area_topdown().
Signed-off-by: Yang Fan <[email protected]>
---
mm/mmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index f2d163ac827a..84cdde125d4d 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2127,8 +2127,8 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr,
#ifndef HAVE_ARCH_UNMAPPED_AREA_TOPDOWN
unsigned long
arch_get_unmapped_area_topdown(struct file *filp, unsigned long addr,
- const unsigned long len, const unsigned long pgoff,
- const unsigned long flags)
+ unsigned long len, unsigned long pgoff,
+ unsigned long flags)
{
struct vm_area_struct *vma, *prev;
struct mm_struct *mm = current->mm;
--
2.17.1
Hi,
On Sun, Jan 20, 2019 at 09:12:26AM +0100, Yang Fan wrote:
> This patchset remove some redundancy in function
> arch_get_unmapped_area_topdown().
>
> [PATCH 1/2] mm/mmap.c: Remove redundant variable 'addr' in
> arch_get_unmapped_area_topdown()
> [PATCH 2/2] mm/mmap.c: Remove redundant const qualifier of the no-pointer
> parameters
>
> Yang Fan (2):
> mm/mmap.c: Remove redundant variable 'addr' in
> arch_get_unmapped_area_topdown()
> mm/mmap.c: Remove redundant const qualifier of the no-pointer
> parameters
I think it would be better to merge these patches into one.
For the merged patch feel free to add
Reviewed-by: Mike Rapoport <[email protected]>
> mm/mmap.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --
> 2.17.1
>
--
Sincerely yours,
Mike.
> On Jan 20, 2019, at 1:13 AM, Yang Fan <[email protected]> wrote:
>
> The variable 'addr' is redundant in arch_get_unmapped_area_topdown(),
> just use parameter 'addr0' directly. Then remove the const qualifier
> of the parameter, and change its name to 'addr'.
>
> Signed-off-by: Yang Fan <[email protected]>
These seem similar enough I question whether they really need to be two
distinct patches, given both involve removing const keywords from the same
routine, and the shift to using the passed addr directly rather than
declaring and assigning addr from addr0 is a direct consequence of
removing the const.
I could be wrong though and easily persuaded otherwise.