2023-11-02 09:03:51

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH] serial: 8250_omap: Add earlycon support for the AM654 UART controller



On 31/10/23 18:42, Ronald Wahl wrote:
> From: Ronald Wahl <[email protected]>
>
> Currently there is no support for earlycon on the AM654 UART
> controller. This commit adds it.

Something like below should also work for just an early console
functionality

earlycon=ns16550a,mmio32,0x02800000

But, I think its better to have setup mapped directly to compatible. so

Reviewed-by: Vignesh Raghavendra <[email protected]>


>
> Signed-off-by: Ronald Wahl <[email protected]>
> ---
> drivers/tty/serial/8250/8250_early.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
> index 9837a27739fd..e3f482fd3de4 100644
> --- a/drivers/tty/serial/8250/8250_early.c
> +++ b/drivers/tty/serial/8250/8250_early.c
> @@ -189,5 +189,6 @@ static int __init early_omap8250_setup(struct earlycon_device *device,
> OF_EARLYCON_DECLARE(omap8250, "ti,omap2-uart", early_omap8250_setup);
> OF_EARLYCON_DECLARE(omap8250, "ti,omap3-uart", early_omap8250_setup);
> OF_EARLYCON_DECLARE(omap8250, "ti,omap4-uart", early_omap8250_setup);
> +OF_EARLYCON_DECLARE(omap8250, "ti,am654-uart", early_omap8250_setup);
>
> #endif
> --
> 2.41.0
>

--
Regards
Vignesh