2024-01-24 09:42:43

by Kunwu Chan

Subject: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
in about 14 years before.
If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <[email protected]>
---
arch/powerpc/kvm/book3s.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
index 8acec144120e..c2f50e04eec8 100644
--- a/arch/powerpc/kvm/book3s.c
+++ b/arch/powerpc/kvm/book3s.c
@@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
break;
}

-#if 0
- printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
-#endif

if (deliver)
kvmppc_inject_interrupt(vcpu, vec, 0);
--
2.39.2

2024-01-24 13:09:27

by Christophe Leroy

Subject: Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
> in about 14 years before.
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <[email protected]>
> ---
> arch/powerpc/kvm/book3s.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 8acec144120e..c2f50e04eec8 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
> break;
> }
>
> -#if 0
> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
> -#endif

Please also remove one of the two blank lines.

>
> if (deliver)
> kvmppc_inject_interrupt(vcpu, vec, 0);

2024-01-24 17:05:14

by Markus Elfring

Subject: Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

> If there are no plans to enable this part code in the future,

Will the word combination “code part” become preferred for
a subsequent change description?


> we can remove this dead code.

And omit another blank line accordingly?

Regards,
Markus

2024-01-25 08:36:37

by Kunwu Chan

Subject: Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

On 2024/1/24 21:01, Christophe Leroy wrote:
>
>
> Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
>> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
>> in about 14 years before.
>> If there are no plans to enable this part code in the future,
>> we can remove this dead code.
>>
>> Signed-off-by: Kunwu Chan <[email protected]>
>> ---
>> arch/powerpc/kvm/book3s.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
>> index 8acec144120e..c2f50e04eec8 100644
>> --- a/arch/powerpc/kvm/book3s.c
>> +++ b/arch/powerpc/kvm/book3s.c
>> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
>> break;
>> }
>>
>> -#if 0
>> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
>> -#endif
>
> Please also remove one of the two blank lines.
Thanks for your reply. I've send the v2 patch:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
>>
>> if (deliver)
>> kvmppc_inject_interrupt(vcpu, vec, 0);
--
Thanks,
Kunwu