This is the start of the stable review cycle for the 6.1.74 release.
There are 100 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 6.1.74-rc1
Carlos Llamas <[email protected]>
scripts/decode_stacktrace.sh: optionally use LLVM utilities
James Clark <[email protected]>
coresight: etm4x: Fix width of CCITMIN field
LeoLiuoc <[email protected]>
PCI: Add ACS quirk for more Zhaoxin Root Ports
Florian Eckert <[email protected]>
leds: ledtrig-tty: Free allocated ttyname buffer on deactivate
Cameron Williams <[email protected]>
parport: parport_serial: Add Brainboxes device IDs and geometry
Cameron Williams <[email protected]>
parport: parport_serial: Add Brainboxes BAR details
Guanghui Feng <[email protected]>
uio: Fix use-after-free in uio_open
Carlos Llamas <[email protected]>
binder: fix comment on binder_alloc_new_buf() return value
Carlos Llamas <[email protected]>
binder: fix trivial typo of binder_free_buf_locked()
Carlos Llamas <[email protected]>
binder: fix use-after-free in shinker's callback
Carlos Llamas <[email protected]>
binder: use EPOLLERR from eventpoll.h
Junxiao Bi <[email protected]>
Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d"
Fedor Pchelkin <[email protected]>
ksmbd: free ppace array on error in parse_dacl
Namjae Jeon <[email protected]>
ksmbd: don't allow O_TRUNC open on read-only share
Alan Maguire <[email protected]>
bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25
Martin Rodriguez Reboredo <[email protected]>
btf, scripts: Exclude Rust CUs with pahole
Peter Ujfalusi <[email protected]>
ASoC: SOF: Intel: hda-codec: Delay the codec device registration
Hans de Goede <[email protected]>
ACPI: resource: Add another DMI match for the TongFang GMxXGxx
Tom Jason Schwanke <[email protected]>
ALSA: hda/realtek: Fix mute and mic-mute LEDs for HP Envy X360 13-ay0xxx
Jani Nikula <[email protected]>
drm/crtc: fix uninitialized variable use
Stefan Wahren <[email protected]>
ARM: sun9i: smp: fix return code check of of_property_match_string
Sarannya S <[email protected]>
net: qrtr: ns: Return 0 if server port is not present
Stefan Hajnoczi <[email protected]>
virtio_blk: fix snprintf truncation compiler warning
Matthew Wilcox (Oracle) <[email protected]>
ida: Fix crash in ida_free when the bitmap is empty
Patrick Rudolph <[email protected]>
pinctrl: cy8c95x0: Fix get_pincfg
Patrick Rudolph <[email protected]>
pinctrl: cy8c95x0: Fix typo
Charlene Liu <[email protected]>
drm/amd/display: get dprefclk ss info from integration info table
Jensen Huang <[email protected]>
i2c: rk3x: fix potential spinlock recursion on poll
Paulo Alcantara <[email protected]>
smb: client: fix potential OOB in smb2_dump_detail()
Guilherme G. Piccoli <[email protected]>
HID: nintendo: Prevent divide-by-zero on code
Mike Snitzer <[email protected]>
dm audit: fix Kconfig so DM_AUDIT depends on BLK_DEV_DM
Stefan Binding <[email protected]>
ALSA: hda/realtek: Add quirks for ASUS Zenbook 2022 Models
Hans de Goede <[email protected]>
ASoC: Intel: bytcr_rt5640: Add new swapped-speakers quirk
Hans de Goede <[email protected]>
ASoC: Intel: bytcr_rt5640: Add quirk for the Medion Lifetab S10346
Vishnu Sankar <[email protected]>
platform/x86: thinkpad_acpi: fix for incorrect fan reporting on some ThinkPad systems
Ryan McClelland <[email protected]>
HID: nintendo: fix initializer element is not constant error
Ghanshyam Agrawal <[email protected]>
kselftest: alsa: fixed a print formatting warning
Luca Weiss <[email protected]>
Input: xpad - add Razer Wolverine V2 support
Avraham Stern <[email protected]>
wifi: iwlwifi: pcie: avoid a NULL pointer dereference
Vineet Gupta <[email protected]>
ARC: fix spare error
Vineeth Vijayan <[email protected]>
s390/scm: fix virtual vs physical address confusion
Esther Shimanovich <[email protected]>
Input: i8042 - add nomux quirk for Acer P459-G2-M
Hans de Goede <[email protected]>
Input: atkbd - skip ATKBD_CMD_GETID in translated mode
Krzysztof Kozlowski <[email protected]>
reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning
José Pekkarinen <[email protected]>
Input: psmouse - enable Synaptics InterTouch for ThinkPad L14 G1
Steven Rostedt (Google) <[email protected]>
ring-buffer: Do not record in NMI if the arch does not support cmpxchg in NMI
Zheng Yejian <[email protected]>
tracing: Fix uaf issue when open the hist or hist_debug file
Krzysztof Kozlowski <[email protected]>
MIPS: dts: loongson: drop incorrect dwmac fallback compatible
Krzysztof Kozlowski <[email protected]>
stmmac: dwmac-loongson: drop useless check for compatible fallback
Steven Rostedt (Google) <[email protected]>
tracing: Add size check when printing trace_marker output
Steven Rostedt (Google) <[email protected]>
tracing: Have large events show up as '[LINE TOO BIG]' instead of nothing
Ye Bin <[email protected]>
jbd2: fix soft lockup in journal_finish_inode_data_buffers()
Hans de Goede <[email protected]>
platform/x86: intel-vbtn: Fix missing tablet-mode-switch events
Judy Hsiao <[email protected]>
neighbour: Don't let neigh_forced_gc() disable preemption for long
Ziqi Zhao <[email protected]>
drm/crtc: Fix uninit-value bug in drm_mode_setcrtc
Zhang Yi <[email protected]>
jbd2: increase the journal IO's priority
Zhang Yi <[email protected]>
jbd2: correct the printing of write_flags in jbd2_write_superblock()
Weihao Li <[email protected]>
clk: rockchip: rk3128: Fix HCLK_OTG gate register
Chris Morgan <[email protected]>
clk: rockchip: rk3568: Add PLL rate for 292.5MHz
Hengqi Chen <[email protected]>
LoongArch: Preserve syscall nr across execve()
Armin Wolf <[email protected]>
hwmon: (corsair-psu) Fix probe when built-in
Inki Dae <[email protected]>
drm/exynos: fix a wrong error checking
Xiang Yang <[email protected]>
drm/exynos: fix a potential error pointer dereference
Lijo Lazar <[email protected]>
drm/amdgpu: Add NULL checks for function pointers
Stefan Wiehler <[email protected]>
mips/smp: Call rcutree_report_cpu_starting() earlier
Rob Herring <[email protected]>
arm64: dts: rockchip: Fix PCI node addresses on rk3399-gru
Nitesh Shetty <[email protected]>
nvme: prevent potential spectre v1 gadget
Keith Busch <[email protected]>
nvme: introduce helper function to get ctrl state
Srinivas Kandagatla <[email protected]>
ASoC: ops: add correct range check for limiting volume
David Rau <[email protected]>
ASoC: da7219: Support low DC impedance headset
Thinh Tran <[email protected]>
net/tg3: fix race condition in tg3_reset_task()
Peter Ujfalusi <[email protected]>
ASoC: hdac_hda: Conditionally register dais for HDMI and Analog
Jeremy Soller <[email protected]>
ASoC: amd: yc: Add DMI entry to support System76 Pangolin 13
Dave Airlie <[email protected]>
nouveau/tu102: flush all pdbs on vmm flush
Peter Ujfalusi <[email protected]>
ASoC: Intel: skl_hda_dsp_generic: Drop HDMI routes when HDMI is not available
Shuming Fan <[email protected]>
ASoC: rt5650: add mutex to avoid the jack detection failure
Maciej Strozek <[email protected]>
ASoC: cs43130: Fix incorrect frame delay configuration
Maciej Strozek <[email protected]>
ASoC: cs43130: Fix the position of const qualifier
Kamil Duljas <[email protected]>
ASoC: Intel: Skylake: mem leak in skl register function
David Lin <[email protected]>
ASoC: nau8822: Fix incorrect type in assignment and cast to restricted __be16
Kamil Duljas <[email protected]>
ASoC: Intel: Skylake: Fix mem leak in few functions
Heiko Stuebner <[email protected]>
arm64: dts: rockchip: fix rk356x pcie msg interrupt name
Charles Keepax <[email protected]>
ASoC: wm8974: Correct boost mixer inputs
Yicong Yang <[email protected]>
hwtracing: hisi_ptt: Don't try to attach a task
Yicong Yang <[email protected]>
hwtracing: hisi_ptt: Handle the interrupt in hardirq context
Keith Busch <[email protected]>
nvme-core: check for too small lba shift
Ming Lei <[email protected]>
blk-mq: don't count completed flush data request as inflight in case of quiesce
Dmitry Antipov <[email protected]>
smb: client, common: fix fortify warnings
Lu Yao <[email protected]>
drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer
Dmytro Laktyushkin <[email protected]>
drm/amd/display: update dcn315 lpddr pstate latency
Maurizio Lombardi <[email protected]>
nvme-core: fix a memory leak in nvme_ns_info_from_identify()
Peter Ujfalusi <[email protected]>
ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format
Johannes Berg <[email protected]>
debugfs: fix automount d_fsdata usage
Ben Greear <[email protected]>
wifi: mac80211: handle 320 MHz in ieee80211_ht_cap_ie_to_sta_ht_cap
Michael-CY Lee <[email protected]>
wifi: avoid offset calculation on NULL pointer
Johannes Berg <[email protected]>
wifi: cfg80211: lock wiphy mutex for rfkill poll
Edward Adam Davis <[email protected]>
mptcp: fix uninit-value in mptcp_incoming_options
Vasiliy Kovalev <[email protected]>
ALSA: hda - Fix speaker and headset mic pin config for CHUWI CoreBook XPro
Charles Keepax <[email protected]>
pinctrl: lochnagar: Don't build on MIPS
Eric Biggers <[email protected]>
f2fs: explicitly null-terminate the xattr list
-------------
Diffstat:
Makefile | 4 +-
arch/arc/kernel/signal.c | 6 +-
arch/arm/mach-sunxi/mc_smp.c | 4 +-
.../boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 3 +-
.../boot/dts/rockchip/rk3399-gru-scarlet-dumo.dts | 4 +-
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 +
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
arch/loongarch/include/asm/elf.h | 2 +-
arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 3 +-
arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 3 +-
arch/mips/kernel/smp.c | 4 +-
block/blk-mq.c | 14 +++-
drivers/acpi/resource.c | 7 ++
drivers/android/binder.c | 2 +-
drivers/android/binder_alloc.c | 10 ++-
drivers/block/virtio_blk.c | 8 +-
drivers/clk/rockchip/clk-rk3128.c | 2 +-
drivers/clk/rockchip/clk-rk3568.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++
drivers/gpu/drm/amd/amdgpu/soc15.c | 12 ++-
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 19 +++--
.../amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 8 +-
.../amd/display/include/grph_object_ctrl_defs.h | 2 +
drivers/gpu/drm/drm_crtc.c | 8 +-
drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c | 2 +-
drivers/hid/hid-nintendo.c | 71 +++++++++-------
drivers/hwmon/corsair-psu.c | 18 +++-
drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
drivers/hwtracing/ptt/hisi_ptt.c | 9 +-
drivers/i2c/busses/i2c-rk3x.c | 13 ++-
drivers/input/joystick/xpad.c | 1 +
drivers/input/keyboard/atkbd.c | 46 +++++++++-
drivers/input/mouse/synaptics.c | 1 +
drivers/input/serio/i8042-acpipnpio.h | 8 ++
drivers/leds/trigger/ledtrig-tty.c | 4 +
drivers/md/Kconfig | 1 +
drivers/md/raid5.c | 12 ---
drivers/net/ethernet/broadcom/tg3.c | 11 ++-
.../net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 --
drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
drivers/nvme/host/core.c | 12 ++-
drivers/nvme/host/nvme.h | 5 ++
drivers/nvme/target/configfs.c | 3 +
drivers/parport/parport_serial.c | 64 ++++++++++++++
drivers/pci/quirks.c | 8 +-
drivers/pinctrl/cirrus/Kconfig | 3 +-
drivers/pinctrl/pinctrl-cy8c95x0.c | 4 +-
drivers/platform/x86/intel/vbtn.c | 19 ++++-
drivers/platform/x86/thinkpad_acpi.c | 98 +++++++++++++++++++---
drivers/reset/hisilicon/hi6220_reset.c | 2 +-
drivers/s390/block/scm_blk.c | 7 +-
drivers/uio/uio.c | 7 +-
fs/debugfs/file.c | 8 ++
fs/debugfs/inode.c | 27 ++++--
fs/debugfs/internal.h | 10 ++-
fs/f2fs/xattr.c | 6 ++
fs/jbd2/commit.c | 10 ++-
fs/jbd2/journal.c | 24 +++---
fs/smb/client/cifspdu.h | 24 +++---
fs/smb/client/cifssmb.c | 6 +-
fs/smb/client/smb2misc.c | 30 +++----
fs/smb/client/smb2ops.c | 6 +-
fs/smb/client/smb2pdu.c | 8 +-
fs/smb/client/smb2pdu.h | 16 ++--
fs/smb/common/smb2pdu.h | 17 ++--
fs/smb/server/smb2pdu.c | 23 ++---
fs/smb/server/smbacl.c | 11 ++-
include/linux/ieee80211.h | 4 +-
include/linux/jbd2.h | 3 +
init/Kconfig | 2 +-
kernel/trace/ring_buffer.c | 6 ++
kernel/trace/trace.c | 12 ++-
kernel/trace/trace.h | 1 +
kernel/trace/trace_events_hist.c | 12 ++-
kernel/trace/trace_output.c | 6 +-
lib/Kconfig.debug | 9 ++
lib/idr.c | 2 +-
lib/test_ida.c | 40 +++++++++
net/core/neighbour.c | 9 +-
net/mac80211/ht.c | 1 +
net/mptcp/options.c | 1 +
net/qrtr/ns.c | 4 +-
net/wireless/core.c | 2 +
scripts/decode_stacktrace.sh | 19 ++++-
scripts/pahole-flags.sh | 7 ++
sound/hda/intel-nhlt.c | 33 +++++++-
sound/pci/hda/patch_realtek.c | 16 +++-
sound/soc/amd/yc/acp6x-mach.c | 7 ++
sound/soc/codecs/cs43130.c | 6 +-
sound/soc/codecs/da7219-aad.c | 2 +-
sound/soc/codecs/hdac_hda.c | 23 ++++-
sound/soc/codecs/nau8822.c | 9 +-
sound/soc/codecs/rt5645.c | 10 ++-
sound/soc/codecs/wm8974.c | 6 +-
sound/soc/intel/boards/bytcr_rt5640.c | 31 +++++--
sound/soc/intel/boards/skl_hda_dsp_generic.c | 2 +
sound/soc/intel/skylake/skl-pcm.c | 9 +-
sound/soc/intel/skylake/skl-sst-ipc.c | 4 +-
sound/soc/soc-ops.c | 2 +-
sound/soc/sof/intel/hda-codec.c | 18 ++--
tools/testing/selftests/alsa/mixer-test.c | 2 +-
103 files changed, 843 insertions(+), 286 deletions(-)
Hi!
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-6.1.y
Tested-by: Pavel Machek (CIP) <[email protected]>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hello,
On Thu, 18 Jan 2024 11:48:08 +0100 Greg Kroah-Hartman <[email protected]> wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
This rc kernel passes DAMON functionality test[1] on my test machine.
Attaching the test results summary below. Please note that I retrieved the
kernel from linux-stable-rc tree[2].
Tested-by: SeongJae Park <[email protected]>
[1] https://github.com/awslabs/damon-tests/tree/next/corr
[2] 1ffea4b3e361 ("Linux 6.1.74-rc1")
Thanks,
SJ
[...]
---
ok 1 selftests: damon: debugfs_attrs.sh
ok 2 selftests: damon: debugfs_schemes.sh
ok 3 selftests: damon: debugfs_target_ids.sh
ok 4 selftests: damon: debugfs_empty_targets.sh
ok 5 selftests: damon: debugfs_huge_count_read_write.sh
ok 6 selftests: damon: debugfs_duplicate_context_creation.sh
ok 7 selftests: damon: sysfs.sh
ok 1 selftests: damon-tests: kunit.sh
ok 2 selftests: damon-tests: huge_count_read_write.sh
ok 3 selftests: damon-tests: buffer_overflow.sh
ok 4 selftests: damon-tests: rm_contexts.sh
ok 5 selftests: damon-tests: record_null_deref.sh
ok 6 selftests: damon-tests: dbgfs_target_ids_read_before_terminate_race.sh
ok 7 selftests: damon-tests: dbgfs_target_ids_pid_leak.sh
ok 8 selftests: damon-tests: damo_tests.sh
ok 9 selftests: damon-tests: masim-record.sh
ok 10 selftests: damon-tests: build_i386.sh
ok 11 selftests: damon-tests: build_arm64.sh
ok 12 selftests: damon-tests: build_m68k.sh
ok 13 selftests: damon-tests: build_i386_idle_flag.sh
ok 14 selftests: damon-tests: build_i386_highpte.sh
ok 15 selftests: damon-tests: build_nomemcg.sh
[33m
[92mPASS [39m
+Stefan,
On 1/18/24 02:48, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
ARM and ARM64 builds worked fine and passed tests, however BMIPS_GENERIC
fails to build with:
arch/mips/kernel/smp.c: In function 'start_secondary':
arch/mips/kernel/smp.c:340:2: error: implicit declaration of function
'rcutree_report_cpu_starting'; did you mean 'rcu_cpu_starting'?
[-Werror=implicit-function-declaration]
rcutree_report_cpu_starting(cpu);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
rcu_cpu_starting
cc1: all warnings being treated as errors
host-make[5]: *** [scripts/Makefile.build:250: arch/mips/kernel/smp.o]
Error 1
host-make[4]: *** [scripts/Makefile.build:500: arch/mips/kernel] Error 2
host-make[3]: *** [scripts/Makefile.build:500: arch/mips] Error 2
host-make[3]: *** Waiting for unfinished jobs....
which is caused by 7c20a4cc189eff36d5aeb586008a540d8024fbff ("mips/smp:
Call rcutree_report_cpu_starting() earlier").
It looks like rcutree_report_cpu_starting() has been introduced
448e9f34d91d1a4799fdb06a93c2c24b34b6fd9d ("rcu: Standardize explicit
CPU-hotplug calls") which is in v6.7.
For MIPS, it would like an adequate fix would be to
's/rcutree_report_cpu_starting/rcu_cpu_starting/' for the 6.1 and 6.6
branches.
Stefan, do you agree?
--
Florian
On 2024-01-18 11:48 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Builds and works fine for me on x86_64.
Tested-by: Sven Joachim <[email protected]>
Cheers,
Sven
On 1/18/24 03:48, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <[email protected]>
thanks,
-- Shuah
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my x86_64 and ARM64 test systems. No errors or
regressions.
Tested-by: Allen Pais <[email protected]>
Thanks.
On Fri, 19 Jan 2024 at 00:40, Florian Fainelli <[email protected]> wrote:
>
> +Stefan,
>
> On 1/18/24 02:48, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.74 release.
> > There are 100 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> ARM and ARM64 builds worked fine and passed tests, however BMIPS_GENERIC
> fails to build with:
Following MIPS builds failed on 6.6.y and 6.1.y
but passed 6.7.y and Linux-next and mainline builds.
mips:
* build/clang-17-defconfig
* build/clang-nightly-defconfig
* build/gcc-12-allmodconfig
* build/gcc-12-cavium_octeon_defconfig
* build/gcc-12-defconfig
* build/gcc-12-malta_defconfig
* build/gcc-8-allmodconfig
* build/gcc-8-cavium_octeon_defconfig
* build/gcc-8-defconfig
* build/gcc-8-malta_defconfig
Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> arch/mips/kernel/smp.c: In function 'start_secondary':
> arch/mips/kernel/smp.c:340:2: error: implicit declaration of function
> 'rcutree_report_cpu_starting'; did you mean 'rcu_cpu_starting'?
> [-Werror=implicit-function-declaration]
> rcutree_report_cpu_starting(cpu);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> rcu_cpu_starting
> cc1: all warnings being treated as errors
> host-make[5]: *** [scripts/Makefile.build:250: arch/mips/kernel/smp.o]
same here,
>
> which is caused by 7c20a4cc189eff36d5aeb586008a540d8024fbff ("mips/smp:
> Call rcutree_report_cpu_starting() earlier").
>
> It looks like rcutree_report_cpu_starting() has been introduced
> 448e9f34d91d1a4799fdb06a93c2c24b34b6fd9d ("rcu: Standardize explicit
> CPU-hotplug calls") which is in v6.7.
>
> For MIPS, it would like an adequate fix would be to
> 's/rcutree_report_cpu_starting/rcu_cpu_starting/' for the 6.1 and 6.6
> branches.
>
> Stefan, do you agree?
> --
> Florian
--
Linaro LKFT
https://lkft.linaro.org
On Thu, Jan 18, 2024 at 11:10:31AM -0800, Florian Fainelli wrote:
> +Stefan,
>
> On 1/18/24 02:48, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.74 release.
> > There are 100 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> ARM and ARM64 builds worked fine and passed tests, however BMIPS_GENERIC
> fails to build with:
>
> arch/mips/kernel/smp.c: In function 'start_secondary':
> arch/mips/kernel/smp.c:340:2: error: implicit declaration of function
> 'rcutree_report_cpu_starting'; did you mean 'rcu_cpu_starting'?
> [-Werror=implicit-function-declaration]
> rcutree_report_cpu_starting(cpu);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> rcu_cpu_starting
> cc1: all warnings being treated as errors
> host-make[5]: *** [scripts/Makefile.build:250: arch/mips/kernel/smp.o] Error
> 1
> host-make[4]: *** [scripts/Makefile.build:500: arch/mips/kernel] Error 2
> host-make[3]: *** [scripts/Makefile.build:500: arch/mips] Error 2
> host-make[3]: *** Waiting for unfinished jobs....
>
> which is caused by 7c20a4cc189eff36d5aeb586008a540d8024fbff ("mips/smp: Call
> rcutree_report_cpu_starting() earlier").
>
> It looks like rcutree_report_cpu_starting() has been introduced
> 448e9f34d91d1a4799fdb06a93c2c24b34b6fd9d ("rcu: Standardize explicit
> CPU-hotplug calls") which is in v6.7.
>
> For MIPS, it would like an adequate fix would be to
> 's/rcutree_report_cpu_starting/rcu_cpu_starting/' for the 6.1 and 6.6
> branches.
>
> Stefan, do you agree?
The offending commit has been dropped from the queue, sorry, I didn't
push out a new -rc yet.
greg k-h
Hi Greg,
On 18/01/2024 11:48, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
I tested 6.1.74-rc1 (1ffea4b3e361) on Kalray kvx arch (not upstream yet), just to let you know everything works in our CI.
It ran on real hw (k200 and k200lp boards), on qemu as well as on our internal instruction set simulator (ISS).
Tests were run on several interfaces/drivers (usb, qsfp ethernet, eMMC, PCIe endpoint+RC, SPI, remoteproc, uart, iommu). LTP and uClibc-ng testsuites are also run without any regression.
Everything looks fine to us.
Tested-by: Yann Sionneau <[email protected]>
Thanks a lot!
--
Yann
On Thu, 18 Jan 2024 11:48:08 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v6.1:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
116 tests: 116 pass, 0 fail
Linux version: 6.1.74-rc1-g1ffea4b3e361
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by: Jon Hunter <[email protected]>
Jon
Hi Florian,
> It looks like rcutree_report_cpu_starting() has been introduced
> 448e9f34d91d1a4799fdb06a93c2c24b34b6fd9d ("rcu: Standardize explicit
> CPU-hotplug calls") which is in v6.7.
>
> For MIPS, it would like an adequate fix would be to
> 's/rcutree_report_cpu_starting/rcu_cpu_starting/' for the 6.1 and 6.6
> branches.
>
> Stefan, do you agree?
Yes, I agree, that is also how the patch looks like in our internal
branch based on 5.15.
Kind regards,
Stefan
On Fri, Jan 19, 2024 at 05:07:08PM +0100, Stefan Wiehler wrote:
> Hi Florian,
>
> > It looks like rcutree_report_cpu_starting() has been introduced
> > 448e9f34d91d1a4799fdb06a93c2c24b34b6fd9d ("rcu: Standardize explicit
> > CPU-hotplug calls") which is in v6.7.
> >
> > For MIPS, it would like an adequate fix would be to
> > 's/rcutree_report_cpu_starting/rcu_cpu_starting/' for the 6.1 and 6.6
> > branches.
> >
> > Stefan, do you agree?
>
> Yes, I agree, that is also how the patch looks like in our internal branch
> based on 5.15.
Great, can someone send a working version of this patch for us to apply
for the next round of releases? It's dropped from all queues right now.
thanks,
greg k-h
rcu_cpu_starting() must be called before clockevents_register_device() to avoid
the following lockdep splat triggered by calling list_add() when
CONFIG_PROVE_RCU_LIST=y:
WARNING: suspicious RCU usage
...
-----------------------------
kernel/locking/lockdep.c:3680 RCU-list traversed in non-reader section!!
other info that might help us debug this:
RCU used illegally from offline CPU!
rcu_scheduler_active = 1, debug_locks = 1
no locks held by swapper/1/0.
...
Call Trace:
[<ffffffff8012a434>] show_stack+0x64/0x158
[<ffffffff80a93d98>] dump_stack_lvl+0x90/0xc4
[<ffffffff801c9e9c>] __lock_acquire+0x1404/0x2940
[<ffffffff801cbf3c>] lock_acquire+0x14c/0x448
[<ffffffff80aa4260>] _raw_spin_lock_irqsave+0x50/0x88
[<ffffffff8021e0c8>] clockevents_register_device+0x60/0x1e8
[<ffffffff80130ff0>] r4k_clockevent_init+0x220/0x3a0
[<ffffffff801339d0>] start_secondary+0x50/0x3b8
raw_smp_processor_id() is required in order to avoid calling into lockdep
before RCU has declared the CPU to be watched for readers.
See also commit 29368e093921 ("x86/smpboot: Move rcu_cpu_starting() earlier"),
commit de5d9dae150c ("s390/smp: move rcu_cpu_starting() earlier") and commit
99f070b62322 ("powerpc/smp: Call rcu_cpu_starting() earlier").
Signed-off-by: Stefan Wiehler <[email protected]>
Reviewed-by: Huacai Chen <[email protected]>
Signed-off-by: Thomas Bogendoerfer <[email protected]>
---
arch/mips/kernel/smp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 8fbef537fb88..81f6c4f8fbc1 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -351,10 +351,11 @@ early_initcall(mips_smp_ipi_init);
*/
asmlinkage void start_secondary(void)
{
- unsigned int cpu;
+ unsigned int cpu = raw_smp_processor_id();
cpu_probe();
per_cpu_trap_init(false);
+ rcu_cpu_starting(cpu);
mips_clockevent_init();
mp_ops->init_secondary();
cpu_report();
@@ -366,7 +367,6 @@ asmlinkage void start_secondary(void)
*/
calibrate_delay();
- cpu = smp_processor_id();
cpu_data[cpu].udelay_val = loops_per_jiffy;
set_cpu_sibling_map(cpu);
--
2.42.0
On 1/18/24 2:48 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 20 Jan 2024 10:42:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.74-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Built and booted successfully on RISC-V RV64 (HiFive Unmatched).
Tested-by: Ron Economos <[email protected]>
On Thu, 18 Jan 2024 11:48:08 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.74 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Built and QEMU-booted for Rust:
Tested-by: Miguel Ojeda <[email protected]>
Including checking that `--lang_exclude=rust` is passed as expected with a new-enough `pahole`.
Cheers,
Miguel
On Fri, Jan 19, 2024 at 05:38:11PM +0100, Stefan Wiehler wrote:
> rcu_cpu_starting() must be called before clockevents_register_device() to avoid
> the following lockdep splat triggered by calling list_add() when
> CONFIG_PROVE_RCU_LIST=y:
>
> WARNING: suspicious RCU usage
> ...
> -----------------------------
> kernel/locking/lockdep.c:3680 RCU-list traversed in non-reader section!!
>
> other info that might help us debug this:
>
> RCU used illegally from offline CPU!
> rcu_scheduler_active = 1, debug_locks = 1
> no locks held by swapper/1/0.
> ...
> Call Trace:
> [<ffffffff8012a434>] show_stack+0x64/0x158
> [<ffffffff80a93d98>] dump_stack_lvl+0x90/0xc4
> [<ffffffff801c9e9c>] __lock_acquire+0x1404/0x2940
> [<ffffffff801cbf3c>] lock_acquire+0x14c/0x448
> [<ffffffff80aa4260>] _raw_spin_lock_irqsave+0x50/0x88
> [<ffffffff8021e0c8>] clockevents_register_device+0x60/0x1e8
> [<ffffffff80130ff0>] r4k_clockevent_init+0x220/0x3a0
> [<ffffffff801339d0>] start_secondary+0x50/0x3b8
>
> raw_smp_processor_id() is required in order to avoid calling into lockdep
> before RCU has declared the CPU to be watched for readers.
>
> See also commit 29368e093921 ("x86/smpboot: Move rcu_cpu_starting() earlier"),
> commit de5d9dae150c ("s390/smp: move rcu_cpu_starting() earlier") and commit
> 99f070b62322 ("powerpc/smp: Call rcu_cpu_starting() earlier").
>
> Signed-off-by: Stefan Wiehler <[email protected]>
> Reviewed-by: Huacai Chen <[email protected]>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> arch/mips/kernel/smp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
What is the git commit id of this change in Linus's tree? What
kernel(s) should this be applied to?
thanks,
greg k-h
On 1/19/2024 10:38 PM, Greg Kroah-Hartman wrote:
> On Fri, Jan 19, 2024 at 05:38:11PM +0100, Stefan Wiehler wrote:
>> rcu_cpu_starting() must be called before clockevents_register_device() to avoid
>> the following lockdep splat triggered by calling list_add() when
>> CONFIG_PROVE_RCU_LIST=y:
>>
>> WARNING: suspicious RCU usage
>> ...
>> -----------------------------
>> kernel/locking/lockdep.c:3680 RCU-list traversed in non-reader section!!
>>
>> other info that might help us debug this:
>>
>> RCU used illegally from offline CPU!
>> rcu_scheduler_active = 1, debug_locks = 1
>> no locks held by swapper/1/0.
>> ...
>> Call Trace:
>> [<ffffffff8012a434>] show_stack+0x64/0x158
>> [<ffffffff80a93d98>] dump_stack_lvl+0x90/0xc4
>> [<ffffffff801c9e9c>] __lock_acquire+0x1404/0x2940
>> [<ffffffff801cbf3c>] lock_acquire+0x14c/0x448
>> [<ffffffff80aa4260>] _raw_spin_lock_irqsave+0x50/0x88
>> [<ffffffff8021e0c8>] clockevents_register_device+0x60/0x1e8
>> [<ffffffff80130ff0>] r4k_clockevent_init+0x220/0x3a0
>> [<ffffffff801339d0>] start_secondary+0x50/0x3b8
>>
>> raw_smp_processor_id() is required in order to avoid calling into lockdep
>> before RCU has declared the CPU to be watched for readers.
>>
>> See also commit 29368e093921 ("x86/smpboot: Move rcu_cpu_starting() earlier"),
>> commit de5d9dae150c ("s390/smp: move rcu_cpu_starting() earlier") and commit
>> 99f070b62322 ("powerpc/smp: Call rcu_cpu_starting() earlier").
>>
>> Signed-off-by: Stefan Wiehler <[email protected]>
>> Reviewed-by: Huacai Chen <[email protected]>
>> Signed-off-by: Thomas Bogendoerfer <[email protected]>
>> ---
>> arch/mips/kernel/smp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> What is the git commit id of this change in Linus's tree? What
> kernel(s) should this be applied to?
The upstream commit is 55702ec9603ebeffb15e6f7b113623fe1d8872f4
("mips/smp: Call rcutree_report_cpu_starting() earlier") and this change
from Stefan should be applied to both the 6.1 stable and 6.6 stable
branches. Thanks!
--
Florian
On Sun, Jan 21, 2024 at 08:52:55AM -0800, Florian Fainelli wrote:
>
>
> On 1/19/2024 10:38 PM, Greg Kroah-Hartman wrote:
> > On Fri, Jan 19, 2024 at 05:38:11PM +0100, Stefan Wiehler wrote:
> > > rcu_cpu_starting() must be called before clockevents_register_device() to avoid
> > > the following lockdep splat triggered by calling list_add() when
> > > CONFIG_PROVE_RCU_LIST=y:
> > >
> > > WARNING: suspicious RCU usage
> > > ...
> > > -----------------------------
> > > kernel/locking/lockdep.c:3680 RCU-list traversed in non-reader section!!
> > >
> > > other info that might help us debug this:
> > >
> > > RCU used illegally from offline CPU!
> > > rcu_scheduler_active = 1, debug_locks = 1
> > > no locks held by swapper/1/0.
> > > ...
> > > Call Trace:
> > > [<ffffffff8012a434>] show_stack+0x64/0x158
> > > [<ffffffff80a93d98>] dump_stack_lvl+0x90/0xc4
> > > [<ffffffff801c9e9c>] __lock_acquire+0x1404/0x2940
> > > [<ffffffff801cbf3c>] lock_acquire+0x14c/0x448
> > > [<ffffffff80aa4260>] _raw_spin_lock_irqsave+0x50/0x88
> > > [<ffffffff8021e0c8>] clockevents_register_device+0x60/0x1e8
> > > [<ffffffff80130ff0>] r4k_clockevent_init+0x220/0x3a0
> > > [<ffffffff801339d0>] start_secondary+0x50/0x3b8
> > >
> > > raw_smp_processor_id() is required in order to avoid calling into lockdep
> > > before RCU has declared the CPU to be watched for readers.
> > >
> > > See also commit 29368e093921 ("x86/smpboot: Move rcu_cpu_starting() earlier"),
> > > commit de5d9dae150c ("s390/smp: move rcu_cpu_starting() earlier") and commit
> > > 99f070b62322 ("powerpc/smp: Call rcu_cpu_starting() earlier").
> > >
> > > Signed-off-by: Stefan Wiehler <[email protected]>
> > > Reviewed-by: Huacai Chen <[email protected]>
> > > Signed-off-by: Thomas Bogendoerfer <[email protected]>
> > > ---
> > > arch/mips/kernel/smp.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > What is the git commit id of this change in Linus's tree? What
> > kernel(s) should this be applied to?
>
> The upstream commit is 55702ec9603ebeffb15e6f7b113623fe1d8872f4 ("mips/smp:
> Call rcutree_report_cpu_starting() earlier") and this change from Stefan
> should be applied to both the 6.1 stable and 6.6 stable branches. Thanks!
Thanks, now queued up.
greg k-h