2024-02-09 10:21:18

by Hannes Reinecke

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

On 2/7/24 23:20, Lee Duncan wrote:
> From: Lee Duncan <[email protected]>
>
> This reverts commit 1a1975551943f681772720f639ff42fbaa746212
>
> This commit causes interrupts to be lost for FCoE devices,
> since it changed sping locks from "bh" to "irqsave".
>
> Instead, a work queue should be used, and will be addressed
> in a separate patch.
>
> Fixes: 1a1975551943f681772720f639ff42fbaa746212
Please use the correct fixes tag:

Fixes: 1a1975551943 ("scsi: fcoe: Fix potential deadlock on
&fip->ctlr_lock")

Otherwise looks good.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich