Change "reset" property to be optional instead of required, for SOCs that
don't support a reset controller.
Signed-off-by: Eliav Farber <[email protected]>
---
V3 -> v2:
- Change "reset" property to be optional instead of adding new
"reset-control-skip" property.
Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
index 6abde48b746e..2ec4b9da4b92 100644
--- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
+++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
@@ -49,7 +49,6 @@ required:
- reg
- reg-names
- clocks
- - resets
- "#thermal-sensor-cells"
additionalProperties: false
--
2.37.1
On Di, 2022-08-30 at 19:21 +0000, Eliav Farber wrote:
> Change "reset" property to be optional instead of required, for SOCs that
> don't support a reset controller.
>
> Signed-off-by: Eliav Farber <[email protected]>
> ---
> V3 -> v2:
> - Change "reset" property to be optional instead of adding new
> "reset-control-skip" property.
>
> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 6abde48b746e..2ec4b9da4b92 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -49,7 +49,6 @@ required:
> - reg
> - reg-names
> - clocks
> - - resets
Is this just for mr76006? Or does mr75203 work without reset as well?
If it is the former, maybe a new compatible should be added and resets
should be kept required
if:
properties:
compatible:
contains:
const: moortec,mr75203
regards
Philipp
On 8/31/2022 11:21 AM, Philipp Zabel wrote:
> On Di, 2022-08-30 at 19:21 +0000, Eliav Farber wrote:
>> Change "reset" property to be optional instead of required, for SOCs
>> that
>> don't support a reset controller.
>>
>> Signed-off-by: Eliav Farber <[email protected]>
>> ---
>> V3 -> v2:
>> - Change "reset" property to be optional instead of adding new
>> "reset-control-skip" property.
>>
>> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> index 6abde48b746e..2ec4b9da4b92 100644
>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> @@ -49,7 +49,6 @@ required:
>> - reg
>> - reg-names
>> - clocks
>> - - resets
>
> Is this just for mr76006? Or does mr75203 work without reset as well?
>
> If it is the former, maybe a new compatible should be added and resets
> should be kept required
mr75203 also works without a reset.
As I replied in PATCH v3 14/19, series 5/6 is relevant only for the
temperature sensor.
The “reset” property is relevant to the controller.
--
Regards, Eliav
On Mi, 2022-08-31 at 12:43 +0300, Farber, Eliav wrote:
> On 8/31/2022 11:21 AM, Philipp Zabel wrote:
> > On Di, 2022-08-30 at 19:21 +0000, Eliav Farber wrote:
> > > Change "reset" property to be optional instead of required, for SOCs
> > > that
> > > don't support a reset controller.
> > >
> > > Signed-off-by: Eliav Farber <[email protected]>
> > > ---
> > > V3 -> v2:
> > > - Change "reset" property to be optional instead of adding new
> > > "reset-control-skip" property.
> > >
> > > Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > index 6abde48b746e..2ec4b9da4b92 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > @@ -49,7 +49,6 @@ required:
> > > - reg
> > > - reg-names
> > > - clocks
> > > - - resets
> >
> > Is this just for mr76006? Or does mr75203 work without reset as well?
> >
> > If it is the former, maybe a new compatible should be added and resets
> > should be kept required
>
> mr75203 also works without a reset.
> As I replied in PATCH v3 14/19, series 5/6 is relevant only for the
> temperature sensor.
> The “reset” property is relevant to the controller.
In that case,
Reviewed-by: Philipp Zabel <[email protected]>
regards
Philipp
On Tue, Aug 30, 2022 at 07:21:57PM +0000, Eliav Farber wrote:
> Change "reset" property to be optional instead of required, for SOCs that
'resets'
And subject too.
> don't support a reset controller.
>
> Signed-off-by: Eliav Farber <[email protected]>
> ---
> V3 -> v2:
> - Change "reset" property to be optional instead of adding new
> "reset-control-skip" property.
>
> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 6abde48b746e..2ec4b9da4b92 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -49,7 +49,6 @@ required:
> - reg
> - reg-names
> - clocks
> - - resets
> - "#thermal-sensor-cells"
>
> additionalProperties: false
> --
> 2.37.1
>
>
On 9/2/2022 10:51 PM, Rob Herring wrote:
> On Tue, Aug 30, 2022 at 07:21:57PM +0000, Eliav Farber wrote:
>> Change "reset" property to be optional instead of required, for SOCs
>> that
>
> 'resets'
>
> And subject too.
Fixed in v4.