2019-03-29 12:27:53

by David Hildenbrand

Subject: [PATCH v1] mm: balloon: drop unused function stubs

These are leftovers from the pre-"general non-lru movable page" era.

Signed-off-by: David Hildenbrand <[email protected]>
---
include/linux/balloon_compaction.h | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
index f111c780ef1d..f31521dcb09a 100644
--- a/include/linux/balloon_compaction.h
+++ b/include/linux/balloon_compaction.h
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
list_del(&page->lru);
}

-static inline bool __is_movable_balloon_page(struct page *page)
-{
- return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
- return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
- return false;
-}
-
static inline bool balloon_page_isolate(struct page *page)
{
return false;
--
2.17.2

2019-03-29 13:57:01

by Mukesh Ojha

Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs

On 3/29/2019 5:56 PM, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <[email protected]>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)


Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;

2019-03-29 14:15:05

by Michael S. Tsirkin

Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs

On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <[email protected]>

Acked-by: Michael S. Tsirkin <[email protected]>

> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2

2019-04-01 06:07:30

by Pankaj Gupta

Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs

>
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <[email protected]>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h
> b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page
> *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2

Looks good to me.

Acked-by: Pankaj Gupta <[email protected]>

>
>

2019-04-02 18:31:23

by Rafael Aquini

Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs

On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <[email protected]>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2
>
Acked-by: Rafael Aquini <[email protected]>