Hi,
The max77843 shares some parts with max77693 but it lacked bindings. All
its compatibles were undocumented. Add basic bindings for max77843,
matching existing devicetree. These are not complete bindings, but
rather reverse-engineered to match current state.
I do not have access to device with MAX77843, so if anyone else
volunteers to be the bindings maintainer, please join.
Changes since v1
================
1. MFD: Use absolute path to schemas.
2. Regulator: mention all allowed properties,
additionalProperties=false, add min/max values for voltages and
current, don't use patternProperties when not needed.
3. extcon: Use absolute path to schemas.
Dependencies
============
1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
checker won't complain about DTS.
I will take it via Samsung SoC tree.
2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
should come together (2+3+4+5).
Best regards,
Krzysztof
Krzysztof Kozlowski (5):
arm64: dts: exynos: Align MAX77843 nodes with dtschema on TM2
dt-bindings: extcon: maxim,max77843: add MAX77843 bindings
regulator: dt-bindings: maxim,max77843: add MAX77843 bindings
dt-bindings: mfd: maxim,max77843: add MAX77843 bindings
MAINTAINERS: mfd: cover MAX77843 by Maxim PMIC/MUIC for Exynos boards
entry
.../bindings/extcon/maxim,max77843.yaml | 40 +++++
.../bindings/mfd/maxim,max77843.yaml | 144 ++++++++++++++++++
.../bindings/regulator/maxim,max77843.yaml | 65 ++++++++
MAINTAINERS | 2 +
.../dts/exynos/exynos5433-tm2-common.dtsi | 17 ++-
5 files changed, 265 insertions(+), 3 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
--
2.32.0
The newly introduced dtschema for MAX77843 MUIC require the children to
have proper naming and a port@0 property.
This should not have actual impact on MFD children driver binding,
because the max77843 MFD driver uses compatibles. The port@0 is
disabled to avoid any impact.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Please kindly test or even better - fix the DTS and extcon driver.
---
.../boot/dts/exynos/exynos5433-tm2-common.dtsi | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index cbcc01a66aab..03f7c9acaacb 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -858,10 +858,10 @@ pmic@66 {
interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
reg = <0x66>;
- muic: max77843-muic {
+ muic: extcon {
compatible = "maxim,max77843-muic";
- musb_con: musb-connector {
+ musb_con: connector {
compatible = "samsung,usb-connector-11pin",
"usb-b-connector";
label = "micro-USB";
@@ -871,6 +871,17 @@ ports {
#address-cells = <1>;
#size-cells = <0>;
+ port@0 {
+ /*
+ * TODO: The DTS this is based on does not have
+ * port@0 which is a required property. The ports
+ * look incomplete and need fixing.
+ * Add a disabled port just to satisfy dtschema.
+ */
+ reg = <0>;
+ status = "disabled";
+ };
+
port@3 {
reg = <3>;
musb_con_to_mhl: endpoint {
@@ -910,7 +921,7 @@ charger_reg: CHARGER {
};
};
- haptic: max77843-haptic {
+ haptic: motor-driver {
compatible = "maxim,max77843-haptic";
haptic-supply = <&ldo38_reg>;
pwms = <&pwm 0 33670 0>;
--
2.32.0
Document the bindings for MAX77843 MUIC/extcon driver, based on
Exynos5433 TM2 devicetree. These are neither accurate nor finished
bindings but at least allow parsing existing DTS files.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../bindings/extcon/maxim,max77843.yaml | 40 +++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
diff --git a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
new file mode 100644
index 000000000000..f9ffe3d6f957
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/extcon/maxim,max77843.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX77843 MicroUSB and Companion Power Management IC Extcon
+
+maintainers:
+ - Chanwoo Choi <[email protected]>
+ - Krzysztof Kozlowski <[email protected]>
+
+description: |
+ This is a part of device tree bindings for Maxim MAX77843 MicroUSB
+ Integrated Circuit (MUIC).
+
+ See also Documentation/devicetree/bindings/mfd/maxim,max77843.yaml for
+ additional information and example.
+
+properties:
+ compatible:
+ const: maxim,max77843-muic
+
+ connector:
+ $ref: /schemas/connector/usb-connector.yaml#
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ Any connector to the data bus of this controller should be modelled using
+ the OF graph bindings specified
+ properties:
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+
+required:
+ - compatible
+ - connector
+
+additionalProperties: false
--
2.32.0
Document the bindings for MAX77843 MFD driver, based on Exynos5433 TM2
devicetree. These are neither accurate nor finished bindings but at
least allow parsing existing DTS files.
The example DTS was copied from existing DTS
(exynos5433-tm2-common.dtsi), so keep the license as GPL-2.0-only.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../bindings/mfd/maxim,max77843.yaml | 144 ++++++++++++++++++
1 file changed, 144 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77843.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
new file mode 100644
index 000000000000..61a0f9dcb983
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
@@ -0,0 +1,144 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/maxim,max77843.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX77843 MicroUSB and Companion Power Management IC
+
+maintainers:
+ - Krzysztof Kozlowski <[email protected]>
+
+description: |
+ This is a part of device tree bindings for Maxim MAX77843 MicroUSB
+ Integrated Circuit (MUIC).
+
+ The Maxim MAX77843 is a MicroUSB and Companion Power Management IC which
+ includes voltage current regulators, charger, fuel-gauge, haptic motor driver
+ and MicroUSB management IC.
+
+properties:
+ compatible:
+ const: maxim,max77843
+
+ interrupts:
+ maxItems: 1
+
+ reg:
+ maxItems: 1
+
+ extcon:
+ $ref: /schemas/extcon/maxim,max77843.yaml
+
+ motor-driver:
+ type: object
+ properties:
+ compatible:
+ const: maxim,max77843-haptic
+
+ haptic-supply:
+ description: Power supply to the haptic motor
+
+ pwms:
+ maxItems: 1
+
+ required:
+ - compatible
+ - haptic-supply
+ - pwms
+
+ regulators:
+ $ref: /schemas/regulator/maxim,max77843.yaml
+
+required:
+ - compatible
+ - interrupts
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@66 {
+ compatible = "maxim,max77843";
+ interrupt-parent = <&gpa1>;
+ interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
+ reg = <0x66>;
+
+ extcon {
+ compatible = "maxim,max77843-muic";
+
+ connector {
+ compatible = "samsung,usb-connector-11pin",
+ "usb-b-connector";
+ label = "micro-USB";
+ type = "micro";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ /*
+ * TODO: The DTS this is based on does not have
+ * port@0 which is a required property. The ports
+ * look incomplete and need fixing.
+ * Add a disabled port just to satisfy dtschema.
+ */
+ reg = <0>;
+ status = "disabled";
+ };
+
+ port@3 {
+ reg = <3>;
+ endpoint {
+ remote-endpoint = <&mhl_to_musb_con>;
+ };
+ };
+ };
+ };
+
+ ports {
+ port {
+ endpoint {
+ remote-endpoint = <&usb_to_muic>;
+ };
+ };
+ };
+ };
+
+ regulators {
+ compatible = "maxim,max77843-regulator";
+
+ SAFEOUT1 {
+ regulator-name = "SAFEOUT1";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <4950000>;
+ };
+
+ SAFEOUT2 {
+ regulator-name = "SAFEOUT2";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <4950000>;
+ };
+
+ CHARGER {
+ regulator-name = "CHARGER";
+ regulator-min-microamp = <100000>;
+ regulator-max-microamp = <3150000>;
+ };
+ };
+
+ motor-driver {
+ compatible = "maxim,max77843-haptic";
+ haptic-supply = <&ldo38_reg>;
+ pwms = <&pwm 0 33670 0>;
+ };
+ };
+ };
--
2.32.0
Document the bindings for MAX77843 regulator driver. The bindings are
almost identical to MAX77693 bindings, except the actual names of
regulators.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/regulator/maxim,max77843.yaml | 65 +++++++++++++++++++
1 file changed, 65 insertions(+)
create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
diff --git a/Documentation/devicetree/bindings/regulator/maxim,max77843.yaml b/Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
new file mode 100644
index 000000000000..a963025e96c1
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/maxim,max77843.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX77843 MicroUSB and Companion Power Management IC regulators
+
+maintainers:
+ - Krzysztof Kozlowski <[email protected]>
+
+description: |
+ This is a part of device tree bindings for Maxim MAX77843 MicroUSB Integrated
+ Circuit (MUIC).
+
+ See also Documentation/devicetree/bindings/mfd/maxim,max77843.yaml for
+ additional information and example.
+
+properties:
+ compatible:
+ const: maxim,max77843-regulator
+
+ CHARGER:
+ type: object
+ $ref: regulator.yaml#
+ additionalProperties: false
+ description: |
+ Current regulator.
+
+ properties:
+ regulator-name: true
+ regulator-always-on: true
+ regulator-boot-on: true
+ regulator-min-microamp:
+ minimum: 100000
+ regulator-max-microamp:
+ maximum: 3150000
+
+ required:
+ - regulator-name
+
+patternProperties:
+ "^SAFEOUT[12]$":
+ type: object
+ $ref: regulator.yaml#
+ additionalProperties: false
+ description: |
+ Safeout LDO regulator.
+
+ properties:
+ regulator-name: true
+ regulator-always-on: true
+ regulator-boot-on: true
+ regulator-min-microvolt:
+ minimum: 3300000
+ regulator-max-microvolt:
+ maximum: 4950000
+
+ required:
+ - regulator-name
+
+required:
+ - compatible
+
+additionalProperties: false
--
2.32.0
The MAX77843 is used in Exynos5433-based TM2 boards and shares some
parts of code with MAX77693 (regulator and haptic motor drivers).
Include all MAX77843 drivers in the entry for Maxim PMIC/MUIC drivers
for Exynos boards, so they will receive some dedicated review coverage.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e5f2758531bc..d1f8f312f322 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11693,8 +11693,10 @@ L: [email protected]
S: Supported
F: Documentation/devicetree/bindings/*/maxim,max77686.yaml
F: Documentation/devicetree/bindings/*/maxim,max77693.yaml
+F: Documentation/devicetree/bindings/*/maxim,max77843.yaml
F: Documentation/devicetree/bindings/clock/maxim,max77686.txt
F: Documentation/devicetree/bindings/mfd/max14577.txt
+F: drivers/*/*max77843.c
F: drivers/*/max14577*.c
F: drivers/*/max77686*.c
F: drivers/*/max77693*.c
--
2.32.0
On Tue, 11 Jan 2022 18:48:03 +0100, Krzysztof Kozlowski wrote:
> Document the bindings for MAX77843 regulator driver. The bindings are
> almost identical to MAX77693 bindings, except the actual names of
> regulators.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/regulator/maxim,max77843.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
>
Reviewed-by: Rob Herring <[email protected]>
On Tue, 11 Jan 2022 18:48:01 +0100, Krzysztof Kozlowski wrote:
> The newly introduced dtschema for MAX77843 MUIC require the children to
> have proper naming and a port@0 property.
>
> This should not have actual impact on MFD children driver binding,
> because the max77843 MFD driver uses compatibles. The port@0 is
> disabled to avoid any impact.
>
> [...]
Applied, thanks!
[1/5] arm64: dts: exynos: Align MAX77843 nodes with dtschema on TM2
commit: 7638d3c945beb6c781acf5dd0a78e04c76f1c32f
Best regards,
--
Krzysztof Kozlowski <[email protected]>
On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
> Hi,
>
> The max77843 shares some parts with max77693 but it lacked bindings. All
> its compatibles were undocumented. Add basic bindings for max77843,
> matching existing devicetree. These are not complete bindings, but
> rather reverse-engineered to match current state.
>
> I do not have access to device with MAX77843, so if anyone else
> volunteers to be the bindings maintainer, please join.
>
> Changes since v1
> ================
> 1. MFD: Use absolute path to schemas.
> 2. Regulator: mention all allowed properties,
> additionalProperties=false, add min/max values for voltages and
> current, don't use patternProperties when not needed.
> 3. extcon: Use absolute path to schemas.
>
> Dependencies
> ============
> 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
> checker won't complain about DTS.
> I will take it via Samsung SoC tree.
>
> 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
> should come together (2+3+4+5).
>
Dear Lee,
This patchset was reviewed and there are no outstanding issues. Could
you pick up patches 2-5 (skipping DTS patch) via MFD tree?
Best regards,
Krzysztof
On Sun, 06 Feb 2022, Krzysztof Kozlowski wrote:
> On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > The max77843 shares some parts with max77693 but it lacked bindings. All
> > its compatibles were undocumented. Add basic bindings for max77843,
> > matching existing devicetree. These are not complete bindings, but
> > rather reverse-engineered to match current state.
> >
> > I do not have access to device with MAX77843, so if anyone else
> > volunteers to be the bindings maintainer, please join.
> >
> > Changes since v1
> > ================
> > 1. MFD: Use absolute path to schemas.
> > 2. Regulator: mention all allowed properties,
> > additionalProperties=false, add min/max values for voltages and
> > current, don't use patternProperties when not needed.
> > 3. extcon: Use absolute path to schemas.
> >
> > Dependencies
> > ============
> > 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
> > checker won't complain about DTS.
> > I will take it via Samsung SoC tree.
> >
> > 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
> > should come together (2+3+4+5).
> >
> Dear Lee,
>
> This patchset was reviewed and there are no outstanding issues. Could
> you pick up patches 2-5 (skipping DTS patch) via MFD tree?
Are the subsystem maintainers not going to review/ack?
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Mon, Feb 07, 2022 at 10:47:00AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2022 10:33, Lee Jones wrote:
> > Are the subsystem maintainers not going to review/ack?
> Would be nice to have them, but maybe since these are dt-bindings maybe
> they were skipped? Or maybe it was the end-of-year holidays?
You've been sending out a large number of very similar serieses, each of
which is going through multiple revisions - it's hard to keep track of
what's been reviewed, what's in a state where it's useful to review
> I can resend hoping it will trigger more acks. Do you wish me to resend?
It's probably going to add more noise, on the other hand some things
might've been dropped on the floor due to the similarity and whatnot.
On Mon, 07 Feb 2022, Krzysztof Kozlowski wrote:
> On 07/02/2022 10:33, Lee Jones wrote:
> > On Sun, 06 Feb 2022, Krzysztof Kozlowski wrote:
> >
> >> On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
> >>> Hi,
> >>>
> >>> The max77843 shares some parts with max77693 but it lacked bindings. All
> >>> its compatibles were undocumented. Add basic bindings for max77843,
> >>> matching existing devicetree. These are not complete bindings, but
> >>> rather reverse-engineered to match current state.
> >>>
> >>> I do not have access to device with MAX77843, so if anyone else
> >>> volunteers to be the bindings maintainer, please join.
> >>>
> >>> Changes since v1
> >>> ================
> >>> 1. MFD: Use absolute path to schemas.
> >>> 2. Regulator: mention all allowed properties,
> >>> additionalProperties=false, add min/max values for voltages and
> >>> current, don't use patternProperties when not needed.
> >>> 3. extcon: Use absolute path to schemas.
> >>>
> >>> Dependencies
> >>> ============
> >>> 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
> >>> checker won't complain about DTS.
> >>> I will take it via Samsung SoC tree.
> >>>
> >>> 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
> >>> should come together (2+3+4+5).
> >>>
> >> Dear Lee,
> >>
> >> This patchset was reviewed and there are no outstanding issues. Could
> >> you pick up patches 2-5 (skipping DTS patch) via MFD tree?
> >
> > Are the subsystem maintainers not going to review/ack?
> >
>
> Would be nice to have them, but maybe since these are dt-bindings maybe
> they were skipped?
Agreed, not required, but nice to have to avoid possible conflict.
> Or maybe it was the end-of-year holidays?
> I can resend hoping it will trigger more acks. Do you wish me to resend?
That shouldn't be necessary.
I'll give the guys a little while to protest/ack, then I'll merge.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On 07/02/2022 10:33, Lee Jones wrote:
> On Sun, 06 Feb 2022, Krzysztof Kozlowski wrote:
>
>> On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>> The max77843 shares some parts with max77693 but it lacked bindings. All
>>> its compatibles were undocumented. Add basic bindings for max77843,
>>> matching existing devicetree. These are not complete bindings, but
>>> rather reverse-engineered to match current state.
>>>
>>> I do not have access to device with MAX77843, so if anyone else
>>> volunteers to be the bindings maintainer, please join.
>>>
>>> Changes since v1
>>> ================
>>> 1. MFD: Use absolute path to schemas.
>>> 2. Regulator: mention all allowed properties,
>>> additionalProperties=false, add min/max values for voltages and
>>> current, don't use patternProperties when not needed.
>>> 3. extcon: Use absolute path to schemas.
>>>
>>> Dependencies
>>> ============
>>> 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
>>> checker won't complain about DTS.
>>> I will take it via Samsung SoC tree.
>>>
>>> 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
>>> should come together (2+3+4+5).
>>>
>> Dear Lee,
>>
>> This patchset was reviewed and there are no outstanding issues. Could
>> you pick up patches 2-5 (skipping DTS patch) via MFD tree?
>
> Are the subsystem maintainers not going to review/ack?
>
Would be nice to have them, but maybe since these are dt-bindings maybe
they were skipped? Or maybe it was the end-of-year holidays?
I can resend hoping it will trigger more acks. Do you wish me to resend?
Best regards,
Krzysztof
On Tue, Jan 11, 2022 at 06:48:03PM +0100, Krzysztof Kozlowski wrote:
> Document the bindings for MAX77843 regulator driver. The bindings are
> almost identical to MAX77693 bindings, except the actual names of
> regulators.
Reviewed-by: Mark Brown <[email protected]>
On Tue, 11 Jan 2022, Krzysztof Kozlowski wrote:
> Document the bindings for MAX77843 MFD driver, based on Exynos5433 TM2
> devicetree. These are neither accurate nor finished bindings but at
> least allow parsing existing DTS files.
>
> The example DTS was copied from existing DTS
> (exynos5433-tm2-common.dtsi), so keep the license as GPL-2.0-only.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../bindings/mfd/maxim,max77843.yaml | 144 ++++++++++++++++++
> 1 file changed, 144 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, 11 Jan 2022, Krzysztof Kozlowski wrote:
> Document the bindings for MAX77843 MUIC/extcon driver, based on
> Exynos5433 TM2 devicetree. These are neither accurate nor finished
> bindings but at least allow parsing existing DTS files.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../bindings/extcon/maxim,max77843.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, 11 Jan 2022, Krzysztof Kozlowski wrote:
> Document the bindings for MAX77843 regulator driver. The bindings are
> almost identical to MAX77693 bindings, except the actual names of
> regulators.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/regulator/maxim,max77843.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, 11 Jan 2022, Krzysztof Kozlowski wrote:
> The MAX77843 is used in Exynos5433-based TM2 boards and shares some
> parts of code with MAX77693 (regulator and haptic motor drivers).
> Include all MAX77843 drivers in the entry for Maxim PMIC/MUIC drivers
> for Exynos boards, so they will receive some dedicated review coverage.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Enjoy!
The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07:
Linux 5.17-rc1 (2022-01-23 10:12:53 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-spi-dt-v5.18
for you to fetch changes up to 172e611b54e813c49a35b6b74bccaa99f27bf566:
dt-bindings: mfd: maxim,max77802: Convert to dtschema (2022-03-07 12:55:59 +0000)
----------------------------------------------------------------
Immutable branch between MFD, SPI and DT due for the v5.18 merge window
----------------------------------------------------------------
Krzysztof Kozlowski (13):
dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings
regulator: dt-bindings: maxim,max77843: Add MAX77843 bindings
dt-bindings: mfd: maxim,max77843: Add MAX77843 bindings
MAINTAINERS: mfd: Cover MAX77843 by Maxim PMIC/MUIC for Exynos boards entry
spi: dt-bindings: samsung: Convert to dtschema
mfd: dt-bindings: google,cros-ec: Reference Samsung SPI bindings
mfd: dt-bindings: google,cros-ec: Fix indentation in example
spi: s3c64xx: Allow controller-data to be optional
dt-bindings: power: supply: maxim,max14577: Convert to dtschema
regulator: dt-bindings: maxim,max14577: Convert to dtschema
dt-bindings: mfd: maxim,max14577: Convert to dtschema
regulator: dt-bindings: maxim,max77802: Convert to dtschema
dt-bindings: mfd: maxim,max77802: Convert to dtschema
.../devicetree/bindings/extcon/maxim,max77843.yaml | 40 +++++
.../devicetree/bindings/mfd/google,cros-ec.yaml | 31 ++--
Documentation/devicetree/bindings/mfd/max14577.txt | 147 ----------------
Documentation/devicetree/bindings/mfd/max77802.txt | 25 ---
.../devicetree/bindings/mfd/maxim,max14577.yaml | 195 +++++++++++++++++++++
.../devicetree/bindings/mfd/maxim,max77802.yaml | 194 ++++++++++++++++++++
.../devicetree/bindings/mfd/maxim,max77843.yaml | 144 +++++++++++++++
.../bindings/power/supply/maxim,max14577.yaml | 84 +++++++++
.../devicetree/bindings/regulator/max77802.txt | 111 ------------
.../bindings/regulator/maxim,max14577.yaml | 78 +++++++++
.../bindings/regulator/maxim,max77802.yaml | 85 +++++++++
.../bindings/regulator/maxim,max77843.yaml | 65 +++++++
.../bindings/soc/samsung/exynos-usi.yaml | 2 +-
.../bindings/spi/samsung,spi-peripheral-props.yaml | 33 ++++
.../devicetree/bindings/spi/samsung,spi.yaml | 187 ++++++++++++++++++++
.../bindings/spi/spi-peripheral-props.yaml | 1 +
.../devicetree/bindings/spi/spi-samsung.txt | 122 -------------
MAINTAINERS | 9 +-
drivers/spi/spi-s3c64xx.c | 14 +-
19 files changed, 1136 insertions(+), 431 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
delete mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/max77802.txt
create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml
create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77802.yaml
create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml
create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi.yaml
delete mode 100644 Documentation/devicetree/bindings/spi/spi-samsung.txt
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, Jan 11, 2022 at 11:48 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Document the bindings for MAX77843 MUIC/extcon driver, based on
> Exynos5433 TM2 devicetree. These are neither accurate nor finished
> bindings but at least allow parsing existing DTS files.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../bindings/extcon/maxim,max77843.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
>
> diff --git a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> new file mode 100644
> index 000000000000..f9ffe3d6f957
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/extcon/maxim,max77843.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX77843 MicroUSB and Companion Power Management IC Extcon
> +
> +maintainers:
> + - Chanwoo Choi <[email protected]>
> + - Krzysztof Kozlowski <[email protected]>
> +
> +description: |
> + This is a part of device tree bindings for Maxim MAX77843 MicroUSB
> + Integrated Circuit (MUIC).
> +
> + See also Documentation/devicetree/bindings/mfd/maxim,max77843.yaml for
> + additional information and example.
> +
> +properties:
> + compatible:
> + const: maxim,max77843-muic
> +
> + connector:
> + $ref: /schemas/connector/usb-connector.yaml#
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/port
Now failing in -next:
Documentation/devicetree/bindings/mfd/maxim,max77843.example.dt.yaml:
pmic@66: extcon:ports: Unevaluated properties are not allowed ('port'
was unexpected)
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
s/port/ports/
> + description:
> + Any connector to the data bus of this controller should be modelled using
> + the OF graph bindings specified
> + properties:
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> +
> +required:
> + - compatible
> + - connector
> +
> +additionalProperties: false
> --
> 2.32.0
>
On 09/03/2022 22:03, Rob Herring wrote:
> On Tue, Jan 11, 2022 at 11:48 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> Document the bindings for MAX77843 MUIC/extcon driver, based on
>> Exynos5433 TM2 devicetree. These are neither accurate nor finished
>> bindings but at least allow parsing existing DTS files.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> Reviewed-by: Rob Herring <[email protected]>
>> ---
>> .../bindings/extcon/maxim,max77843.yaml | 40 +++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
>> new file mode 100644
>> index 000000000000..f9ffe3d6f957
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
>> @@ -0,0 +1,40 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/extcon/maxim,max77843.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Maxim MAX77843 MicroUSB and Companion Power Management IC Extcon
>> +
>> +maintainers:
>> + - Chanwoo Choi <[email protected]>
>> + - Krzysztof Kozlowski <[email protected]>
>> +
>> +description: |
>> + This is a part of device tree bindings for Maxim MAX77843 MicroUSB
>> + Integrated Circuit (MUIC).
>> +
>> + See also Documentation/devicetree/bindings/mfd/maxim,max77843.yaml for
>> + additional information and example.
>> +
>> +properties:
>> + compatible:
>> + const: maxim,max77843-muic
>> +
>> + connector:
>> + $ref: /schemas/connector/usb-connector.yaml#
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/port
>
> Now failing in -next:
>
> Documentation/devicetree/bindings/mfd/maxim,max77843.example.dt.yaml:
> pmic@66: extcon:ports: Unevaluated properties are not allowed ('port'
> was unexpected)
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
>
> s/port/ports/
I'll fix it up. I wonder why I did not see warning before...
Best regards,
Krzysztof