2021-03-29 16:15:16

by Christian Hewitt

Subject: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+

From: Hyeonki Hong <[email protected]>

Add the meson saradc node to the ODROID N2/N2+ common dtsi.

Signed-off-by: Hyeonki Hong <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 2f8d574c30c0..139c12cf9f66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -508,6 +508,10 @@
status = "okay";
};

+&saradc {
+ status = "okay";
+};
+
/* SD card */
&sd_emmc_b {
status = "okay";
--
2.17.1

2021-03-30 15:25:32

by Neil Armstrong

Subject: Re: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+

Hi,

On 29/03/2021 18:12, Christian Hewitt wrote:
> From: Hyeonki Hong <[email protected]>
>
> Add the meson saradc node to the ODROID N2/N2+ common dtsi.

Not sure why this is needed, does it fix something ?

Neil

>
> Signed-off-by: Hyeonki Hong <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 2f8d574c30c0..139c12cf9f66 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -508,6 +508,10 @@
> status = "okay";
> };
>
> +&saradc {
> + status = "okay";
> +};
> +
> /* SD card */
> &sd_emmc_b {
> status = "okay";
>

2021-04-06 09:59:21

by Martin Blumenstingl

Subject: Re: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+

On Tue, Mar 30, 2021 at 1:18 AM Christian Hewitt
<[email protected]> wrote:
>
> From: Hyeonki Hong <[email protected]>
>
> Add the meson saradc node to the ODROID N2/N2+ common dtsi.
in general I am fine with this as some SAR ADC channels seem to be on
the pin headers...

[...]
> +&saradc {
> + status = "okay";
> +};
...but a vref-supply should be provided to get meaningful numbers