Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
Linus Torvalds (1):
Linux 2.6.32-rc3
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
omap: Lock DPLL5 at boot
Sergio Aguirre (1):
omapfb: Condition mutex acquisition
Tommi Rantala (2):
omapfb: Blizzard: fix pointer to be const
omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
omap: Fix incorrect 730 vs 850 detection
Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
OMAP3: PM: USBHOST: clear wakeup events on both hosts
ye janboe (1):
omap: SRAM: flush the right address after memcpy in omap_sram_push
arch/arm/mach-omap2/clock34xx.c | 35 +++++
arch/arm/mach-omap2/pm-debug.c | 4 +-
arch/arm/mach-omap2/pm34xx.c | 187 ++++++++++++++-----------
arch/arm/mach-omap2/powerdomain.c | 39 ++++--
arch/arm/plat-omap/include/mach/cpu.h | 37 ++---
arch/arm/plat-omap/include/mach/powerdomain.h | 2 +
arch/arm/plat-omap/iovmm.c | 9 +-
arch/arm/plat-omap/sram.c | 3 +-
drivers/video/omap/blizzard.c | 10 +-
drivers/video/omap/omapfb_main.c | 22 ++-
10 files changed, 212 insertions(+), 136 deletions(-)
On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
> Linus,
>
> Please pull omap fixes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>
> Regards,
>
> Tony
>
>
> The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
> Linus Torvalds (1):
> Linux 2.6.32-rc3
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>
> Artem Bityutskiy (1):
> OMAP3: PM: introduce a new powerdomain walk helper
>
> Daniel Walker (1):
> omap: iovmm: Add missing mutex_unlock
>
> Hiroshi DOYU (1):
> omap: iovmm: Fix incorrect spelling
>
> Jon Hunter (1):
> OMAP3: PM: Prevent hang in prcm_interrupt_handler
>
> Kevin Hilman (1):
> OMAP3: PM: Enable GPIO module-level wakeups
>
> Paul Walmsley (2):
> OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
> OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
>
> Rajendra Nayak (1):
> omap: Lock DPLL5 at boot
>
> Sergio Aguirre (1):
> omapfb: Condition mutex acquisition
>
> Tommi Rantala (2):
> omapfb: Blizzard: fix pointer to be const
> omapfb: Blizzard: constify register address tables
>
> Tony Lindgren (2):
> omap: Fix incorrect 730 vs 850 detection
> Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
>
> Vikram Pandita (1):
> OMAP3: PM: USBHOST: clear wakeup events on both hosts
>
> ye janboe (1):
> omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need
to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.
You can add my 'tested-by' line if you want.
Cheers.
--
Felipe Contreras
* Felipe Contreras <[email protected]> [091008 14:29]:
> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
> > Linus,
> >
> > Please pull omap fixes from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
> >
> > Regards,
> >
> > Tony
> >
> >
> > The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
> > ?Linus Torvalds (1):
> > ? ? ? ?Linux 2.6.32-rc3
> >
> > are available in the git repository at:
> >
> > ?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
> >
> > Artem Bityutskiy (1):
> > ? ? ?OMAP3: PM: introduce a new powerdomain walk helper
> >
> > Daniel Walker (1):
> > ? ? ?omap: iovmm: Add missing mutex_unlock
> >
> > Hiroshi DOYU (1):
> > ? ? ?omap: iovmm: Fix incorrect spelling
> >
> > Jon Hunter (1):
> > ? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
> >
> > Kevin Hilman (1):
> > ? ? ?OMAP3: PM: Enable GPIO module-level wakeups
> >
> > Paul Walmsley (2):
> > ? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
> > ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
> >
> > Rajendra Nayak (1):
> > ? ? ?omap: Lock DPLL5 at boot
> >
> > Sergio Aguirre (1):
> > ? ? ?omapfb: Condition mutex acquisition
> >
> > Tommi Rantala (2):
> > ? ? ?omapfb: Blizzard: fix pointer to be const
> > ? ? ?omapfb: Blizzard: constify register address tables
> >
> > Tony Lindgren (2):
> > ? ? ?omap: Fix incorrect 730 vs 850 detection
> > ? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
> >
> > Vikram Pandita (1):
> > ? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
> >
> > ye janboe (1):
> > ? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
>
> The beagleboard is still not booting for me with this branch, I need
> to add these two patches:
>
> * http://patchwork.kernel.org/patch/50721/
>
This should go to the mainline kernel via Samuel as it's
drivers/mfd related.
> This one is needed because the defconfig has:
> CONFIG_TWL4030_USB=y
>
> * http://patchwork.kernel.org/patch/50970/
>
> This is needed because most people boot from an MMC.
And this should go in via the mmc list.
So little more patience is still needed :)
Cheers,
Tony
>
> You can add my 'tested-by' line if you want.
>
> Cheers.
>
> --
> Felipe Contreras
On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <[email protected]> wrote:
> * Felipe Contreras <[email protected]> [091008 14:29]:
>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
>> > Linus,
>> >
>> > Please pull omap fixes from:
>> >
>> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>> >
>> > Regards,
>> >
>> > Tony
>> >
>> >
>> > The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
>> > Linus Torvalds (1):
>> > Linux 2.6.32-rc3
>> >
>> > are available in the git repository at:
>> >
>> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>> >
>> > Artem Bityutskiy (1):
>> > OMAP3: PM: introduce a new powerdomain walk helper
>> >
>> > Daniel Walker (1):
>> > omap: iovmm: Add missing mutex_unlock
>> >
>> > Hiroshi DOYU (1):
>> > omap: iovmm: Fix incorrect spelling
>> >
>> > Jon Hunter (1):
>> > OMAP3: PM: Prevent hang in prcm_interrupt_handler
>> >
>> > Kevin Hilman (1):
>> > OMAP3: PM: Enable GPIO module-level wakeups
>> >
>> > Paul Walmsley (2):
>> > OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
>> > OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
>> >
>> > Rajendra Nayak (1):
>> > omap: Lock DPLL5 at boot
>> >
>> > Sergio Aguirre (1):
>> > omapfb: Condition mutex acquisition
>> >
>> > Tommi Rantala (2):
>> > omapfb: Blizzard: fix pointer to be const
>> > omapfb: Blizzard: constify register address tables
>> >
>> > Tony Lindgren (2):
>> > omap: Fix incorrect 730 vs 850 detection
>> > Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
>> >
>> > Vikram Pandita (1):
>> > OMAP3: PM: USBHOST: clear wakeup events on both hosts
>> >
>> > ye janboe (1):
>> > omap: SRAM: flush the right address after memcpy in omap_sram_push
>>
>> The beagleboard is still not booting for me with this branch, I need
>> to add these two patches:
>>
>> * http://patchwork.kernel.org/patch/50721/
>>
>
> This should go to the mainline kernel via Samuel as it's
> drivers/mfd related.
>
>> This one is needed because the defconfig has:
>> CONFIG_TWL4030_USB=y
>>
>> * http://patchwork.kernel.org/patch/50970/
>>
>> This is needed because most people boot from an MMC.
>
> And this should go in via the mmc list.
Should it?
Here you can see Uwe Kleine-König sending the original patch without
even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2
I don't see what we are waiting for, the code is clearly broken, even
the compiler warns that nobody is using omap_hsmmc_probe().
--
Felipe Contreras
On Fri, Oct 9, 2009 at 1:13 AM, Felipe Contreras
<[email protected]> wrote:
> On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <[email protected]> wrote:
>> * Felipe Contreras <[email protected]> [091008 14:29]:
>>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
>>> > Linus,
>>> >
>>> > Please pull omap fixes from:
>>> >
>>> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>>> >
>>> > Regards,
>>> >
>>> > Tony
>>> >
>>> >
>>> > The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
>>> > Linus Torvalds (1):
>>> > Linux 2.6.32-rc3
>>> >
>>> > are available in the git repository at:
>>> >
>>> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>>> >
>>> > Artem Bityutskiy (1):
>>> > OMAP3: PM: introduce a new powerdomain walk helper
>>> >
>>> > Daniel Walker (1):
>>> > omap: iovmm: Add missing mutex_unlock
>>> >
>>> > Hiroshi DOYU (1):
>>> > omap: iovmm: Fix incorrect spelling
>>> >
>>> > Jon Hunter (1):
>>> > OMAP3: PM: Prevent hang in prcm_interrupt_handler
>>> >
>>> > Kevin Hilman (1):
>>> > OMAP3: PM: Enable GPIO module-level wakeups
>>> >
>>> > Paul Walmsley (2):
>>> > OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
>>> > OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
>>> >
>>> > Rajendra Nayak (1):
>>> > omap: Lock DPLL5 at boot
>>> >
>>> > Sergio Aguirre (1):
>>> > omapfb: Condition mutex acquisition
>>> >
>>> > Tommi Rantala (2):
>>> > omapfb: Blizzard: fix pointer to be const
>>> > omapfb: Blizzard: constify register address tables
>>> >
>>> > Tony Lindgren (2):
>>> > omap: Fix incorrect 730 vs 850 detection
>>> > Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
>>> >
>>> > Vikram Pandita (1):
>>> > OMAP3: PM: USBHOST: clear wakeup events on both hosts
>>> >
>>> > ye janboe (1):
>>> > omap: SRAM: flush the right address after memcpy in omap_sram_push
>>>
>>> The beagleboard is still not booting for me with this branch, I need
>>> to add these two patches:
>>>
>>> * http://patchwork.kernel.org/patch/50721/
>>>
>>
>> This should go to the mainline kernel via Samuel as it's
>> drivers/mfd related.
>>
>>> This one is needed because the defconfig has:
>>> CONFIG_TWL4030_USB=y
>>>
>>> * http://patchwork.kernel.org/patch/50970/
>>>
>>> This is needed because most people boot from an MMC.
>>
>> And this should go in via the mmc list.
>
> Should it?
>
> Here you can see Uwe Kleine-König sending the original patch without
> even CC'ing the mmc list:
> http://marc.info/?l=linux-kernel&m=124820861213849&w=2
>
> And it was unintentionally broken by this one:
> http://marc.info/?l=linux-mmc&m=125249763422227&w=2
Er, actually that one was ok, the problem was introduced only in the
final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2
> I don't see what we are waiting for, the code is clearly broken, even
> the compiler warns that nobody is using omap_hsmmc_probe().
--
Felipe Contreras
* Felipe Contreras <[email protected]> [091008 15:20]:
> On Fri, Oct 9, 2009 at 1:13 AM, Felipe Contreras
> <[email protected]> wrote:
> > On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <[email protected]> wrote:
> >> * Felipe Contreras <[email protected]> [091008 14:29]:
> >>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
> >>>
<snip snip>
> >>> The beagleboard is still not booting for me with this branch, I need
> >>> to add these two patches:
> >>>
> >>> * http://patchwork.kernel.org/patch/50721/
> >>>
> >>
> >> This should go to the mainline kernel via Samuel as it's
> >> drivers/mfd related.
> >>
> >>> This one is needed because the defconfig has:
> >>> CONFIG_TWL4030_USB=y
> >>>
> >>> * http://patchwork.kernel.org/patch/50970/
> >>>
> >>> This is needed because most people boot from an MMC.
> >>
> >> And this should go in via the mmc list.
> >
> > Should it?
> >
> > Here you can see Uwe Kleine-K?nig sending the original patch without
> > even CC'ing the mmc list:
> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >
> > And it was unintentionally broken by this one:
> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
>
> Er, actually that one was ok, the problem was introduced only in the
> final version:
> http://marc.info/?l=linux-mmc&m=125366315417006&w=2
Right, looks like Roger forgot to Cc linux-mmc.
> > I don't see what we are waiting for, the code is clearly broken, even
> > the compiler warns that nobody is using omap_hsmmc_probe().
I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
merged soon:
http://www.mail-archive.com/[email protected]/msg00539.html
Regards,
Tony
Hello,
On Fri, Oct 09, 2009 at 01:13:01AM +0300, Felipe Contreras wrote:
> On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <[email protected]> wrote:
> > * Felipe Contreras <[email protected]> [091008 14:29]:
> >> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
> >> > Linus,
> >> >
> >> > Please pull omap fixes from:
> >> >
> >> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
> >> >
> >> > Regards,
> >> >
> >> > Tony
> >> >
> >> >
> >> > The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
> >> > ?Linus Torvalds (1):
> >> > ? ? ? ?Linux 2.6.32-rc3
> >> >
> >> > are available in the git repository at:
> >> >
> >> > ?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
> >> >
> >> > Artem Bityutskiy (1):
> >> > ? ? ?OMAP3: PM: introduce a new powerdomain walk helper
> >> >
> >> > Daniel Walker (1):
> >> > ? ? ?omap: iovmm: Add missing mutex_unlock
> >> >
> >> > Hiroshi DOYU (1):
> >> > ? ? ?omap: iovmm: Fix incorrect spelling
> >> >
> >> > Jon Hunter (1):
> >> > ? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
> >> >
> >> > Kevin Hilman (1):
> >> > ? ? ?OMAP3: PM: Enable GPIO module-level wakeups
> >> >
> >> > Paul Walmsley (2):
> >> > ? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
> >> > ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
> >> >
> >> > Rajendra Nayak (1):
> >> > ? ? ?omap: Lock DPLL5 at boot
> >> >
> >> > Sergio Aguirre (1):
> >> > ? ? ?omapfb: Condition mutex acquisition
> >> >
> >> > Tommi Rantala (2):
> >> > ? ? ?omapfb: Blizzard: fix pointer to be const
> >> > ? ? ?omapfb: Blizzard: constify register address tables
> >> >
> >> > Tony Lindgren (2):
> >> > ? ? ?omap: Fix incorrect 730 vs 850 detection
> >> > ? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
> >> >
> >> > Vikram Pandita (1):
> >> > ? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
> >> >
> >> > ye janboe (1):
> >> > ? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
> >>
> >> The beagleboard is still not booting for me with this branch, I need
> >> to add these two patches:
> >>
> >> * http://patchwork.kernel.org/patch/50721/
> >>
> >
> > This should go to the mainline kernel via Samuel as it's
> > drivers/mfd related.
> >
> >> This one is needed because the defconfig has:
> >> CONFIG_TWL4030_USB=y
> >>
> >> * http://patchwork.kernel.org/patch/50970/
> >>
> >> This is needed because most people boot from an MMC.
> >
> > And this should go in via the mmc list.
>
> Should it?
>
> Here you can see Uwe Kleine-K?nig sending the original patch without
> even CC'ing the mmc list:
> http://marc.info/?l=linux-kernel&m=124820861213849&w=2
Note these are different patches. Mine fixes a section problem as the
probe function used to live in .init.text but was still used with
platform_driver_register.
Other than that you can add my Acked-by: for "omap_hsmmc: Add missing
probe handler hook to platform driver data".
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
2009/10/9 Uwe Kleine-König <[email protected]>:
> Hello,
>
> On Fri, Oct 09, 2009 at 01:13:01AM +0300, Felipe Contreras wrote:
>> On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <[email protected]> wrote:
>> > * Felipe Contreras <[email protected]> [091008 14:29]:
>> >> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
>> >> > Linus,
>> >> >
>> >> > Please pull omap fixes from:
>> >> >
>> >> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>> >> >
>> >> > Regards,
>> >> >
>> >> > Tony
>> >> >
>> >> >
>> >> > The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
>> >> > Linus Torvalds (1):
>> >> > Linux 2.6.32-rc3
>> >> >
>> >> > are available in the git repository at:
>> >> >
>> >> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>> >> >
>> >> > Artem Bityutskiy (1):
>> >> > OMAP3: PM: introduce a new powerdomain walk helper
>> >> >
>> >> > Daniel Walker (1):
>> >> > omap: iovmm: Add missing mutex_unlock
>> >> >
>> >> > Hiroshi DOYU (1):
>> >> > omap: iovmm: Fix incorrect spelling
>> >> >
>> >> > Jon Hunter (1):
>> >> > OMAP3: PM: Prevent hang in prcm_interrupt_handler
>> >> >
>> >> > Kevin Hilman (1):
>> >> > OMAP3: PM: Enable GPIO module-level wakeups
>> >> >
>> >> > Paul Walmsley (2):
>> >> > OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
>> >> > OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
>> >> >
>> >> > Rajendra Nayak (1):
>> >> > omap: Lock DPLL5 at boot
>> >> >
>> >> > Sergio Aguirre (1):
>> >> > omapfb: Condition mutex acquisition
>> >> >
>> >> > Tommi Rantala (2):
>> >> > omapfb: Blizzard: fix pointer to be const
>> >> > omapfb: Blizzard: constify register address tables
>> >> >
>> >> > Tony Lindgren (2):
>> >> > omap: Fix incorrect 730 vs 850 detection
>> >> > Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
>> >> >
>> >> > Vikram Pandita (1):
>> >> > OMAP3: PM: USBHOST: clear wakeup events on both hosts
>> >> >
>> >> > ye janboe (1):
>> >> > omap: SRAM: flush the right address after memcpy in omap_sram_push
>> >>
>> >> The beagleboard is still not booting for me with this branch, I need
>> >> to add these two patches:
>> >>
>> >> * http://patchwork.kernel.org/patch/50721/
>> >>
>> >
>> > This should go to the mainline kernel via Samuel as it's
>> > drivers/mfd related.
>> >
>> >> This one is needed because the defconfig has:
>> >> CONFIG_TWL4030_USB=y
>> >>
>> >> * http://patchwork.kernel.org/patch/50970/
>> >>
>> >> This is needed because most people boot from an MMC.
>> >
>> > And this should go in via the mmc list.
>>
>> Should it?
>>
>> Here you can see Uwe Kleine-König sending the original patch without
>> even CC'ing the mmc list:
>> http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> Note these are different patches. Mine fixes a section problem as the
> probe function used to live in .init.text but was still used with
> platform_driver_register.
Maybe you looked at the wrong diff. This is the patch that is going to
be pushed eventually:
http://marc.info/?l=linux-mmc&m=125504287632070&w=2
As you can see it's restoring back what you intended in the original patch.
--
Felipe Contreras
Hello,
On Fri, Oct 09, 2009 at 11:25:47AM +0300, Felipe Contreras wrote:
> 2009/10/9 Uwe Kleine-K?nig <[email protected]>:
> > Hello,
> >
> > On Fri, Oct 09, 2009 at 01:13:01AM +0300, Felipe Contreras wrote:
> >> On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <[email protected]> wrote:
> >> > * Felipe Contreras <[email protected]> [091008 14:29]:
> >> >> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:
> >> >> > Linus,
> >> >> >
> >> >> > Please pull omap fixes from:
> >> >> >
> >> >> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
> >> >> >
> >> >> > Regards,
> >> >> >
> >> >> > Tony
> >> >> >
> >> >> >
> >> >> > The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
> >> >> > ?Linus Torvalds (1):
> >> >> > ? ? ? ?Linux 2.6.32-rc3
> >> >> >
> >> >> > are available in the git repository at:
> >> >> >
> >> >> > ?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
> >> >> >
> >> >> > Artem Bityutskiy (1):
> >> >> > ? ? ?OMAP3: PM: introduce a new powerdomain walk helper
> >> >> >
> >> >> > Daniel Walker (1):
> >> >> > ? ? ?omap: iovmm: Add missing mutex_unlock
> >> >> >
> >> >> > Hiroshi DOYU (1):
> >> >> > ? ? ?omap: iovmm: Fix incorrect spelling
> >> >> >
> >> >> > Jon Hunter (1):
> >> >> > ? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
> >> >> >
> >> >> > Kevin Hilman (1):
> >> >> > ? ? ?OMAP3: PM: Enable GPIO module-level wakeups
> >> >> >
> >> >> > Paul Walmsley (2):
> >> >> > ? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
> >> >> > ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
> >> >> >
> >> >> > Rajendra Nayak (1):
> >> >> > ? ? ?omap: Lock DPLL5 at boot
> >> >> >
> >> >> > Sergio Aguirre (1):
> >> >> > ? ? ?omapfb: Condition mutex acquisition
> >> >> >
> >> >> > Tommi Rantala (2):
> >> >> > ? ? ?omapfb: Blizzard: fix pointer to be const
> >> >> > ? ? ?omapfb: Blizzard: constify register address tables
> >> >> >
> >> >> > Tony Lindgren (2):
> >> >> > ? ? ?omap: Fix incorrect 730 vs 850 detection
> >> >> > ? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
> >> >> >
> >> >> > Vikram Pandita (1):
> >> >> > ? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
> >> >> >
> >> >> > ye janboe (1):
> >> >> > ? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
> >> >>
> >> >> The beagleboard is still not booting for me with this branch, I need
> >> >> to add these two patches:
> >> >>
> >> >> * http://patchwork.kernel.org/patch/50721/
> >> >>
> >> >
> >> > This should go to the mainline kernel via Samuel as it's
> >> > drivers/mfd related.
> >> >
> >> >> This one is needed because the defconfig has:
> >> >> CONFIG_TWL4030_USB=y
> >> >>
> >> >> * http://patchwork.kernel.org/patch/50970/
> >> >>
> >> >> This is needed because most people boot from an MMC.
> >> >
> >> > And this should go in via the mmc list.
> >>
> >> Should it?
> >>
> >> Here you can see Uwe Kleine-K?nig sending the original patch without
> >> even CC'ing the mmc list:
> >> http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> > Note these are different patches. ?Mine fixes a section problem as the
> > probe function used to live in .init.text but was still used with
> > platform_driver_register.
>
> Maybe you looked at the wrong diff. This is the patch that is going to
> be pushed eventually:
> http://marc.info/?l=linux-mmc&m=125504287632070&w=2
>
> As you can see it's restoring back what you intended in the original patch.
Yes, but back then it was broken in a different way. Now the driver's
probe function hasn't been called at all. My fix addressed a possible
oops because it could be called when is was already discarded.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Fri, Oct 9, 2009 at 2:26 AM, Tony Lindgren <[email protected]> wrote:
> * Felipe Contreras <[email protected]> [091008 15:20]:
<snip/>
>> > Here you can see Uwe Kleine-König sending the original patch without
>> > even CC'ing the mmc list:
>> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
>> >
>> > And it was unintentionally broken by this one:
>> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
>>
>> Er, actually that one was ok, the problem was introduced only in the
>> final version:
>> http://marc.info/?l=linux-mmc&m=125366315417006&w=2
>
> Right, looks like Roger forgot to Cc linux-mmc.
>
>> > I don't see what we are waiting for, the code is clearly broken, even
>> > the compiler warns that nobody is using omap_hsmmc_probe().
>
> I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
> merged soon:
>
> http://www.mail-archive.com/[email protected]/msg00539.html
I don't see what's specific about mmc in that patch, nor omap. It's
just a fix for an obvious mistake that must be picked ASAP and can't
possibly be NAK'ed.
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
And one for includecheck:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew
Morton because I think they might interested in fixing these kinds of
issues quickly in the future.
Cheers.
--
Felipe Contreras
On Fri, Oct 09, 2009 at 03:08:00PM +0300, Felipe Contreras wrote:
> On Fri, Oct 9, 2009 at 2:26 AM, Tony Lindgren <[email protected]> wrote:
> > * Felipe Contreras <[email protected]> [091008 15:20]:
>
> <snip/>
>
> >> > Here you can see Uwe Kleine-K??nig sending the original patch without
> >> > even CC'ing the mmc list:
> >> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >> >
> >> > And it was unintentionally broken by this one:
> >> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
> >>
> >> Er, actually that one was ok, the problem was introduced only in the
> >> final version:
> >> http://marc.info/?l=linux-mmc&m=125366315417006&w=2
> >
> > Right, looks like Roger forgot to Cc linux-mmc.
> >
> >> > I don't see what we are waiting for, the code is clearly broken, even
> >> > the compiler warns that nobody is using omap_hsmmc_probe().
> >
> > I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
> > merged soon:
> >
> > http://www.mail-archive.com/[email protected]/msg00539.html
>
> I don't see what's specific about mmc in that patch, nor omap. It's
> just a fix for an obvious mistake that must be picked ASAP and can't
> possibly be NAK'ed.
>
> There's a tree for trivial fixes:
> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
>
> And one for includecheck:
> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
>
> What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew
> Morton because I think they might interested in fixing these kinds of
> issues quickly in the future.
What kind of issues? Why would I be interested, where is the problem?
confused,
greg k-h
On Fri, Oct 9, 2009 at 5:48 PM, Greg KH <[email protected]> wrote:
> On Fri, Oct 09, 2009 at 03:08:00PM +0300, Felipe Contreras wrote:
>> On Fri, Oct 9, 2009 at 2:26 AM, Tony Lindgren <[email protected]> wrote:
>> > * Felipe Contreras <[email protected]> [091008 15:20]:
>>
>> <snip/>
>>
>> >> > Here you can see Uwe Kleine-K??nig sending the original patch without
>> >> > even CC'ing the mmc list:
>> >> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
>> >> >
>> >> > And it was unintentionally broken by this one:
>> >> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
>> >>
>> >> Er, actually that one was ok, the problem was introduced only in the
>> >> final version:
>> >> http://marc.info/?l=linux-mmc&m=125366315417006&w=2
>> >
>> > Right, looks like Roger forgot to Cc linux-mmc.
>> >
>> >> > I don't see what we are waiting for, the code is clearly broken, even
>> >> > the compiler warns that nobody is using omap_hsmmc_probe().
>> >
>> > I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
>> > merged soon:
>> >
>> > http://www.mail-archive.com/[email protected]/msg00539.html
>>
>> I don't see what's specific about mmc in that patch, nor omap. It's
>> just a fix for an obvious mistake that must be picked ASAP and can't
>> possibly be NAK'ed.
>>
>> There's a tree for trivial fixes:
>> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
>>
>> And one for includecheck:
>> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
>>
>> What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew
>> Morton because I think they might interested in fixing these kinds of
>> issues quickly in the future.
>
> What kind of issues? Why would I be interested, where is the problem?
The obvious-brain-dead-duh kind of issues, like this one.
The problem is that OMAP devices (like beagleboard) are not booting
correctly right now because of a wrong merge. It has been identified,
tested, and acked, but nobody has picked it up for a pull request, so
it's not clear it will be on -rc4.
To me it's not clear who should push the patch, it seems it doesn't
belong on linux-omap, so Tony is pushing it through linux-mmc, which I
don't think is the right place. They should be handling mmc-related
issues, not obvious breakage.
In order to keep the engines oiled I think there must be a process to
flag obvious generic breakage so it's immediately picked; maybe an
'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial',
'includecheck', and similar, or maybe nothing needs to be done. Up to
you to decide.
Cheers.
--
Felipe Contreras
On Fri, Oct 09, 2009 at 08:29:24PM +0300, Felipe Contreras wrote:
> On Fri, Oct 9, 2009 at 5:48 PM, Greg KH <[email protected]> wrote:
> > On Fri, Oct 09, 2009 at 03:08:00PM +0300, Felipe Contreras wrote:
> >> On Fri, Oct 9, 2009 at 2:26 AM, Tony Lindgren <[email protected]> wrote:
> >> > * Felipe Contreras <[email protected]> [091008 15:20]:
> >>
> >> <snip/>
> >>
> >> >> > Here you can see Uwe Kleine-K??nig sending the original patch without
> >> >> > even CC'ing the mmc list:
> >> >> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >> >> >
> >> >> > And it was unintentionally broken by this one:
> >> >> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
> >> >>
> >> >> Er, actually that one was ok, the problem was introduced only in the
> >> >> final version:
> >> >> http://marc.info/?l=linux-mmc&m=125366315417006&w=2
> >> >
> >> > Right, looks like Roger forgot to Cc linux-mmc.
> >> >
> >> >> > I don't see what we are waiting for, the code is clearly broken, even
> >> >> > the compiler warns that nobody is using omap_hsmmc_probe().
> >> >
> >> > I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
> >> > merged soon:
> >> >
> >> > http://www.mail-archive.com/[email protected]/msg00539.html
> >>
> >> I don't see what's specific about mmc in that patch, nor omap. It's
> >> just a fix for an obvious mistake that must be picked ASAP and can't
> >> possibly be NAK'ed.
> >>
> >> There's a tree for trivial fixes:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
> >>
> >> And one for includecheck:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
> >>
> >> What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew
> >> Morton because I think they might interested in fixing these kinds of
> >> issues quickly in the future.
> >
> > What kind of issues? ?Why would I be interested, where is the problem?
>
> The obvious-brain-dead-duh kind of issues, like this one.
>
> The problem is that OMAP devices (like beagleboard) are not booting
> correctly right now because of a wrong merge. It has been identified,
> tested, and acked, but nobody has picked it up for a pull request, so
> it's not clear it will be on -rc4.
Has the patches been sent from the maintainer to Linus?
Who is the maintainer? Who normally sends this stuff?
> To me it's not clear who should push the patch, it seems it doesn't
> belong on linux-omap, so Tony is pushing it through linux-mmc, which I
> don't think is the right place. They should be handling mmc-related
> issues, not obvious breakage.
Well, mmc related breakage is fine to handle :)
> In order to keep the engines oiled I think there must be a process to
> flag obvious generic breakage so it's immediately picked; maybe an
> 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial',
> 'includecheck', and similar, or maybe nothing needs to be done. Up to
> you to decide.
Andrew usually sends stuff like this at times.
thanks,
greg k-h
On Fri, 9 Oct 2009 12:26:42 -0700
Greg KH <[email protected]> wrote:
> > >
> > > What kind of issues? __Why would I be interested, where is the problem?
> >
> > The obvious-brain-dead-duh kind of issues, like this one.
> >
> > The problem is that OMAP devices (like beagleboard) are not booting
> > correctly right now because of a wrong merge. It has been identified,
> > tested, and acked, but nobody has picked it up for a pull request, so
> > it's not clear it will be on -rc4.
>
> Has the patches been sent from the maintainer to Linus?
>
> Who is the maintainer? Who normally sends this stuff?
>
> > To me it's not clear who should push the patch, it seems it doesn't
> > belong on linux-omap, so Tony is pushing it through linux-mmc, which I
> > don't think is the right place. They should be handling mmc-related
> > issues, not obvious breakage.
>
> Well, mmc related breakage is fine to handle :)
>
> > In order to keep the engines oiled I think there must be a process to
> > flag obvious generic breakage so it's immediately picked; maybe an
> > 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial',
> > 'includecheck', and similar, or maybe nothing needs to be done. Up to
> > you to decide.
>
> Andrew usually sends stuff like this at times.
yeah, when in doubt, send it to me. When not in doubt send it to me
anyway ;)
I'll take care of bugging the appropriate maintainer or merging it directly.
On Fri, 9 Oct 2009, Greg KH wrote:
> > >> There's a tree for trivial fixes:
> > >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
Well, as this is quite a high-priority functional fix, I'd suggest using
other channels that trivial tree, as this one is primarily intended for
simple fixes that are not really urgent.
> > The problem is that OMAP devices (like beagleboard) are not booting
> > correctly right now because of a wrong merge. It has been identified,
> > tested, and acked, but nobody has picked it up for a pull request, so
> > it's not clear it will be on -rc4.
> Has the patches been sent from the maintainer to Linus?
> Who is the maintainer? Who normally sends this stuff?
The problem is that MMC now doesn't have proper maintainer, since Pierre
stepped down from maintaining this stuff.
Still, for the fix mentioned on
http://www.mail-archive.com/[email protected]/msg00539.html
the most appropriate contact would probably be Madhusudhan Chikkature.
Adding him to CC of this thread.
--
Jiri Kosina
SUSE Labs, Novell Inc.
On Fri, 9 Oct 2009 23:42:27 +0200 (CEST)
Jiri Kosina <[email protected]> wrote:
> On Fri, 9 Oct 2009, Greg KH wrote:
>
> > > >> There's a tree for trivial fixes:
> > > >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
>
> Well, as this is quite a high-priority functional fix, I'd suggest using
> other channels that trivial tree, as this one is primarily intended for
> simple fixes that are not really urgent.
>
> > > The problem is that OMAP devices (like beagleboard) are not booting
> > > correctly right now because of a wrong merge. It has been identified,
> > > tested, and acked, but nobody has picked it up for a pull request, so
> > > it's not clear it will be on -rc4.
> > Has the patches been sent from the maintainer to Linus?
> > Who is the maintainer? Who normally sends this stuff?
>
> The problem is that MMC now doesn't have proper maintainer, since Pierre
> stepped down from maintaining this stuff.
>
> Still, for the fix mentioned on
>
> http://www.mail-archive.com/[email protected]/msg00539.html
>
> the most appropriate contact would probably be Madhusudhan Chikkature.
> Adding him to CC of this thread.
hm. What's all the fuss about? That patch was sent To:me and affects
only MMC and is clearly a bugfix. I'll merge it when i get to it
(hopefully tomorrow) then all is good?
> -----Original Message-----
> From: Jiri Kosina [mailto:[email protected]]
> Sent: Friday, October 09, 2009 4:42 PM
> To: Greg KH
> Cc: Felipe Contreras; Tony Lindgren; Linus Torvalds; linux-
> [email protected]; [email protected]; Denis Karpov; Uwe
> Kleine-K??nig; Andrew Morton; Madhusudhan Chikkature
> Subject: Re: [GIT PULL] omap fixes for v2.6.32-rc3
>
> On Fri, 9 Oct 2009, Greg KH wrote:
>
> > > >> There's a tree for trivial fixes:
> > > >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
>
> Well, as this is quite a high-priority functional fix, I'd suggest using
> other channels that trivial tree, as this one is primarily intended for
> simple fixes that are not really urgent.
>
> > > The problem is that OMAP devices (like beagleboard) are not booting
> > > correctly right now because of a wrong merge. It has been identified,
> > > tested, and acked, but nobody has picked it up for a pull request, so
> > > it's not clear it will be on -rc4.
> > Has the patches been sent from the maintainer to Linus?
> > Who is the maintainer? Who normally sends this stuff?
>
> The problem is that MMC now doesn't have proper maintainer, since Pierre
> stepped down from maintaining this stuff.
>
> Still, for the fix mentioned on
>
> http://www.mail-archive.com/[email protected]/msg00539.html
>
> the most appropriate contact would probably be Madhusudhan Chikkature.
> Adding him to CC of this thread.
>
Since this fix was posted in Linux-omap, Tony pointed this out to Andrew so
that the fix will go upstream. That should this fix this mmc issue.
Regards,
Madhu
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
On Sat, Oct 10, 2009 at 12:33 AM, Andrew Morton
<[email protected]> wrote:
> On Fri, 9 Oct 2009 12:26:42 -0700
> Greg KH <[email protected]> wrote:
>
>> > >
>> > > What kind of issues? __Why would I be interested, where is the problem?
>> >
>> > The obvious-brain-dead-duh kind of issues, like this one.
>> >
>> > The problem is that OMAP devices (like beagleboard) are not booting
>> > correctly right now because of a wrong merge. It has been identified,
>> > tested, and acked, but nobody has picked it up for a pull request, so
>> > it's not clear it will be on -rc4.
>>
>> Has the patches been sent from the maintainer to Linus?
>>
>> Who is the maintainer? Who normally sends this stuff?
>>
>> > To me it's not clear who should push the patch, it seems it doesn't
>> > belong on linux-omap, so Tony is pushing it through linux-mmc, which I
>> > don't think is the right place. They should be handling mmc-related
>> > issues, not obvious breakage.
>>
>> Well, mmc related breakage is fine to handle :)
>>
>> > In order to keep the engines oiled I think there must be a process to
>> > flag obvious generic breakage so it's immediately picked; maybe an
>> > 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial',
>> > 'includecheck', and similar, or maybe nothing needs to be done. Up to
>> > you to decide.
>>
>> Andrew usually sends stuff like this at times.
>
> yeah, when in doubt, send it to me. When not in doubt send it to me
> anyway ;)
>
> I'll take care of bugging the appropriate maintainer or merging it directly.
Ah, that's exactly what I wanted to know, thanks :)
--
Felipe Contreras