2019-03-22 14:16:20

by Yue Haibing

Subject: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static

From: YueHaibing <[email protected]>

Fix sparse warning:

drivers/mmc/host/sdhci-omap.c:788:6: warning:
symbol 'sdhci_omap_reset' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/mmc/host/sdhci-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 5bbed47..649c03f 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
sdhci_omap_start_clock(omap_host);
}

-void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
+static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
--
2.7.0

2019-03-22 14:23:12

by Faiz Abbas

Subject: Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static

Hi,

On 22/03/19 7:41 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Faiz Abbas <[email protected]>

Thanks,
Faiz

2019-03-25 10:19:53

by Adrian Hunter

Subject: Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static

On 22/03/19 4:11 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/host/sdhci-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 5bbed47..649c03f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
> sdhci_omap_start_clock(omap_host);
> }
>
> -void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> +static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>

2019-03-25 13:28:50

by Ulf Hansson

Subject: Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static

On Fri, 22 Mar 2019 at 15:15, Yue Haibing <[email protected]> wrote:
>
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 5bbed47..649c03f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
> sdhci_omap_start_clock(omap_host);
> }
>
> -void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> +static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
> --
> 2.7.0
>
>