I am getting the following warning when I build kernel 4.9-git on my PowerBook
G4 with a 32-bit PPC processor:
AS arch/powerpc/kernel/misc_32.o
arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined
[-Wundef]
This problem has been bisected to commit 989cea5c14be ("kbuild: prevent
lib-ksyms.o rebuilds").
Thanks,
Larry
On Wed, 21 Dec 2016 13:49:07 -0600
Larry Finger <[email protected]> wrote:
> I am getting the following warning when I build kernel 4.9-git on my PowerBook
> G4 with a 32-bit PPC processor:
>
> AS arch/powerpc/kernel/misc_32.o
> arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined
> [-Wundef]
>
> This problem has been bisected to commit 989cea5c14be ("kbuild: prevent
> lib-ksyms.o rebuilds").
>
> Thanks,
>
> Larry
Hi Larry,
This is strange you've bisected it there, I can't see how that patch would
trigger it. That said, powerpc has had a few small build system glitches.
It looks like this warning could be fixed by changing #elif CONFIG_FSL_BOOKE
to #elif defined (CONFIG_FSL_BOOKE). Want to send a patch (if it works)?
Thanks,
Nick
On 12/21/2016 08:02 PM, Nicholas Piggin wrote:
> Hi Larry,
>
> This is strange you've bisected it there, I can't see how that patch would
> trigger it. That said, powerpc has had a few small build system glitches.
>
> It looks like this warning could be fixed by changing #elif CONFIG_FSL_BOOKE
> to #elif defined (CONFIG_FSL_BOOKE). Want to send a patch (if it works)?
Nick,
I agree that the "bad" commit does not look likely to be the problem, but I
verified it by checking out the previous commit, which does not show the
problem. I'm quite sure that PowerPC has a lot of quirks and glitches beyond
those caused by the Apple hardware.
I have tested the change and I will submit the patch.
Thanks,
Larry