2020-06-29 20:40:17

by Robin Gong

Subject: [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE

Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
'0x0005 --> BIT(3) | BIT(0))'

Fixes: 4d6d3a90e4ac ("dmaengine: fsl-edma: fix macros")
Cc: [email protected]
Signed-off-by: Robin Gong <[email protected]>
---
drivers/dma/fsl-edma-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
index 67e4225..ec11697 100644
--- a/drivers/dma/fsl-edma-common.h
+++ b/drivers/dma/fsl-edma-common.h
@@ -33,7 +33,7 @@
#define EDMA_TCD_ATTR_DSIZE_16BIT BIT(0)
#define EDMA_TCD_ATTR_DSIZE_32BIT BIT(1)
#define EDMA_TCD_ATTR_DSIZE_64BIT (BIT(0) | BIT(1))
-#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(3) | BIT(0))
+#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(2) | BIT(0))
#define EDMA_TCD_ATTR_SSIZE_8BIT 0
#define EDMA_TCD_ATTR_SSIZE_16BIT (EDMA_TCD_ATTR_DSIZE_16BIT << 8)
#define EDMA_TCD_ATTR_SSIZE_32BIT (EDMA_TCD_ATTR_DSIZE_32BIT << 8)
--
2.7.4

2020-07-02 11:18:00

by Angelo Dureghello

Subject: Re: [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE

Hi Robin,

29.06.2020, 10:53, "Robin Gong" <[email protected]>:
> Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
> '0x0005 --> BIT(3) | BIT(0))'
>
> Fixes: 4d6d3a90e4ac ("dmaengine: fsl-edma: fix macros")
> Cc: [email protected]
> Signed-off-by: Robin Gong <[email protected]>
> ---
>  drivers/dma/fsl-edma-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
> index 67e4225..ec11697 100644
> --- a/drivers/dma/fsl-edma-common.h
> +++ b/drivers/dma/fsl-edma-common.h
> @@ -33,7 +33,7 @@
>  #define EDMA_TCD_ATTR_DSIZE_16BIT BIT(0)
>  #define EDMA_TCD_ATTR_DSIZE_32BIT BIT(1)
>  #define EDMA_TCD_ATTR_DSIZE_64BIT (BIT(0) | BIT(1))
> -#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(3) | BIT(0))
> +#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(2) | BIT(0))

looks like i need some glasses. Thanks a lot for the fix.
I probably missed it since not using 16bytes transfers.

Tested-by: Angelo Dureghello <[email protected]>


Regards,
angelo

>  #define EDMA_TCD_ATTR_SSIZE_8BIT 0
>  #define EDMA_TCD_ATTR_SSIZE_16BIT (EDMA_TCD_ATTR_DSIZE_16BIT << 8)
>  #define EDMA_TCD_ATTR_SSIZE_32BIT (EDMA_TCD_ATTR_DSIZE_32BIT << 8)
> --
> 2.7.4

2020-07-06 04:55:35

by Vinod Koul

Subject: Re: [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE

On 30-06-20, 00:59, Robin Gong wrote:
> Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
> '0x0005 --> BIT(3) | BIT(0))'

Applied, thanks

--
~Vinod