2019-09-05 22:26:56

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v3] watchdog: qcom: support pre-timeout when the bark irq is available

On Thu, Sep 05, 2019 at 08:24:19PM +0200, Jorge Ramirez-Ortiz wrote:
> Use the bark interrupt as the pre-timeout notifier whenever this
> interrupt is available.
>
> By default, the pretimeout notification shall occur one second earlier
> than the timeout.
>
> Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>

Can you please give people time to reply before flooding the mailing list
with revisions ? This is getting annoying quite rapidly. I am going to
reply to v2, as I had started on that already (and to the one without
subject before).

Guenter


2019-09-06 08:18:16

by Jorge Ramirez-Ortiz

[permalink] [raw]
Subject: Re: [PATCH v3] watchdog: qcom: support pre-timeout when the bark irq is available

On 9/5/19 20:34, Guenter Roeck wrote:
> On Thu, Sep 05, 2019 at 08:24:19PM +0200, Jorge Ramirez-Ortiz wrote:
>> Use the bark interrupt as the pre-timeout notifier whenever this
>> interrupt is available.
>>
>> By default, the pretimeout notification shall occur one second earlier
>> than the timeout.
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
>
> Can you please give people time to reply before flooding the mailing list
> with revisions ? This is getting annoying quite rapidly. I am going to
> reply to v2, as I had started on that already (and to the one without
> subject before).

yes, sorry about it. it is not frequent that someone gives a review so
quickly though so I thought I had time to sneak in some reworks - thanks
and apologies again.

I am about to send v4 addressing the issues you raised.

>
> Guenter
> .
>