2024-02-10 01:14:43

by Unnathi Chalicheemala

Subject: [PATCH v2] soc: qcom: llcc: Check return value on Broadcast_OR reg read

Commit c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
introduced a new 4.1 if statement in llcc_update_act_ctrl() without
considering that ret might be overwritten. So, adding return value check
after Broadcast_OR register read in llcc_update_act_ctrl().

Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")

Signed-off-by: Unnathi Chalicheemala <[email protected]>
Reviewed-by: Elliot Berman <[email protected]>

---
Changes in v2:
- Referenced right commit to be fixed in the commit message.
- Added Elliot's R-B tag.
- Modified commit message to better explain problem statement.
- Link to v1: https://lore.kernel.org/all/[email protected]/

---
drivers/soc/qcom/llcc-qcom.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 4ca88eaebf06..cbef0dea1d5d 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -859,6 +859,8 @@ static int llcc_update_act_ctrl(u32 sid,
ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg,
slice_status, !(slice_status & status),
0, LLCC_STATUS_READ_DELAY);
+ if (ret)
+ return ret;

if (drv_data->version >= LLCC_VERSION_4_1_0_0)
ret = regmap_write(drv_data->bcast_regmap, act_clear_reg,
--
2.25.1

2024-02-10 01:30:58

by Jeff Johnson

Subject: Re: [PATCH v2] soc: qcom: llcc: Check return value on Broadcast_OR reg read

On 2/9/2024 5:14 PM, Unnathi Chalicheemala wrote:
> Commit c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> introduced a new 4.1 if statement in llcc_update_act_ctrl() without
> considering that ret might be overwritten. So, adding return value check

nit: s/adding/add/ (use imperative voice)

> after Broadcast_OR register read in llcc_update_act_ctrl().
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support">

remove this blank line -- the Fixes tag should be grouped with the other
tags

> Signed-off-by: Unnathi Chalicheemala <[email protected]>
> Reviewed-by: Elliot Berman <[email protected]>
>
> ---
> Changes in v2:
> - Referenced right commit to be fixed in the commit message.
> - Added Elliot's R-B tag.
> - Modified commit message to better explain problem statement.
> - Link to v1: https://lore.kernel.org/all/[email protected]/
>
> ---
> drivers/soc/qcom/llcc-qcom.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 4ca88eaebf06..cbef0dea1d5d 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -859,6 +859,8 @@ static int llcc_update_act_ctrl(u32 sid,
> ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg,
> slice_status, !(slice_status & status),
> 0, LLCC_STATUS_READ_DELAY);
> + if (ret)
> + return ret;
>
> if (drv_data->version >= LLCC_VERSION_4_1_0_0)
> ret = regmap_write(drv_data->bcast_regmap, act_clear_reg,

2024-02-12 18:12:27

by Unnathi Chalicheemala

Subject: Re: [PATCH v2] soc: qcom: llcc: Check return value on Broadcast_OR reg read

On 2/9/2024 5:30 PM, Jeff Johnson wrote:
> On 2/9/2024 5:14 PM, Unnathi Chalicheemala wrote:
>> Commit c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
>> introduced a new 4.1 if statement in llcc_update_act_ctrl() without
>> considering that ret might be overwritten. So, adding return value check
>
> nit: s/adding/add/ (use imperative voice)
>

Ack.

>> after Broadcast_OR register read in llcc_update_act_ctrl().
>>
>> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support">
>
> remove this blank line -- the Fixes tag should be grouped with the other
> tags
>

Ack. I'll post v3 with these changes, thanks Jeff.

>> Signed-off-by: Unnathi Chalicheemala <[email protected]>
>> Reviewed-by: Elliot Berman <[email protected]>