2022-10-18 03:08:27

by Yuwei Guan

Subject: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue

it defined in d0edc2473be9d, but there's nowhere to use it,
so remove it.

Signed-off-by: Yuwei Guan <[email protected]>
Acked-by: Paolo Valente <[email protected]>
---
block/bfq-iosched.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 64ee618064ba..71f721670ab6 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -369,12 +369,8 @@ struct bfq_queue {
unsigned long split_time; /* time of last split */

unsigned long first_IO_time; /* time of first I/O for this queue */
-
unsigned long creation_time; /* when this queue is created */

- /* max service rate measured so far */
- u32 max_service_rate;
-
/*
* Pointer to the waker queue for this queue, i.e., to the
* queue Q such that this queue happens to get new I/O right
--
2.34.1

2022-10-20 12:55:16

by Yuwei Guan

Subject: Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue

Hi Jens,

On 2022/10/18 11:01, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
> Signed-off-by: Yuwei Guan <[email protected]>
> Acked-by: Paolo Valente <[email protected]>
> ---
> block/bfq-iosched.h | 4 ----
> 1 file changed, 4 deletions(-)

Can you help to check this patch again?

Thanks

> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..71f721670ab6 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -369,12 +369,8 @@ struct bfq_queue {
> unsigned long split_time; /* time of last split */
>
> unsigned long first_IO_time; /* time of first I/O for this queue */
> -
> unsigned long creation_time; /* when this queue is created */
>
> - /* max service rate measured so far */
> - u32 max_service_rate;
> -
> /*
> * Pointer to the waker queue for this queue, i.e., to the
> * queue Q such that this queue happens to get new I/O right

2022-10-20 13:41:36

by Jens Axboe

Subject: Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue

On Tue, 18 Oct 2022 11:01:39 +0800, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
>

Applied, thanks!

[1/1] block, bfq: remove unused variable for bfq_queue
commit: 33566f92cd5f1c1d462920978f6dc102c744270d

Best regards,
--
Jens Axboe