2022-03-10 00:30:31

by Alyssa Rosenzweig

[permalink] [raw]
Subject: Re: [PATCH v3 0/7] irqchip/apple-aic: Add support for AICv2

> This also adds support for multi-die AIC2 controllers. While no
> multi-die products exist yet, the AIC2 in t600x is built to support
> up to 2 dies, and it's pretty clear how it works, so let's implement
> it. If we're lucky, when multi-die products roll around, this will
> let us support them with only DT changes. In order to support the
> extra die dimension, this introduces a 4-argument IRQ phandle form
> (3-argument is always supported and just implies die 0).

Given you have a multidie device in the mail, it's probably best to
defer merging this series until the multidie code paths are confirmed
working there?


2022-03-10 09:20:47

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH v3 0/7] irqchip/apple-aic: Add support for AICv2

On 2022-03-09 20:30, Alyssa Rosenzweig wrote:
>> This also adds support for multi-die AIC2 controllers. While no
>> multi-die products exist yet, the AIC2 in t600x is built to support
>> up to 2 dies, and it's pretty clear how it works, so let's implement
>> it. If we're lucky, when multi-die products roll around, this will
>> let us support them with only DT changes. In order to support the
>> extra die dimension, this introduces a 4-argument IRQ phandle form
>> (3-argument is always supported and just implies die 0).
>
> Given you have a multidie device in the mail, it's probably best to
> defer merging this series until the multidie code paths are confirmed
> working there?

This code is used on Pro and Max systems, so it has some value as is.
Not to mention that it makes things slightly faster on the original M1
too.

M.
--
Jazz is not dead. It just smells funny...