2018-09-17 14:08:12

by Håkon Bugge

Subject: [PATCH] RDMA/i40iw: Fix incorrect iterator type

Commit f27b4746f378 ("i40iw: add connection management code") uses an
incorrect rcu iterator, whilst holding the rtnl_lock. Since the
critical region invokes i40iw_manage_qhash(), which is a sleeping
function, the rcu locking and traversal cannot be used.

Signed-off-by: Håkon Bugge <[email protected]>
---
drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index 423818a7d333..771eb6bd0785 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -1689,7 +1689,7 @@ static enum i40iw_status_code i40iw_add_mqh_6(struct i40iw_device *iwdev,
unsigned long flags;

rtnl_lock();
- for_each_netdev_rcu(&init_net, ip_dev) {
+ for_each_netdev(&init_net, ip_dev) {
if ((((rdma_vlan_dev_vlan_id(ip_dev) < I40IW_NO_VLAN) &&
(rdma_vlan_dev_real_dev(ip_dev) == iwdev->netdev)) ||
(ip_dev == iwdev->netdev)) && (ip_dev->flags & IFF_UP)) {
--
2.14.3

2018-09-19 16:45:06

by Jason Gunthorpe

Subject: Re: [PATCH] RDMA/i40iw: Fix incorrect iterator type

On Mon, Sep 17, 2018 at 04:07:07PM +0200, Håkon Bugge wrote:
> Commit f27b4746f378 ("i40iw: add connection management code") uses an
> incorrect rcu iterator, whilst holding the rtnl_lock. Since the
> critical region invokes i40iw_manage_qhash(), which is a sleeping
> function, the rcu locking and traversal cannot be used.
>
> Signed-off-by: Håkon Bugge <[email protected]>
> ---
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason

2018-09-23 14:28:17

by Shiraz Saleem

Subject: RE: [PATCH] RDMA/i40iw: Fix incorrect iterator type

>Subject: [PATCH] RDMA/i40iw: Fix incorrect iterator type
>
>Commit f27b4746f378 ("i40iw: add connection management code") uses an
>incorrect rcu iterator, whilst holding the rtnl_lock. Since the critical region invokes
>i40iw_manage_qhash(), which is a sleeping function, the rcu locking and
>traversal cannot be used.
>
>Signed-off-by: Håkon Bugge <[email protected]>
>---
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks doing this Hakon!

Acked-by: Shiraz Saleem <[email protected]>