2022-11-15 02:57:51

by Bernhard Rosenkränzer

Subject: [PATCH v2 07/15] dt-bindings: mmc: mtk-sd: add bindings for MT8365 SoC

From: Fabien Parent <[email protected]>

Add MMC bindings for MT8365 bindings.

Signed-off-by: Fabien Parent <[email protected]>
---
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 6f8ecb4788eb8..36f9fce8f4795 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -35,6 +35,9 @@ properties:
- mediatek,mt8192-mmc
- mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
+ - items:
+ - const: mediatek,mt8365-mmc
+ - const: mediatek,mt8183-mmc

reg:
minItems: 1
--
2.38.1

2022-11-15 09:56:22

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 07/15] dt-bindings: mmc: mtk-sd: add bindings for MT8365 SoC

On 15/11/2022 03:54, Bernhard Rosenkränzer wrote:
> From: Fabien Parent <[email protected]>
>
> Add MMC bindings for MT8365 bindings.


Drop second, redundant "bindings" from subject.

>
> Signed-off-by: Fabien Parent <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 6f8ecb4788eb8..36f9fce8f4795 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -35,6 +35,9 @@ properties:
> - mediatek,mt8192-mmc
> - mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> + - items:
> + - const: mediatek,mt8365-mmc
> + - const: mediatek,mt8183-mmc

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof