2022-02-18 01:59:23

by Li-hao Kuo

Subject: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

delete unused required(clock-name)
adjust position (interrupts)

Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")

Reported-by: Rob Herring <[email protected]>
Signed-off-by: Li-hao Kuo <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
index 298eac2..9df08d7 100644
--- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
@@ -47,10 +47,9 @@ required:
- compatible
- reg
- reg-names
- - interrupts
- interrupt-names
+ - interrupts
- clocks
- - clocks-names
- resets
- pinctrl-names
- pinctrl-0
--
2.7.4

2022-02-24 15:26:27

by Rob Herring

Subject: Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

On Thu, Feb 17, 2022 at 7:56 PM Li-hao Kuo <[email protected]> wrote:
>
> delete unused required(clock-name)
> adjust position (interrupts)

Why? This seems like an unnecessary change.

Please write complete sentences that answer why this change is needed,
not what the change is. The diff describes what changed. In this case,
quoting the warning you are fixing is typical.

>
> Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
>

There should not be a blank line here.

> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Li-hao Kuo <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 298eac2..9df08d7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -47,10 +47,9 @@ required:
> - compatible
> - reg
> - reg-names
> - - interrupts
> - interrupt-names
> + - interrupts
> - clocks
> - - clocks-names
> - resets
> - pinctrl-names
> - pinctrl-0
> --
> 2.7.4
>

2022-02-25 01:56:42

by Lh Kuo 郭力豪

Subject: RE: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

Hi Mr.Rob Herring :

I am sorry for that.
This patch will fix testing issues as clock names are not used
Checking for a patch will show a warning